From: Aaro Koskinen <aaro.koskinen@iki.fi>
To: James Morse <james.morse@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Jayachandran Chandrasekharan Nair <jnair@marvell.com>,
Will Deacon <will.deacon@arm.com>,
linux-arm-kernel@lists.infradead.org,
Aaro Koskinen <aaro.koskinen@nokia.com>
Subject: Re: [PATCH 2/2] arm64: Implement panic_smp_self_stop()
Date: Thu, 13 Jun 2019 01:38:22 +0300 [thread overview]
Message-ID: <20190612223822.GA27145@darkstar.musicnaut.iki.fi> (raw)
In-Reply-To: <a91a65a9-5b49-130d-a824-f719071b4263@arm.com>
Hi,
On Wed, Jun 12, 2019 at 04:18:32PM +0100, James Morse wrote:
> On 11/06/2019 19:10, Aaro Koskinen wrote:
> > Currently arm64 uses the default implementation of panic_smp_self_stop()
> > that is simply a cpu_relax() loop. As a result, when two CPUs panic()
> > simultaneously we get "SMP: failed to stop secondary CPUs" warnings and
> > extra delays before a reset.
>
> > Provide an implementation of panic_smp_self_stop() that offlines the
> > CPU properly.
>
> This had me looking to the PSCI call that would take the CPU offline, but its just
> conflicting terminology. Its the:
> | set_cpu_online(cpu, false);
> you're referring to here.
>
> Would 'marks the CPU offline' be clearer?
Yes, I will update the change log. I'll wait and see if there are other
comments as well, and send a new version next week.
> Regardless,
> Reviewed-by: James Morse <james.morse@arm.com>
Thanks,
A.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-12 22:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 18:10 [PATCH 1/2] arm64: Improve parking of stopped CPUs Aaro Koskinen
2019-06-11 18:10 ` [PATCH 2/2] arm64: Implement panic_smp_self_stop() Aaro Koskinen
2019-06-12 15:18 ` James Morse
2019-06-12 22:38 ` Aaro Koskinen [this message]
2019-06-13 9:21 ` Will Deacon
2019-06-13 9:22 ` [PATCH 1/2] arm64: Improve parking of stopped CPUs Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190612223822.GA27145@darkstar.musicnaut.iki.fi \
--to=aaro.koskinen@iki.fi \
--cc=aaro.koskinen@nokia.com \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=jnair@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).