From: Mike Rapoport <rppt@linux.ibm.com>
To: Qian Cai <cai@lca.pw>
Cc: Mark Rutland <mark.rutland@arm.com>,
catalin.marinas@arm.com, Will Deacon <will.deacon@arm.com>,
linux-kernel@vger.kernel.org, mhocko@kernel.org,
linux-mm@kvack.org, vdavydov.dev@gmail.com, hannes@cmpxchg.org,
cgroups@vger.kernel.org, akpm@linux-foundation.org,
Roman Gushchin <guro@fb.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH -next] arm64/mm: fix a bogus GFP flag in pgd_alloc()
Date: Thu, 13 Jun 2019 22:44:28 +0300 [thread overview]
Message-ID: <20190613194427.GC25164@rapoport-lnx> (raw)
In-Reply-To: <1560432156.5154.11.camel@lca.pw>
On Thu, Jun 13, 2019 at 09:22:36AM -0400, Qian Cai wrote:
> On Thu, 2019-06-13 at 15:11 +0300, Mike Rapoport wrote:
> > The log Qian Cai posted at [1] and partially cited below confirms that the
> > failure happens when *user* PGDs are allocated and the addition of
> > __GFP_ACCOUNT to gfp flags used by pgd_alloc() only uncovered another
> > issue.
> >
> > I'm still failing to reproduce it with qemu and I'm not really familiar
> > with slub/memcg code to say anything smart about it. Will keep looking.
> >
> > Note, that as failures start way after efi_virtmap_init() that allocates a
> > PGD for efi_mm, there are no real fixes required for the original series,
> > except that the check for mm == &init_mm I copied for some reason from
> > powerpc is bogus and can be removed.
>
> Yes, there is more places are not happy with __GFP_ACCOUNT other than efi_mm.
> For example,
Here we allocate the pgd for a user process and it should be accounted.
Actually, the whole point of changing the gfp flags in arm64::pgd_alloc()
was to enable the accounting for memory occupied by user pgds, just like
x86 and powerpc do.
> [ 132.786842][ T1501] kobject_add_internal failed for pgd_cache(49:systemd-
> udevd.service) (error: -2 parent: cgroup)
> [ 132.795589][ T1889] CPU: 9 PID: 1889 Comm: systemd-udevd Tainted:
> G W 5.2.0-rc4-next-20190613+ #8
> [ 132.807356][ T1889] Hardware name: HPE Apollo
> 70 /C01_APACHE_MB , BIOS L50_5.13_1.0.9 03/01/2019
> [ 132.817872][ T1889] Call trace:
> [ 132.821017][ T1889] dump_backtrace+0x0/0x268
> [ 132.825372][ T1889] show_stack+0x20/0x2c
> [ 132.829380][ T1889] dump_stack+0xb4/0x108
> [ 132.833475][ T1889] pgd_alloc+0x34/0x5c
> [ 132.837396][ T1889] mm_init+0x27c/0x32c
> [ 132.841315][ T1889] dup_mm+0x84/0x7b4
> [ 132.845061][ T1889] copy_process+0xf20/0x24cc
> [ 132.849500][ T1889] _do_fork+0xa4/0x66c
> [ 132.853420][ T1889] __arm64_sys_clone+0x114/0x1b4
> [ 132.858208][ T1889] el0_svc_handler+0x198/0x260
> [ 132.862821][ T1889] el0_svc+0x8/0xc
>
> >
> > I surely can add pgd_alloc_kernel() to be used by the EFI code to make sure
> > we won't run into issues with memcg in the future.
> >
> > [ 82.125966] Freeing unused kernel memory: 28672K
> > [ 87.940365] Checked W+X mappings: passed, no W+X pages found
> > [ 87.946769] Run /init as init process
> > [ 88.040040] systemd[1]: System time before build time, advancing clock.
> > [ 88.054593] systemd[1]: Failed to insert module 'autofs4': No such file or
> > directory
> > [ 88.374129] modprobe (1726) used greatest stack depth: 28464 bytes left
> > [ 88.470108] systemd[1]: systemd 239 running in system mode. (+PAM +AUDIT
> > +SELINUX +IMA -APPARMOR +SMACK +SYSVINIT +UTMP +LIBCRYPTSETUP +GCRYPT
> > +GNUTLS +ACL +XZ +LZ4 +SECCOMP +BLKID +ELFUTILS +KMOD +IDN2 -IDN +PCRE2
> > default-hierarchy=legacy)
> > [ 88.498398] systemd[1]: Detected architecture arm64.
> > [ 88.506517] systemd[1]: Running in initial RAM disk.
> > [ 89.621995] mkdir (1730) used greatest stack depth: 27872 bytes left
> > [ 90.222658] random: systemd: uninitialized urandom read (16 bytes read)
> > [ 90.230072] systemd[1]: Reached target Swap.
> > [ 90.240205] random: systemd: uninitialized urandom read (16 bytes read)
> > [ 90.251088] systemd[1]: Reached target Timers.
> > [ 90.261303] random: systemd: uninitialized urandom read (16 bytes read)
> > [ 90.271209] systemd[1]: Listening on udev Control Socket.
> > [ 90.283238] systemd[1]: Reached target Local File Systems.
> > [ 90.296232] systemd[1]: Reached target Slices.
> > [ 90.307239] systemd[1]: Listening on udev Kernel Socket.
> > [ 90.608597] kobject_add_internal failed for pgd_cache(13:init.scope)
> > (error: -2 parent: cgroup)
> > [ 90.678007] kobject_add_internal failed for pgd_cache(13:init.scope)(error:
> > -2 parent: cgroup)
> > [ 90.713260] kobject_add_internal failed for pgd_cache(21:systemd-tmpfiles-
> > setup.service) (error: -2 parent: cgroup)
> > [ 90.820012] systemd-tmpfile (1759) used greatest stack depth: 27184 bytes
> > left
> > [ 90.861942] kobject_add_internal failed for pgd_cache(13:init.scope) error:
> > -2 parent: cgroup)
> >
> > > Thanks,
> > > Mark.
> > >
> >
> > [1] https://cailca.github.io/files/dmesg.txt
> >
--
Sincerely yours,
Mike.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-13 19:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 14:00 [PATCH -next] arm64/mm: fix a bogus GFP flag in pgd_alloc() Qian Cai
2019-06-04 14:23 ` Mark Rutland
2019-06-04 14:30 ` Mark Rutland
2019-06-05 21:33 ` Mike Rapoport
2019-06-04 14:54 ` Mike Rapoport
2019-06-10 11:43 ` Will Deacon
2019-06-10 17:26 ` Qian Cai
2019-06-11 10:03 ` Mark Rutland
2019-06-11 12:41 ` Mike Rapoport
2019-06-11 12:46 ` Qian Cai
2019-06-12 6:57 ` Mike Rapoport
2019-06-12 18:35 ` Qian Cai
2019-06-11 13:02 ` Mark Rutland
2019-06-13 12:11 ` Mike Rapoport
2019-06-13 13:22 ` Qian Cai
2019-06-13 19:44 ` Mike Rapoport [this message]
2019-06-17 15:12 ` Mike Rapoport
2019-06-17 16:36 ` Will Deacon
2019-06-18 6:12 ` Mike Rapoport
2019-06-18 6:54 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190613194427.GC25164@rapoport-lnx \
--to=rppt@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=cai@lca.pw \
--cc=catalin.marinas@arm.com \
--cc=cgroups@vger.kernel.org \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mark.rutland@arm.com \
--cc=mhocko@kernel.org \
--cc=vdavydov.dev@gmail.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).