From: Rob Herring <robh@kernel.org>
To: Leonard Crestez <leonard.crestez@nxp.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Aisheng Dong <aisheng.dong@nxp.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Shawn Guo <shawnguo@kernel.org>, Angus Ainslie <angus@akkea.ca>,
Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
Mark Brown <broonie@kernel.org>, dl-linux-imx <linux-imx@nxp.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
Robin Gong <yibin.gong@nxp.com>, Lee Jones <lee.jones@linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 2/3] dt-bindings: mfd: Document short/long press duration for bd718x7
Date: Fri, 14 Jun 2019 10:42:23 -0600 [thread overview]
Message-ID: <20190614164222.GA30277@bogus> (raw)
In-Reply-To: <ec750ff0021c942b3c477e1cc7dc35f957600c96.1558471150.git.leonard.crestez@nxp.com>
On Tue, May 21, 2019 at 08:41:13PM +0000, Leonard Crestez wrote:
> These values can be overwritten at probe time.
>
> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
> Acked-By: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> ---
> .../devicetree/bindings/mfd/rohm,bd71837-pmic.txt | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.txt b/Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.txt
> index d5f68ac78d15..3649c1191432 100644
> --- a/Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.txt
> +++ b/Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.txt
> @@ -36,10 +36,18 @@ switched power state to SNVS. If reset is done via READY state the power
> outputs will be returned to HW control by OTP loading. Thus the reset
> target state is set to READY by default. If SNVS state is used the boot
> crucial regulators must have the regulator-always-on and regulator-boot-on
> properties set in regulator node.
>
> +- rohm,short-press-ms : Short press duration in milliseconds
> +- rohm,long-press-ms : Long press duration in milliseconds
> +
> +Configure the "short press" and "long press" timers for the power button.
> +Values are rounded to what hardware supports (500ms multiple for short and
> +1000ms multiple for long). If these properties are not present the existing
> +configuration (from bootloader or OTP) is not touched.
We already have a standard property 'power-off-time-sec' for at least
part of this assuming 'long' or 'short' causes a power off. 'long' and
'short' don't describe anything useful. The action should be described.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-14 16:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-21 20:41 [PATCH v2 0/3] mfd: bd718x7: Set button press duration via dt only Leonard Crestez
2019-05-21 20:41 ` [PATCH v2 1/3] mfd: bd718x7: Remove hardcoded config for button press duration Leonard Crestez
2019-06-03 12:51 ` Lee Jones
2019-05-21 20:41 ` [PATCH v2 2/3] dt-bindings: mfd: Document short/long press duration for bd718x7 Leonard Crestez
2019-06-03 12:51 ` Lee Jones
2019-06-14 16:42 ` Rob Herring [this message]
2019-05-21 20:41 ` [PATCH v2 3/3] mfd: bd718x7: Make power button press duration configurable Leonard Crestez
2019-06-03 12:51 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190614164222.GA30277@bogus \
--to=robh@kernel.org \
--cc=aisheng.dong@nxp.com \
--cc=angus@akkea.ca \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=lee.jones@linaro.org \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=mark.rutland@arm.com \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=shawnguo@kernel.org \
--cc=yibin.gong@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).