From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95DAEC31E4B for ; Fri, 14 Jun 2019 16:56:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 47D7B21841 for ; Fri, 14 Jun 2019 16:56:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="L71zEkzA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 47D7B21841 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=d/5fBmTyP7Rrvn1OP+Hby3AH1Bhvnq1+rCfjMPXSkuI=; b=L71zEkzAScXuxn GIA1yT5mc+2OuKABYwGOF8oXcfq5X2gR1AAfKVNrye7UgLwLaJDoA3g1zIHzb+DaMuQJGGc5TmAeW P3FPoR5kAu1ATnEv8Jn/nhtdGb4MfzrCo9bQQaNMk8g5T/tt+5CsGDrAC0ko4FHa1KPLLN/zkVeAN b9ASnG4Ub2nTS0h751R7Yq7IhJrmAcj1u4DFsD1S1uH2IhW5LHeDOnL1oXodnCH2ixdcop+egKSDi P0zLWZcg8rFXtFgB17OJvn5H9m3/am3fVpbrRogQda0zyRqrvUWDCa/h4Bkk2LmxZv0n/h3AEZQ/Z BT9vwR3e24auM0IHfGKw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hbpVO-0003P3-Cx; Fri, 14 Jun 2019 16:56:46 +0000 Received: from mail-qt1-f194.google.com ([209.85.160.194]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hbpUl-0002iy-4r; Fri, 14 Jun 2019 16:56:10 +0000 Received: by mail-qt1-f194.google.com with SMTP id j19so3213313qtr.12; Fri, 14 Jun 2019 09:56:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=BW1xnYGWg+aoTF/Yaq1jahB+G0s53KZIsKdfCRLCS5M=; b=diYd6e1v0+JA5jhAq/fkJbvafkectZCPWz99rQq+zv6JH3y3ULe5Fh6Dh7loVk5AKu PuAdGtcwF6OKGoCI+gEAEM4OBlfCpAWXsPJQ5OIJd7Hn4klSRGLWOpoWmEBqSD82gZes PMPlVJMwkHQ4WgV+4qj4oZCLMLB/5ziqSOD8t3b/mAmQry7Z4qGoFTZDTfsycSbVpRNK Z1MSVVWbv8ogoRfeKvzgBrgrKurlmeufvZ0155fU7eJR5J+hGN7JJuGyUhvZz2Uwmy8r A51dov1B1lj3f82zt1tHJ7kTlAqibDzOTkM0q8CIOf0H/g2bwra9XfKdnk92pPmQ01S/ GwHQ== X-Gm-Message-State: APjAAAWcSMNaB9f7OB0Y4sbu4WaFFyRRsZtxh+JQswZi+4l/46mMugHb UX6b1E902EeKGk5coPJrKw== X-Google-Smtp-Source: APXvYqwKw7gEikdDCeeVBg/sr7wzmaN+sPvOXjG11rUJ9NjiqHre30+rVmiZbgs/Z8FdHdOZJiRV0g== X-Received: by 2002:ac8:70d1:: with SMTP id g17mr37959971qtp.124.1560531365401; Fri, 14 Jun 2019 09:56:05 -0700 (PDT) Received: from localhost ([64.188.179.243]) by smtp.gmail.com with ESMTPSA id e63sm1697857qkd.57.2019.06.14.09.56.04 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 14 Jun 2019 09:56:04 -0700 (PDT) Date: Fri, 14 Jun 2019 10:56:03 -0600 From: Rob Herring To: Sakari Ailus Subject: Re: [PATCH 3/3] media: dt-bindings: media: i2c: Add bindings for ov02a10 Message-ID: <20190614165603.GA30462@bogus> References: <20190523102204.24112-1-dongchun.zhu@mediatek.com> <20190523102204.24112-4-dongchun.zhu@mediatek.com> <20190531161658.2y2amfngbhfbllj7@valkosipuli.retiisi.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190531161658.2y2amfngbhfbllj7@valkosipuli.retiisi.org.uk> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190614_095607_191788_BFB6810C X-CRM114-Status: GOOD ( 20.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, srv_heupstream@mediatek.com, menghui.lin@mediatek.com, shengnan.wang@mediatek.com, louis.kuo@mediatek.com, sj.huang@mediatek.com, linux-mediatek@lists.infradead.org, dongchun.zhu@mediatek.com, matthias.bgg@gmail.com, bingbu.cao@intel.com, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 31, 2019 at 07:16:58PM +0300, Sakari Ailus wrote: > Hi Dongchun, > > Thanks for the patch. > > On Thu, May 23, 2019 at 06:22:04PM +0800, dongchun.zhu@mediatek.com wrote: > > From: Dongchun Zhu > > > > Add device tree binding documentation for the OV02A10 CMOS image sensor. > > > > Signed-off-by: Dongchun Zhu > > --- > > .../devicetree/bindings/media/i2c/ov02a10.txt | 43 ++++++++++++++++++++++ > > 1 file changed, 43 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/media/i2c/ov02a10.txt > > > > diff --git a/Documentation/devicetree/bindings/media/i2c/ov02a10.txt b/Documentation/devicetree/bindings/media/i2c/ov02a10.txt > > new file mode 100644 > > index 0000000..fdc2904 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/i2c/ov02a10.txt > > @@ -0,0 +1,43 @@ > > +* Omnivision OV02A10 MIPI CSI-2 sensor > > + > > +Required Properties: > > +- compatible: shall be "ovti,ov02a10" > > +- clocks: reference to the xvclk input clock > > +- clock-names: shall be "xvclk" > > +- avdd-supply: Analog voltage supply, 2.8 volts > > +- dovdd-supply: Digital I/O voltage supply, 1.8 volts > > +- dvdd-supply: Digital core voltage supply, 1.8 volts > > +- reset-gpios: Low active reset gpio > > + > > +The device node shall contain one 'port' child node with an > > +'endpoint' subnode for its digital output video port, > > +in accordance with the video interface bindings defined in > > +Documentation/devicetree/bindings/media/video-interfaces.txt. > > +The endpoint optional property 'data-lanes' shall be "<1>". > > If the sensor only supports a single lane configuration (one lane), you can > omit that property altogether. Is that the only possible configuration for > the sensor? > > Please also wrap the text at 80 characters, not 65 or so. > > > + > > +Example: > > +&i2c4 { > > + sensor_sub: sensor_sub { > > camera-sensor@3d { > > > + compatible = "ovti,ov02a10"; > > + reg = <0x3d>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&camera_pins_cam1_mclk_on>; > > + > > + clocks = <&topckgen CLK_TOP_MUX_CAMTG2>, > > + <&topckgen CLK_TOP_UNIVP_192M_D8>; > > + clock-names = "xvclk", "freq_mux"; > > + > > + avdd-supply = <&mt6358_vcama1_reg>; > > + dvdd-supply = <&mt6358_vcn18_reg>; > > + dovdd-supply = <&mt6358_vcamio_reg>; > > + pwdn-gpios = <&pio 107 1>; > > + reset-gpios = <&pio 109 1>; > > + > > + port@0 { Also, drop the unit-address as there is no 'reg' property. Building your dts file will 'W=1' will tell you this. > > + ov02a10_core: endpoint { > > + remote-endpoint = <&ov02a10_0>; > > + data-lanes = <1>; > > + }; > > Tabs for indentation, please. > > > + }; > > + }; > > +}; > > -- > Kind regards, > > Sakari Ailus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel