From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 569CCC31E4D for ; Fri, 14 Jun 2019 20:36:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2D9A22184D for ; Fri, 14 Jun 2019 20:36:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="iXMix9Th"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="fr/TmeQB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2D9A22184D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:From:To: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wdEE+iU1UvL43pOycZrsKamAlykQ2/7dkxI/qOvxTbk=; b=iXMix9ThnACTKY 60Y3n8Wc2R6jz7cWmCldMcrMu1LIIZNCnL6C+VRJY6zpFEA7l3lptuL0XaPlGSTVTjraCe98Magcb UoG8Hnwo7Oy6ETPJ58hUt0b0tbIiU2PYTmcs5IJTBgh2vWAruvylhCx7AQgZ9kOsgI914XU2G7jgt Pc3gsej3GMp5WxIPsQ0OghsBmO1H3HnpV+MB5U9b2c0LsYTYQfbGGMs4TRMHS0tvA9jOh0QgG4kLw boDVScGHHOuN2Lca+DEQRtkbPBKS1dVSQvPz56k9IJq9HVRAfz/1g4ukBuDiUKzYVT5fYZmDZSvjP a2j6LU1LE2vSvzZFyl/w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hbsvm-0003N8-9a; Fri, 14 Jun 2019 20:36:14 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hbsvj-0003MT-6h; Fri, 14 Jun 2019 20:36:12 +0000 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 959DA217F9; Fri, 14 Jun 2019 20:36:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560544570; bh=RQFeY7ClB3qfZKUqanGUTFvCrvIQv9xp/N5O5ZqmrGM=; h=In-Reply-To:References:To:From:Subject:Cc:Date:From; b=fr/TmeQBEPKbLUgkDfSTEhkYS/y4YHrr57CLOtIcGW9sNuajAET5wxTQr07bnOLMh 7hE0zaI6D/yrtKuLXwSnBM8hQhS5xdVHThZ7fMOEmZ7C8C+zVH7d80njyK4SeX5nv0 p/a54K9i3XcPK0xQHnK47DZ6q/7T0QjynQ0+X/6Q= MIME-Version: 1.0 In-Reply-To: <13456600.FWPkgmLa5g@phil> References: <20190614165454.13743-1-heiko@sntech.de> <20190614174526.6F805217D6@mail.kernel.org> <19cea8f7c279ef6efb12d1ec0822767d@risingedge.co.za> <13456600.FWPkgmLa5g@phil> To: Heiko Stuebner , Justin Swartz From: Stephen Boyd Subject: Re: [PATCH 3/4] ARM: dts: rockchip: add display nodes for rk322x User-Agent: alot/0.8.1 Date: Fri, 14 Jun 2019 13:36:09 -0700 Message-Id: <20190614203610.959DA217F9@mail.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190614_133611_261246_6ADA0B51 X-CRM114-Status: GOOD ( 18.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-rockchip@lists.infradead.org, mturquette@baylibre.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Heiko Stuebner (2019-06-14 12:33:12) > Am Freitag, 14. Juni 2019, 20:32:35 CEST schrieb Justin Swartz: > > On 2019-06-14 19:45, Stephen Boyd wrote: > > >> diff --git a/arch/arm/boot/dts/rk322x.dtsi > > >> b/arch/arm/boot/dts/rk322x.dtsi > > >> index da102fff96a2..148f9b5157ea 100644 > > >> --- a/arch/arm/boot/dts/rk322x.dtsi > > >> +++ b/arch/arm/boot/dts/rk322x.dtsi > > >> @@ -143,6 +143,11 @@ > > >> #clock-cells = <0>; > > >> }; > > >> > > >> + display_subsystem: display-subsystem { > > >> + compatible = "rockchip,display-subsystem"; > > >> + ports = <&vop_out>; > > >> + }; > > >> + > > > > > > What is this? It doesn't have a reg property so it looks like a virtual > > > device. Why is it in DT? > > > > This is a virtual device. > > > > I assumed it would be acceptable to it find in a device tree due to > > binding documentation, > > "Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt, > > which states: > > > > > > The Rockchip DRM master device is a virtual device needed to list all > > vop devices or other display interface nodes that comprise the > > graphics subsystem. > > > > > > Without the "display_subsystem" device node, the HDMI PHY and > > rockchipdrmfb frame buffer device are not initialized. > > > > Perhaps I should have included this in my commit message? :) > > As Justin said, that is very much common as the root of the components > that make up the drm device and pretty much common in a lot of devicetrees > for the last 5 years and longer ;-) . > > Also gpio-keys also don't have a reg property ;-) . > Do you have a SoC node? If so, this virtual device should live in the root, away from the nodes that have reg properties and are thus in the SoC node. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel