From: Krzysztof Kozlowski <krzk@kernel.org>
To: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
Cc: Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
linux-samsung-soc@vger.kernel.org, Kukjin Kim <kgene@kernel.org>,
Simon Shields <simon@lineageos.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: exynos: add flash support to galaxy-s3 boards
Date: Sat, 15 Jun 2019 19:04:28 +0200 [thread overview]
Message-ID: <20190615170428.GA3447@kozik-lap> (raw)
In-Reply-To: <20190614155419.14260-1-GNUtoo@cyberdimension.org>
On Fri, Jun 14, 2019 at 05:54:19PM +0200, Denis 'GNUtoo' Carikli wrote:
> From: Simon Shields <simon@lineageos.org>
>
> The galaxy s3 boards use an aat1290 to control the flash LED.
> This patch adds the relevant device tree configuration to use it.
>
> Signed-off-by: Simon Shields <simon@lineageos.org>
> Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> [rebase]
> ---
> arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi | 32 +++++++++++++++++++++
> 1 file changed, 32 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi b/arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi
> index 30eee5942eff..375aeca09882 100644
> --- a/arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi
> +++ b/arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi
> @@ -15,6 +15,24 @@
> i2c10 = &i2c_cm36651;
> };
>
> + aat1290 {
> + compatible = "skyworks,aat1290";
> + flen-gpios = <&gpj1 1 GPIO_ACTIVE_HIGH>;
> + enset-gpios = <&gpj1 2 GPIO_ACTIVE_HIGH>;
> +
> + pinctrl-names = "default", "host", "isp";
> + pinctrl-0 = <&camera_flash_host>;
> + pinctrl-1 = <&camera_flash_host>;
> + pinctrl-2 = <&camera_flash_isp>;
> +
> + flash-led {
> + label = "flash";
> + led-max-microamp = <520833>;
> + flash-max-microamp = <1012500>;
> + flash-max-timeout-us = <1940000>;
> + };
> + };
> +
> lcd_vdd3_reg: voltage-regulator-6 {
> compatible = "regulator-fixed";
> regulator-name = "LCD_VDD_2.2V";
> @@ -131,6 +149,20 @@
> regulator-max-microvolt = <2800000>;
> };
>
> +&pinctrl_0 {
> + camera_flash_host: camera-flash-host {
> + samsung,pins = "gpj1-0";
> + samsung,pin-function = <1>;
> + samsung,pin-val = <0>;
Please use the pin macros from:
include/dt-bindings/pinctrl/samsung.h
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-15 17:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 15:54 [PATCH] ARM: dts: exynos: add flash support to galaxy-s3 boards Denis 'GNUtoo' Carikli
2019-06-14 16:03 ` Paul Kocialkowski
2019-06-15 17:04 ` Krzysztof Kozlowski [this message]
2019-06-18 0:17 ` [PATCH][v2] " Denis 'GNUtoo' Carikli
2019-06-19 17:19 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190615170428.GA3447@kozik-lap \
--to=krzk@kernel.org \
--cc=GNUtoo@cyberdimension.org \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=paul.kocialkowski@bootlin.com \
--cc=simon@lineageos.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).