From: "Paul E. McKenney" <paulmck@linux.ibm.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: linux@arm.linux.org.uk, dietmar.eggemann@arm.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH arm] Use common outgoing-CPU-notification code
Date: Mon, 17 Jun 2019 06:06:57 -0700 [thread overview]
Message-ID: <20190617130657.GL26519@linux.ibm.com> (raw)
In-Reply-To: <20190617115809.GA3767@lakrids.cambridge.arm.com>
On Mon, Jun 17, 2019 at 12:58:19PM +0100, Mark Rutland wrote:
> On Tue, Jun 11, 2019 at 12:24:10PM -0700, Paul E. McKenney wrote:
> > This commit removes the open-coded CPU-offline notification with new
> > common code. In particular, this change avoids calling scheduler code
> > using RCU from an offline CPU that RCU is ignoring. This is a minimal
> > change. A more intrusive change might invoke the cpu_check_up_prepare()
> > and cpu_set_state_online() functions at CPU-online time, which would
> > allow onlining throw an error if the CPU did not go offline properly.
> >
> > Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> > Cc: linux-arm-kernel@lists.infradead.org
> > Cc: Russell King <linux@arm.linux.org.uk>
> > Cc: Mark Rutland <mark.rutland@arm.com>
> > Tested-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
>
> FWIW:
>
> Acked-by: Mark Rutland <mark.rutland@arm.com>
>
> On the assumption that Russell is ok with this, I think this should be
> dropped into the ARM patch system [1].
>
> Paul, are you familiar with that, or would you prefer that someone else
> submits the patch there? I can do so if you'd like.
I never have used this system, so please do drop it in there! Let me
know when you have done so, and I will then drop it from -rcu.
Thanx, Paul
> Thanks,
> Mark.
>
> [1] https://www.armlinux.org.uk/developer/patches/info.php
>
> >
> > diff --git a/arch/arm/kernel/smp.c b/arch/arm/kernel/smp.c
> > index ebc53804d57b..8687d619260f 100644
> > --- a/arch/arm/kernel/smp.c
> > +++ b/arch/arm/kernel/smp.c
> > @@ -267,15 +267,13 @@ int __cpu_disable(void)
> > return 0;
> > }
> >
> > -static DECLARE_COMPLETION(cpu_died);
> > -
> > /*
> > * called on the thread which is asking for a CPU to be shutdown -
> > * waits until shutdown has completed, or it is timed out.
> > */
> > void __cpu_die(unsigned int cpu)
> > {
> > - if (!wait_for_completion_timeout(&cpu_died, msecs_to_jiffies(5000))) {
> > + if (!cpu_wait_death(cpu, 5)) {
> > pr_err("CPU%u: cpu didn't die\n", cpu);
> > return;
> > }
> > @@ -322,7 +320,7 @@ void arch_cpu_idle_dead(void)
> > * this returns, power and/or clocks can be removed at any point
> > * from this CPU and its cache by platform_cpu_kill().
> > */
> > - complete(&cpu_died);
> > + (void)cpu_report_death();
> >
> > /*
> > * Ensure that the cache lines associated with that completion are
> >
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-17 13:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 19:24 [PATCH arm] Use common outgoing-CPU-notification code Paul E. McKenney
2019-06-17 11:58 ` Mark Rutland
2019-06-17 13:06 ` Paul E. McKenney [this message]
2019-06-26 16:42 ` Mark Rutland
2019-06-26 17:49 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190617130657.GL26519@linux.ibm.com \
--to=paulmck@linux.ibm.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).