From: Nishanth Menon <nm@ti.com>
To: Tero Kristo <t-kristo@ti.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>, Roger Quadros <rogerq@ti.com>
Subject: Re: [PATCH] arm64: dts: ti: k3-am65: Add MSMC RAM ranges in interconnect node
Date: Mon, 17 Jun 2019 10:42:31 -0500 [thread overview]
Message-ID: <20190617154230.shycra7u74qwqdcf@kahuna> (raw)
In-Reply-To: <3c53679c-4246-43e1-e6d6-2e1c7db201d7@ti.com>
On 17:54-20190617, Tero Kristo wrote:
> On 30/05/2019 13:49, Nishanth Menon wrote:
> > On 16:13-20190529, Suman Anna wrote:
> > > From: Roger Quadros <rogerq@ti.com>
> > >
> > > Add the MSCM RAM address space to the ranges property of the cbass_main
> > > interconnect node so that the addresses can be translated properly.
> > >
> > > This fixes the probe failure in the sram driver for the MSMC RAM node.
> > >
> > > Signed-off-by: Roger Quadros <rogerq@ti.com>
> > > Signed-off-by: Suman Anna <s-anna@ti.com>
> > > ---
> > >
> > > The following error message is seen without this:
> > > [ 0.480261] sram interconnect@100000:sram@70000000: found no memory resource
> > > [ 0.487497] sram: probe of interconnect@100000:sram@70000000 failed with error -22
> > >
> > > regards
> > > Suman
> > >
> > > arch/arm64/boot/dts/ti/k3-am65.dtsi | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/ti/k3-am65.dtsi b/arch/arm64/boot/dts/ti/k3-am65.dtsi
> > > index 50f4be2047a9..68b3f954f1d1 100644
> > > --- a/arch/arm64/boot/dts/ti/k3-am65.dtsi
> > > +++ b/arch/arm64/boot/dts/ti/k3-am65.dtsi
> > > @@ -68,6 +68,7 @@
> > > <0x00 0x00900000 0x00 0x00900000 0x00 0x00012000>, /* serdes */
> > > <0x00 0x01000000 0x00 0x01000000 0x00 0x0af02400>, /* Most peripherals */
> > > <0x00 0x30800000 0x00 0x30800000 0x00 0x0bc00000>, /* MAIN NAVSS */
> > > + <0x00 0x70000000 0x00 0x70000000 0x00 0x00200000>, /* MSMC SRAM */
> > > /* MCUSS Range */
> > > <0x00 0x28380000 0x00 0x28380000 0x00 0x03880000>,
> > > <0x00 0x40200000 0x00 0x40200000 0x00 0x00900100>,
> > > --
> > > 2.21.0
> > >
> >
> > Arrgh.. Nice catch. Thanks. We should consider pulling this in as part
> > of early rc fixes please.
> >
> > Acked-by: Nishanth Menon <nm@ti.com>
>
> Hmm, what is the failure this causes, except the probe message? SRAM driver
> obviously won't work but is it used for anything at the moment anyways?
>
> I would rather queue this towards 5.3.
Yes, this should be good enough for 5.3
--
Regards,
Nishanth Menon
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-17 15:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 21:13 [PATCH] arm64: dts: ti: k3-am65: Add MSMC RAM ranges in interconnect node Suman Anna
2019-05-30 10:49 ` Nishanth Menon
2019-06-17 14:54 ` Tero Kristo
2019-06-17 15:42 ` Nishanth Menon [this message]
2019-06-17 15:53 ` Suman Anna
2019-06-17 19:42 ` Tero Kristo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190617154230.shycra7u74qwqdcf@kahuna \
--to=nm@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=rogerq@ti.com \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).