Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] soc: ti: fix irq-ti-sci link error
@ 2019-06-17 13:01 Arnd Bergmann
  2019-06-17 15:43 ` Nishanth Menon
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Arnd Bergmann @ 2019-06-17 13:01 UTC (permalink / raw)
  To: Santosh Shilimkar
  Cc: Nishanth Menon, Arnd Bergmann, Lokesh Vutla, linux-kernel,
	Marc Zyngier, Tony Lindgren, Olof Johansson, linux-arm-kernel

The irqchip driver depends on the SoC specific driver, but we want
to be able to compile-test it elsewhere:

WARNING: unmet direct dependencies detected for TI_SCI_INTA_MSI_DOMAIN
  Depends on [n]: SOC_TI [=n]
  Selected by [y]:
  - TI_SCI_INTA_IRQCHIP [=y] && TI_SCI_PROTOCOL [=y]

drivers/irqchip/irq-ti-sci-inta.o: In function `ti_sci_inta_irq_domain_probe':
irq-ti-sci-inta.c:(.text+0x204): undefined reference to `ti_sci_inta_msi_create_irq_domain'

Rearrange the Kconfig and Makefile so we build the soc driver whenever
its users are there, regardless of the SOC_TI option.

Fixes: 49b323157bf1 ("soc: ti: Add MSI domain bus support for Interrupt Aggregator")
Fixes: f011df6179bd ("irqchip/ti-sci-inta: Add msi domain support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/soc/Makefile   | 2 +-
 drivers/soc/ti/Kconfig | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/soc/Makefile b/drivers/soc/Makefile
index 524ecdc2a9bb..2ec355003524 100644
--- a/drivers/soc/Makefile
+++ b/drivers/soc/Makefile
@@ -22,7 +22,7 @@ obj-$(CONFIG_ARCH_ROCKCHIP)	+= rockchip/
 obj-$(CONFIG_SOC_SAMSUNG)	+= samsung/
 obj-y				+= sunxi/
 obj-$(CONFIG_ARCH_TEGRA)	+= tegra/
-obj-$(CONFIG_SOC_TI)		+= ti/
+obj-y				+= ti/
 obj-$(CONFIG_ARCH_U8500)	+= ux500/
 obj-$(CONFIG_PLAT_VERSATILE)	+= versatile/
 obj-y				+= xilinx/
diff --git a/drivers/soc/ti/Kconfig b/drivers/soc/ti/Kconfig
index ea0859f7b185..d7d50d48d05d 100644
--- a/drivers/soc/ti/Kconfig
+++ b/drivers/soc/ti/Kconfig
@@ -75,10 +75,10 @@ config TI_SCI_PM_DOMAINS
 	  called ti_sci_pm_domains. Note this is needed early in boot before
 	  rootfs may be available.
 
+endif # SOC_TI
+
 config TI_SCI_INTA_MSI_DOMAIN
 	bool
 	select GENERIC_MSI_IRQ_DOMAIN
 	help
 	  Driver to enable Interrupt Aggregator specific MSI Domain.
-
-endif # SOC_TI
-- 
2.20.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] soc: ti: fix irq-ti-sci link error
  2019-06-17 13:01 [PATCH] soc: ti: fix irq-ti-sci link error Arnd Bergmann
@ 2019-06-17 15:43 ` Nishanth Menon
  2019-07-01 10:46 ` Lokesh Vutla
  2019-07-01 17:36 ` santosh.shilimkar
  2 siblings, 0 replies; 6+ messages in thread
From: Nishanth Menon @ 2019-06-17 15:43 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Lokesh Vutla, linux-kernel, Marc Zyngier, Tony Lindgren,
	Santosh Shilimkar, Olof Johansson, linux-arm-kernel

On 15:01-20190617, Arnd Bergmann wrote:
> The irqchip driver depends on the SoC specific driver, but we want
> to be able to compile-test it elsewhere:
> 
> WARNING: unmet direct dependencies detected for TI_SCI_INTA_MSI_DOMAIN
>   Depends on [n]: SOC_TI [=n]
>   Selected by [y]:
>   - TI_SCI_INTA_IRQCHIP [=y] && TI_SCI_PROTOCOL [=y]
> 
> drivers/irqchip/irq-ti-sci-inta.o: In function `ti_sci_inta_irq_domain_probe':
> irq-ti-sci-inta.c:(.text+0x204): undefined reference to `ti_sci_inta_msi_create_irq_domain'
> 
> Rearrange the Kconfig and Makefile so we build the soc driver whenever
> its users are there, regardless of the SOC_TI option.
> 
> Fixes: 49b323157bf1 ("soc: ti: Add MSI domain bus support for Interrupt Aggregator")
> Fixes: f011df6179bd ("irqchip/ti-sci-inta: Add msi domain support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/soc/Makefile   | 2 +-
>  drivers/soc/ti/Kconfig | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/soc/Makefile b/drivers/soc/Makefile
> index 524ecdc2a9bb..2ec355003524 100644
> --- a/drivers/soc/Makefile
> +++ b/drivers/soc/Makefile
> @@ -22,7 +22,7 @@ obj-$(CONFIG_ARCH_ROCKCHIP)	+= rockchip/
>  obj-$(CONFIG_SOC_SAMSUNG)	+= samsung/
>  obj-y				+= sunxi/
>  obj-$(CONFIG_ARCH_TEGRA)	+= tegra/
> -obj-$(CONFIG_SOC_TI)		+= ti/
> +obj-y				+= ti/
>  obj-$(CONFIG_ARCH_U8500)	+= ux500/
>  obj-$(CONFIG_PLAT_VERSATILE)	+= versatile/
>  obj-y				+= xilinx/
> diff --git a/drivers/soc/ti/Kconfig b/drivers/soc/ti/Kconfig
> index ea0859f7b185..d7d50d48d05d 100644
> --- a/drivers/soc/ti/Kconfig
> +++ b/drivers/soc/ti/Kconfig
> @@ -75,10 +75,10 @@ config TI_SCI_PM_DOMAINS
>  	  called ti_sci_pm_domains. Note this is needed early in boot before
>  	  rootfs may be available.
>  
> +endif # SOC_TI
> +
>  config TI_SCI_INTA_MSI_DOMAIN
>  	bool
>  	select GENERIC_MSI_IRQ_DOMAIN
>  	help
>  	  Driver to enable Interrupt Aggregator specific MSI Domain.
> -
> -endif # SOC_TI
> -- 
> 2.20.0
> 

	Looks fine to me. Lokesh?

-- 
Regards,
Nishanth Menon

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] soc: ti: fix irq-ti-sci link error
  2019-06-17 13:01 [PATCH] soc: ti: fix irq-ti-sci link error Arnd Bergmann
  2019-06-17 15:43 ` Nishanth Menon
@ 2019-07-01 10:46 ` Lokesh Vutla
  2019-07-01 17:36 ` santosh.shilimkar
  2 siblings, 0 replies; 6+ messages in thread
From: Lokesh Vutla @ 2019-07-01 10:46 UTC (permalink / raw)
  To: Arnd Bergmann, Santosh Shilimkar
  Cc: Nishanth Menon, Marc Zyngier, linux-kernel, Tony Lindgren,
	Olof Johansson, linux-arm-kernel



On 17/06/19 6:31 PM, Arnd Bergmann wrote:
> The irqchip driver depends on the SoC specific driver, but we want
> to be able to compile-test it elsewhere:
> 
> WARNING: unmet direct dependencies detected for TI_SCI_INTA_MSI_DOMAIN
>   Depends on [n]: SOC_TI [=n]
>   Selected by [y]:
>   - TI_SCI_INTA_IRQCHIP [=y] && TI_SCI_PROTOCOL [=y]
> 
> drivers/irqchip/irq-ti-sci-inta.o: In function `ti_sci_inta_irq_domain_probe':
> irq-ti-sci-inta.c:(.text+0x204): undefined reference to `ti_sci_inta_msi_create_irq_domain'
> 
> Rearrange the Kconfig and Makefile so we build the soc driver whenever
> its users are there, regardless of the SOC_TI option.
> 
> Fixes: 49b323157bf1 ("soc: ti: Add MSI domain bus support for Interrupt Aggregator")
> Fixes: f011df6179bd ("irqchip/ti-sci-inta: Add msi domain support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Looks like this is a side effect of the patch  a6b112b04355b ("arm64: arch_k3:
Fix kconfig dependency warning"). $Patch looks good to me.

Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com>

Thanks and regards,
Lokesh

> ---
>  drivers/soc/Makefile   | 2 +-
>  drivers/soc/ti/Kconfig | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/soc/Makefile b/drivers/soc/Makefile
> index 524ecdc2a9bb..2ec355003524 100644
> --- a/drivers/soc/Makefile
> +++ b/drivers/soc/Makefile
> @@ -22,7 +22,7 @@ obj-$(CONFIG_ARCH_ROCKCHIP)	+= rockchip/
>  obj-$(CONFIG_SOC_SAMSUNG)	+= samsung/
>  obj-y				+= sunxi/
>  obj-$(CONFIG_ARCH_TEGRA)	+= tegra/
> -obj-$(CONFIG_SOC_TI)		+= ti/
> +obj-y				+= ti/
>  obj-$(CONFIG_ARCH_U8500)	+= ux500/
>  obj-$(CONFIG_PLAT_VERSATILE)	+= versatile/
>  obj-y				+= xilinx/
> diff --git a/drivers/soc/ti/Kconfig b/drivers/soc/ti/Kconfig
> index ea0859f7b185..d7d50d48d05d 100644
> --- a/drivers/soc/ti/Kconfig
> +++ b/drivers/soc/ti/Kconfig
> @@ -75,10 +75,10 @@ config TI_SCI_PM_DOMAINS
>  	  called ti_sci_pm_domains. Note this is needed early in boot before
>  	  rootfs may be available.
>  
> +endif # SOC_TI
> +
>  config TI_SCI_INTA_MSI_DOMAIN
>  	bool
>  	select GENERIC_MSI_IRQ_DOMAIN
>  	help
>  	  Driver to enable Interrupt Aggregator specific MSI Domain.
> -
> -endif # SOC_TI
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] soc: ti: fix irq-ti-sci link error
  2019-06-17 13:01 [PATCH] soc: ti: fix irq-ti-sci link error Arnd Bergmann
  2019-06-17 15:43 ` Nishanth Menon
  2019-07-01 10:46 ` Lokesh Vutla
@ 2019-07-01 17:36 ` santosh.shilimkar
  2019-07-01 22:24   ` Olof Johansson
  2 siblings, 1 reply; 6+ messages in thread
From: santosh.shilimkar @ 2019-07-01 17:36 UTC (permalink / raw)
  To: Arnd Bergmann, Santosh Shilimkar
  Cc: Nishanth Menon, Lokesh Vutla, linux-kernel, Marc Zyngier,
	Tony Lindgren, Olof Johansson, linux-arm-kernel

On 6/17/19 6:01 AM, Arnd Bergmann wrote:
> The irqchip driver depends on the SoC specific driver, but we want
> to be able to compile-test it elsewhere:
> 
> WARNING: unmet direct dependencies detected for TI_SCI_INTA_MSI_DOMAIN
>    Depends on [n]: SOC_TI [=n]
>    Selected by [y]:
>    - TI_SCI_INTA_IRQCHIP [=y] && TI_SCI_PROTOCOL [=y]
> 
> drivers/irqchip/irq-ti-sci-inta.o: In function `ti_sci_inta_irq_domain_probe':
> irq-ti-sci-inta.c:(.text+0x204): undefined reference to `ti_sci_inta_msi_create_irq_domain'
> 
> Rearrange the Kconfig and Makefile so we build the soc driver whenever
> its users are there, regardless of the SOC_TI option.
> 
> Fixes: 49b323157bf1 ("soc: ti: Add MSI domain bus support for Interrupt Aggregator")
> Fixes: f011df6179bd ("irqchip/ti-sci-inta: Add msi domain support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Thanks Arnd. Will you be able to add it to your fixes queue.

FWIW, Acked-by: Santosh Shilimkar <ssantosh@kernle.org>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] soc: ti: fix irq-ti-sci link error
  2019-07-01 17:36 ` santosh.shilimkar
@ 2019-07-01 22:24   ` Olof Johansson
  2019-07-02  1:30     ` santosh.shilimkar
  0 siblings, 1 reply; 6+ messages in thread
From: Olof Johansson @ 2019-07-01 22:24 UTC (permalink / raw)
  To: Santosh Shilimkar
  Cc: Nishanth Menon, Arnd Bergmann, Lokesh Vutla,
	Linux Kernel Mailing List, Marc Zyngier, Tony Lindgren,
	Santosh Shilimkar, Linux ARM Mailing List

On Mon, Jul 1, 2019 at 10:36 AM <santosh.shilimkar@oracle.com> wrote:
>
> On 6/17/19 6:01 AM, Arnd Bergmann wrote:
> > The irqchip driver depends on the SoC specific driver, but we want
> > to be able to compile-test it elsewhere:
> >
> > WARNING: unmet direct dependencies detected for TI_SCI_INTA_MSI_DOMAIN
> >    Depends on [n]: SOC_TI [=n]
> >    Selected by [y]:
> >    - TI_SCI_INTA_IRQCHIP [=y] && TI_SCI_PROTOCOL [=y]
> >
> > drivers/irqchip/irq-ti-sci-inta.o: In function `ti_sci_inta_irq_domain_probe':
> > irq-ti-sci-inta.c:(.text+0x204): undefined reference to `ti_sci_inta_msi_create_irq_domain'
> >
> > Rearrange the Kconfig and Makefile so we build the soc driver whenever
> > its users are there, regardless of the SOC_TI option.
> >
> > Fixes: 49b323157bf1 ("soc: ti: Add MSI domain bus support for Interrupt Aggregator")
> > Fixes: f011df6179bd ("irqchip/ti-sci-inta: Add msi domain support")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > ---
> Thanks Arnd. Will you be able to add it to your fixes queue.
>
> FWIW, Acked-by: Santosh Shilimkar <ssantosh@kernle.org>

Cc:ing to arm@kernel.org is the best way to make sure it surfaces.

Also, please do Acked-by on separate line so the tools catch it next
time (also, check for typos. :)

Applying to fixes.


-Olof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] soc: ti: fix irq-ti-sci link error
  2019-07-01 22:24   ` Olof Johansson
@ 2019-07-02  1:30     ` santosh.shilimkar
  0 siblings, 0 replies; 6+ messages in thread
From: santosh.shilimkar @ 2019-07-02  1:30 UTC (permalink / raw)
  To: Olof Johansson
  Cc: Nishanth Menon, Arnd Bergmann, Lokesh Vutla,
	Linux Kernel Mailing List, Marc Zyngier, Tony Lindgren,
	Santosh Shilimkar, Linux ARM Mailing List

On 7/1/19 3:24 PM, Olof Johansson wrote:
> On Mon, Jul 1, 2019 at 10:36 AM <santosh.shilimkar@oracle.com> wrote:
>>
>> On 6/17/19 6:01 AM, Arnd Bergmann wrote:
>>> The irqchip driver depends on the SoC specific driver, but we want
>>> to be able to compile-test it elsewhere:
>>>
>>> WARNING: unmet direct dependencies detected for TI_SCI_INTA_MSI_DOMAIN
>>>     Depends on [n]: SOC_TI [=n]
>>>     Selected by [y]:
>>>     - TI_SCI_INTA_IRQCHIP [=y] && TI_SCI_PROTOCOL [=y]
>>>
>>> drivers/irqchip/irq-ti-sci-inta.o: In function `ti_sci_inta_irq_domain_probe':
>>> irq-ti-sci-inta.c:(.text+0x204): undefined reference to `ti_sci_inta_msi_create_irq_domain'
>>>
>>> Rearrange the Kconfig and Makefile so we build the soc driver whenever
>>> its users are there, regardless of the SOC_TI option.
>>>
>>> Fixes: 49b323157bf1 ("soc: ti: Add MSI domain bus support for Interrupt Aggregator")
>>> Fixes: f011df6179bd ("irqchip/ti-sci-inta: Add msi domain support")
>>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>> ---
>> Thanks Arnd. Will you be able to add it to your fixes queue.
>>
>> FWIW, Acked-by: Santosh Shilimkar <ssantosh@kernle.org>
> 
> Cc:ing to arm@kernel.org is the best way to make sure it surfaces.
> 
> Also, please do Acked-by on separate line so the tools catch it next
Will do..

> time (also, check for typos. :)
> 
:- )

> Applying to fixes.
Thanks for picking it up.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, back to index

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-17 13:01 [PATCH] soc: ti: fix irq-ti-sci link error Arnd Bergmann
2019-06-17 15:43 ` Nishanth Menon
2019-07-01 10:46 ` Lokesh Vutla
2019-07-01 17:36 ` santosh.shilimkar
2019-07-01 22:24   ` Olof Johansson
2019-07-02  1:30     ` santosh.shilimkar

Linux-ARM-Kernel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/0 linux-arm-kernel/git/0.git
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/1 linux-arm-kernel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-kernel linux-arm-kernel/ https://lore.kernel.org/linux-arm-kernel \
		linux-arm-kernel@lists.infradead.org infradead-linux-arm-kernel@archiver.kernel.org
	public-inbox-index linux-arm-kernel


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-arm-kernel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox