From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56172C31E5B for ; Mon, 17 Jun 2019 16:16:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2B2A8208CB for ; Mon, 17 Jun 2019 16:16:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="njXvzNsO"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="ZoqSWmU/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2B2A8208CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IXmtvJSMZgYjrlQWoHZawMTRlnjoEGdLX9uG9mdVEGM=; b=njXvzNsOZkEGa3 vqtORv4vN3yZRf0WxtGgVz/sEUN+EqXOScaouRrcDb9pntF6IMUgFfTZex3KEfcM657PgEPjdzkMc DLiUsxxzoMdQ3B5TADIeTaFzPubNX8Dl89MnLqLiCi9/OjXaH9vNOcKKETmTYJ6+ElER8dTtf48sI ECsMfQ+a/onj/MZF/dPgMEV98HIR+tMY4/3o5Ja3Ckm2ltiVDbAPhR39QDEaw1mo+9L6BaElQM/S0 MCU2rotPdhNGPTf0durPPyI7QCjFRhs44PRKWR5Ycm0IuI5pixv/8/w05Z6iVZG/0WojNWuG+BRjG Zsmc+owdz/XEVzcXIUjA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hcuJ8-0005yc-Fs; Mon, 17 Jun 2019 16:16:34 +0000 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hcuJ4-0005xY-M1 for linux-arm-kernel@lists.infradead.org; Mon, 17 Jun 2019 16:16:32 +0000 Received: by mail-pf1-x444.google.com with SMTP id d126so5956930pfd.2 for ; Mon, 17 Jun 2019 09:16:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=zvibPhwENQ3qc2un3M/Q6u9vfA61QDqGf+AvuS+Jre0=; b=ZoqSWmU/lQLp0AxiYiOl4DnE8lGbhiLm4TaGaplykVD8NJT3wL2fFNQtVZ1rhnDefR BaZR79IvfuOD5CsEX5Gw7fbGTcYyajcJl9kBZ4M7KE9N1zgzsiE4tOPQV7Ij2cCHZ82h EeOCnc0aOXf5zaqOyTsOM7HB6gCUwOMLTttbg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=zvibPhwENQ3qc2un3M/Q6u9vfA61QDqGf+AvuS+Jre0=; b=kWRsGSuoypHHgN1f6b7LRgVOAEuWheTs7vK59zaEJKQ3Odb3Z83LW/cUpHYN/pruDj FTmCVhcZQFykDBxgS+S/1EUDxNJN4MKMSbUGc3lDO6Al0gGRD9dwi8LGgy93KO6SJAWg TypP/FacuGcWdqKskyPX2n5nqMvZXG6ymC4E/53EOlLxF9HlTejiMenuetM3elJfawoo V7yASaRLTSw/+jCidBhhTVWqP3s4cVRq2RnxIbo7ccNxusqNRSRwYUMG8CisE3U4pss2 TjhYIOtFAANarukVIhdHTRJWHGQjQagmoJd97ew4+1w2HD4Kh9Lsh1CZvuTGxYgBGoWV hqGg== X-Gm-Message-State: APjAAAUbm3d/Az2LfhqMZKHvSRZWNTc0y1R26fsrsi12HcpOPnBgMkII vujyzxl6gMu6HP1r1RDAZZ/OYw== X-Google-Smtp-Source: APXvYqw3rc3Tet3QBs9yulULj2UwlZKr/1RY50orF99rzSnjjv2kEBXdw1GPW8ggnZq5hpDRRJ/YNg== X-Received: by 2002:a17:90a:b908:: with SMTP id p8mr26903360pjr.94.1560788189915; Mon, 17 Jun 2019 09:16:29 -0700 (PDT) Received: from localhost ([2620:15c:202:1:75a:3f6e:21d:9374]) by smtp.gmail.com with ESMTPSA id d12sm12846713pfd.96.2019.06.17.09.16.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 17 Jun 2019 09:16:29 -0700 (PDT) Date: Mon, 17 Jun 2019 09:16:25 -0700 From: Matthias Kaehlcke To: Pavel Machek Subject: Re: [PATCH] Revert "ARM: dts: rockchip: set PWM delay backlight settings for Minnie" Message-ID: <20190617161625.GR137143@google.com> References: <20190614224533.169881-1-mka@chromium.org> <20190616154143.GA28583@atrey.karlin.mff.cuni.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190616154143.GA28583@atrey.karlin.mff.cuni.cz> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190617_091630_747217_74BC6B17 X-CRM114-Status: GOOD ( 16.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Heiko Stuebner , linux-kernel@vger.kernel.org, Douglas Anderson , linux-rockchip@lists.infradead.org, Rob Herring , Enric Balletbo i Serra , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Pavel, On Sun, Jun 16, 2019 at 05:41:43PM +0200, Pavel Machek wrote: > Hi! > > > This reverts commit 288ceb85b505c19abe1895df068dda5ed20cf482. > > > > According to the commit message the AUO B101EAN01 panel on minnie > > requires a PWM delay of 200 ms, however this is not what the > > datasheet says. The datasheet mentions a *max* delay of 200 ms > > for T2 ("delay from LCDVDD to black video generation") and T3 > > ("delay from LCDVDD to HPD high"), which aren't related to the > > PWM. The backlight power sequence does not specify min/max > > constraints for T15 (time from PWM on to BL enable) or T16 > > (time from BL disable to PWM off). > > > > Signed-off-by: Matthias Kaehlcke > > --- > > Enric, if you think I misinterpreted the datasheet please holler! > > Was this tested? I performed limited manually testing. minnie ships with the Chrome OS 3.14 downstream, which doesn't include this delay, to my knowledge there are no open display related bugs for minnie. One could argue that a the configuration without the delay was widely field tested > Does patch being reverted actually break anything? To my knowledge it doesn't really break anything, however there is a short user perceptible delay between switching on the LCD and switching on the backlight. It's not the end of the world, but if it's not actually needed better avoid it. > If so, cc stable? I guess this is an edge case, were you could go either way. I'm fine with respinning and cc-ing stable. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel