From: Shawn Guo <shawnguo@kernel.org>
To: Leo Li <leoyang.li@nxp.com>
Cc: Aisheng Dong <aisheng.dong@nxp.com>,
Grant Likely <grant.likely@arm.com>,
Madalin-cristian Bucur <madalin.bucur@nxp.com>,
"wsa@the-dreams.de" <wsa@the-dreams.de>,
lkml <linux-kernel@vger.kernel.org>,
Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] arm64: defconfig: Enable FSL_EDMA driver
Date: Tue, 18 Jun 2019 14:31:16 +0800 [thread overview]
Message-ID: <20190618063114.GA29468@dragon> (raw)
In-Reply-To: <VE1PR04MB6687EE0E22DA0697A0A7038F8FEF0@VE1PR04MB6687.eurprd04.prod.outlook.com>
On Thu, Jun 13, 2019 at 02:01:11PM +0000, Leo Li wrote:
>
>
> > -----Original Message-----
> > From: Shawn Guo <shawnguo@kernel.org>
> > Sent: Wednesday, June 12, 2019 7:45 PM
> > To: Leo Li <leoyang.li@nxp.com>
> > Cc: Madalin-cristian Bucur <madalin.bucur@nxp.com>; Rob Herring
> > <robh+dt@kernel.org>; Aisheng Dong <aisheng.dong@nxp.com>; Vinod Koul
> > <vkoul@kernel.org>; Grant Likely <grant.likely@arm.com>; moderated
> > list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE <linux-arm-
> > kernel@lists.infradead.org>; lkml <linux-kernel@vger.kernel.org>
> > Subject: Re: [PATCH] arm64: defconfig: Enable FSL_EDMA driver
> >
> > On Wed, Jun 12, 2019 at 03:01:29PM -0500, Li Yang wrote:
> > > On Thu, May 9, 2019 at 10:15 PM Shawn Guo <shawnguo@kernel.org>
> > wrote:
> > > >
> > > > On Mon, Apr 22, 2019 at 01:30:56PM -0500, Li Yang wrote:
> > > > > Enables the FSL EDMA driver by default. This also works around an
> > > > > issue that imx-i2c driver keeps deferring the probe because of the
> > > > > DMA is not ready. And currently the DMA engine framework can not
> > > > > correctly tell if the DMA channels will truly become available
> > > > > later (it will never be available if the DMA driver is not enabled).
> > > > >
> > > > > This will cause indefinite messages like below:
> > > > > [ 3.335829] imx-i2c 2180000.i2c: can't get pinctrl, bus recovery not
> > supported
> > > > > [ 3.344455] ina2xx 0-0040: power monitor ina220 (Rshunt = 1000
> > uOhm)
> > > > > [ 3.350917] lm90 0-004c: 0-004c supply vcc not found, using dummy
> > regulator
> > > > > [ 3.362089] imx-i2c 2180000.i2c: can't get pinctrl, bus recovery not
> > supported
> > > > > [ 3.370741] ina2xx 0-0040: power monitor ina220 (Rshunt = 1000
> > uOhm)
> > > > > [ 3.377205] lm90 0-004c: 0-004c supply vcc not found, using dummy
> > regulator
> > > > > [ 3.388455] imx-i2c 2180000.i2c: can't get pinctrl, bus recovery not
> > supported
> > > > > .....
> > > > >
> > > > > Signed-off-by: Li Yang <leoyang.li@nxp.com>
> > > >
> > > > Applied, thanks.
> > >
> > > Hi Shawn,
> > >
> > > Is it possible to move this patch to the -fix series so that it can
> > > reach the mainline earlier? It is having a boot failure in mainline
> > > for platforms using this device without this workaround.
> >
> > Why would I2C device deferring cause boot failure on a platform? I'm just
> > trying to understand severity of the problem.
>
> Currently the probe of imx-i2c will be retried immediately after it is deferred when the optional dependency on DMA driver is not met. This will cause an indefinite loop of probe-defer-probe and keep printing the message as shown in the commit message.
>
Indefinite loop of probe-defer-probe is not a boot failure to me. But I
will try to send it as fix, and see if arm-soc folk will take it.
Shawn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-06-18 6:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-22 18:30 [PATCH] arm64: defconfig: Enable FSL_EDMA driver Li Yang
2019-05-10 3:05 ` Shawn Guo
2019-06-12 20:01 ` Li Yang
2019-06-13 0:45 ` Shawn Guo
2019-06-13 14:01 ` Leo Li
2019-06-18 6:31 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190618063114.GA29468@dragon \
--to=shawnguo@kernel.org \
--cc=aisheng.dong@nxp.com \
--cc=grant.likely@arm.com \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=madalin.bucur@nxp.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).