From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01C02C31E5E for ; Tue, 18 Jun 2019 09:25:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CED6A2084B for ; Tue, 18 Jun 2019 09:25:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="iq19udvz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CED6A2084B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OsrZhcFsDB5U4FgLGOVRI6uq9qVjQ9gmapDs0nIiqUc=; b=iq19udvz4uUfJM wdMMf7Ww/YbFK8W5lO/dooiDEMFHH6BADiVkmntFwqNdogEyFFbl9J9JeKfnM7izjXZT5InnsBLjz bcxxmhStLn5KEfOtUXYXiA8LyLiu+Y4rR/6m4XypO9IRM9n0y8GgnXpCx7My88f11gRf7ztSRouz+ yKZj655G5Xw+g5qKkdQC786jYTS3aK8kZcZtUcmPW6M3E5GtLD2Zzo7rh3l4k/dzReZQCI3QKWGUl 7PDOq/A7qruMeATdbwl+ybx49/VZ8q5oj7NpRyBmwBZ7Qt+wMMZuyX4g39P+lV1R6Pd8jSrHVfDsw p68YDdhTGoVJK3vv9Q2w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hdANE-0004ft-8B; Tue, 18 Jun 2019 09:25:52 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hdANB-0004f8-Qd for linux-arm-kernel@lists.infradead.org; Tue, 18 Jun 2019 09:25:50 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0E4EC344; Tue, 18 Jun 2019 02:25:49 -0700 (PDT) Received: from fuggles.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E40263F246; Tue, 18 Jun 2019 02:25:47 -0700 (PDT) Date: Tue, 18 Jun 2019 10:25:40 +0100 From: Will Deacon To: Mike Rapoport Subject: Re: [PATCH] arm64/mm: don't initialize pgd_cache twice Message-ID: <20190618092540.GA30899@fuggles.cambridge.arm.com> References: <1560843149-13845-1-git-send-email-rppt@linux.ibm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1560843149-13845-1-git-send-email-rppt@linux.ibm.com> User-Agent: Mutt/1.11.1+86 (6f28e57d73f2) () X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190618_022549_910656_4E1B1DC4 X-CRM114-Status: GOOD ( 11.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Catalin Marinas , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Qian Cai , Andrew Morton , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 18, 2019 at 10:32:29AM +0300, Mike Rapoport wrote: > When PGD_SIZE != PAGE_SIZE, arm64 uses kmem_cache for allocation of PGD > memory. That cache was initialized twice: first through > pgtable_cache_init() alias and then as an override for weak > pgd_cache_init(). > > Remove the alias from pgtable_cache_init() and keep the only pgd_cache > initialization in pgd_cache_init(). > > Fixes: caa841360134 ("x86/mm: Initialize PGD cache during mm initialization") > Signed-off-by: Mike Rapoport > --- > arch/arm64/include/asm/pgtable.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Thanks, Mike. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel