From: Peter Zijlstra <peterz@infradead.org>
To: Valentin Schneider <valentin.schneider@arm.com>
Cc: linux-pm@vger.kernel.org, gregkh@linuxfoundation.org,
rafael@kernel.org, linux@armlinux.org.uk,
linux-kernel@vger.kernel.org, quentin.perret@arm.com,
mingo@redhat.com, viresh.kumar@linaro.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] sched/topology: remove unused sd param from arch_scale_cpu_capacity()
Date: Tue, 18 Jun 2019 11:34:53 +0200 [thread overview]
Message-ID: <20190618093453.GN3436@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <c8030f30-0899-070b-df3c-3839ec7e1909@arm.com>
On Mon, Jun 17, 2019 at 06:07:29PM +0100, Valentin Schneider wrote:
> Hi,
>
> On 17/06/2019 16:00, Vincent Guittot wrote:
> > struct sched_domain *sd parameter is not used anymore in
> > arch_scale_cpu_capacity() so we can remove it.
> >
>
> I think it can't hurt to give a bit of background. The *sd parameter used
> to be there for smt_gain, which got snipped out by:
>
> 765d0af19f5f ("sched/topology: Remove the ::smt_gain field from 'struct sched_domain'")
>
> I'd appreciate having that commit mentioned in the log.
>
> > Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
>
> Other than that, the changes look fine to me.
>
> Reviewed-by: Valentin Schneider <valentin.schneider@arm.com>
The commit log now reads:
---
The 'struct sched_domain *sd' argument to arch_scale_cpu_capacity() is
unused since commit:
765d0af19f5f ("sched/topology: Remove the ::smt_gain field from 'struct sched_domain'")
remove it.
---
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-18 9:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 15:00 [PATCH] sched/topology: remove unused sd param from arch_scale_cpu_capacity() Vincent Guittot
2019-06-17 17:07 ` Valentin Schneider
2019-06-18 9:34 ` Peter Zijlstra [this message]
2019-06-18 9:37 ` Valentin Schneider
2019-06-18 9:45 ` Vincent Guittot
2019-06-18 9:26 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190618093453.GN3436@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mingo@redhat.com \
--cc=quentin.perret@arm.com \
--cc=rafael@kernel.org \
--cc=valentin.schneider@arm.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).