From: Simon Horman <horms@verge.net.au>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Takeshi Kihara <takeshi.kihara.df@renesas.com>,
Yoshihiro Kaneko <ykaneko0929@gmail.com>,
Magnus Damm <magnus.damm@gmail.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 1/2] arm64: dts: renesas: r8a77990: Add cpg reset for LVDS Interface
Date: Tue, 18 Jun 2019 12:44:55 +0200 [thread overview]
Message-ID: <20190618104455.72jyrvwf2vut76hy@verge.net.au> (raw)
In-Reply-To: <CAMuHMdUu2T2+Ri_xEq+Nr1qD_Dm067TDkfxTDpduX4xia2FGDQ@mail.gmail.com>
On Mon, Jun 17, 2019 at 10:43:09AM +0200, Geert Uytterhoeven wrote:
> Hi Simon,
>
> On Mon, Jun 17, 2019 at 10:37 AM Simon Horman
> <horms+renesas@verge.net.au> wrote:
> > From: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> >
> > It is necessary to reset the LVDS Interface according to display on/off.
>
> This is not the LVDS interface.
> The LVDS interface has its own device node.
Thanks, how about a changelog more like this?
arm64: dts: renesas: r8a77990: Add cpg reset for DU
Add CPG reset properties to DU node of E3 (r8a77990) SoC.
According to Laurent Pinchart, R-Car Gen3 reset is handled at the group
level so specifying one reset entry per group is sufficient. For this
reason <&cpg 724> is not listed as a reset for "du.1" as was the case in an
earlier revision of this patch.
Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > Therefore, this patch adds CPG reset properties in DU device node
> > for the R8A77990 SoC.
> >
> > According to Laurent Pinchart, R-Car Gen3 reset is handled at the group
> > level so specifying one reset entry per group is sufficient. For this
> > reason <&cpg 724> is not listed as a reset for "du.1" as was the case in an
> > earlier revision of this patch.
> >
> > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> > Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > ---
> > v2 [Simon Horman]
> > - only add one reset entry per group
> >
> > v1 [Yoshihiro Kaneko]
> >
> > v0 [Takeshi Kihara]
> > ---
> > arch/arm64/boot/dts/renesas/r8a77990.dtsi | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> > index b4318661f35e..84d1f58e73e7 100644
> > --- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> > @@ -1766,6 +1766,8 @@
> > clocks = <&cpg CPG_MOD 724>,
> > <&cpg CPG_MOD 723>;
> > clock-names = "du.0", "du.1";
> > + resets = <&cpg 724>;
> > + reset-names = "du.0";
> > vsps = <&vspd0 0 &vspd1 0>;
> > status = "disabled";
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-18 10:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 8:37 [PATCH v2 0/2] arm64: dts: renesas: r8a7799[05]: Add cpg reset for LVDS Interface Simon Horman
2019-06-17 8:37 ` [PATCH v2 1/2] arm64: dts: renesas: r8a77990: " Simon Horman
2019-06-17 8:43 ` Geert Uytterhoeven
2019-06-18 10:44 ` Simon Horman [this message]
2019-06-18 11:19 ` Geert Uytterhoeven
2019-06-17 8:37 ` [PATCH v2 2/2] arm64: dts: renesas: r8a77995: " Simon Horman
2019-06-17 8:43 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190618104455.72jyrvwf2vut76hy@verge.net.au \
--to=horms@verge.net.au \
--cc=geert@linux-m68k.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=takeshi.kihara.df@renesas.com \
--cc=ykaneko0929@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).