From: Will Deacon <will.deacon@arm.com>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Jayachandran Chandrasekharan Nair <jnair@marvell.com>,
James Morse <james.morse@arm.com>,
linux-arm-kernel@lists.infradead.org,
Aaro Koskinen <aaro.koskinen@nokia.com>
Subject: Re: [PATCH v2 2/2] arm64: Implement panic_smp_self_stop()
Date: Tue, 18 Jun 2019 13:51:51 +0100 [thread overview]
Message-ID: <20190618125151.GE31041@fuggles.cambridge.arm.com> (raw)
In-Reply-To: <20190617203519.328-2-aaro.koskinen@iki.fi>
On Mon, Jun 17, 2019 at 11:35:19PM +0300, Aaro Koskinen wrote:
> From: Aaro Koskinen <aaro.koskinen@nokia.com>
>
> Currently arm64 uses the default implementation of panic_smp_self_stop()
> where the CPU runs in a cpu_relax() loop unable to receive IPIs anymore.
> As a result, when two CPUs panic() simultaneously we get "SMP: failed to
> stop secondary CPUs" warnings and extra delays before a reset, because
> smp_send_stop() still tries to stop the other paniced CPU.
>
> Provide an implementation of panic_smp_self_stop() that is identical to
> the IPI CPU stop handler, so that the online status of stopped CPUs gets
> properly updated.
>
> Signed-off-by: Aaro Koskinen <aaro.koskinen@nokia.com>
> ---
>
> v2: Update the commit log
> Rename ipi_cpu_stop() to local_cpu_stop() and make it void func
> Add a comment for panic_smp_self_stop()
>
> v1: https://patchwork.kernel.org/patch/10988103/
>
> arch/arm64/kernel/smp.c | 19 +++++++++++++------
> 1 file changed, 13 insertions(+), 6 deletions(-)
Acked-by: Will Deacon <will.deacon@arm.com>
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-18 12:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 20:35 [PATCH v2 1/2] arm64: Improve parking of stopped CPUs Aaro Koskinen
2019-06-17 20:35 ` [PATCH v2 2/2] arm64: Implement panic_smp_self_stop() Aaro Koskinen
2019-06-18 12:51 ` Will Deacon [this message]
2019-06-25 15:43 ` [PATCH v2 1/2] arm64: Improve parking of stopped CPUs Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190618125151.GE31041@fuggles.cambridge.arm.com \
--to=will.deacon@arm.com \
--cc=aaro.koskinen@iki.fi \
--cc=aaro.koskinen@nokia.com \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=jnair@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).