* [PATCH RESEND V2] soc: imx8: Use existing of_root directly
@ 2019-06-18 9:43 Anson.Huang
2019-06-18 13:27 ` Shawn Guo
0 siblings, 1 reply; 2+ messages in thread
From: Anson.Huang @ 2019-06-18 9:43 UTC (permalink / raw)
To: shawnguo, s.hauer, kernel, festevam, leonard.crestez, abel.vesa,
linux-arm-kernel, linux-kernel
Cc: Linux-imx
From: Anson Huang <Anson.Huang@nxp.com>
There is common of_root for reference, no need to find it
from DT again, use of_root directly to make driver simple.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
drivers/soc/imx/soc-imx8.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/soc/imx/soc-imx8.c b/drivers/soc/imx/soc-imx8.c
index ef2406f..34ab993 100644
--- a/drivers/soc/imx/soc-imx8.c
+++ b/drivers/soc/imx/soc-imx8.c
@@ -94,7 +94,6 @@ static int __init imx8_soc_init(void)
{
struct soc_device_attribute *soc_dev_attr;
struct soc_device *soc_dev;
- struct device_node *root;
const struct of_device_id *id;
u32 soc_rev = 0;
const struct imx8_soc_data *data;
@@ -106,12 +105,11 @@ static int __init imx8_soc_init(void)
soc_dev_attr->family = "Freescale i.MX";
- root = of_find_node_by_path("/");
- ret = of_property_read_string(root, "model", &soc_dev_attr->machine);
+ ret = of_property_read_string(of_root, "model", &soc_dev_attr->machine);
if (ret)
goto free_soc;
- id = of_match_node(imx8_soc_match, root);
+ id = of_match_node(imx8_soc_match, of_root);
if (!id) {
ret = -ENODEV;
goto free_soc;
@@ -136,8 +134,6 @@ static int __init imx8_soc_init(void)
goto free_rev;
}
- of_node_put(root);
-
return 0;
free_rev:
@@ -145,7 +141,6 @@ static int __init imx8_soc_init(void)
kfree(soc_dev_attr->revision);
free_soc:
kfree(soc_dev_attr);
- of_node_put(root);
return ret;
}
device_initcall(imx8_soc_init);
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH RESEND V2] soc: imx8: Use existing of_root directly
2019-06-18 9:43 [PATCH RESEND V2] soc: imx8: Use existing of_root directly Anson.Huang
@ 2019-06-18 13:27 ` Shawn Guo
0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2019-06-18 13:27 UTC (permalink / raw)
To: Anson.Huang
Cc: abel.vesa, s.hauer, linux-kernel, Linux-imx, kernel,
leonard.crestez, festevam, linux-arm-kernel
On Tue, Jun 18, 2019 at 05:43:38PM +0800, Anson.Huang@nxp.com wrote:
> From: Anson Huang <Anson.Huang@nxp.com>
>
> There is common of_root for reference, no need to find it
> from DT again, use of_root directly to make driver simple.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Applied, thanks.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-18 13:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-18 9:43 [PATCH RESEND V2] soc: imx8: Use existing of_root directly Anson.Huang
2019-06-18 13:27 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).