From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Shawn Guo <shawnguo@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org,
Ding Xiang <dingxiang@cmss.chinamobile.com>,
Olof Johansson <olof@lixom.net>,
jun.nie@linaro.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] Arm: zx: remove redundant dev_err message
Date: Tue, 18 Jun 2019 14:52:36 +0100 [thread overview]
Message-ID: <20190618135236.32qjlxfgt5rcety5@shell.armlinux.org.uk> (raw)
In-Reply-To: <20190618134634.GL1959@dragon>
On Tue, Jun 18, 2019 at 09:46:36PM +0800, Shawn Guo wrote:
> On Tue, Jun 18, 2019 at 03:39:01PM +0800, Ding Xiang wrote:
> > devm_ioremap_resource already contains error message, so remove
> > the redundant dev_err message
> >
> > Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>
>
> Acked-by: Shawn Guo <shawnguo@kernel.org>
>
> Arnd, Olof,
>
> Can you please apply it to arm-soc tree? Thanks.
>
> Shawn
>
> > ---
> > arch/arm/mach-zx/zx296702-pm-domain.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/arch/arm/mach-zx/zx296702-pm-domain.c b/arch/arm/mach-zx/zx296702-pm-domain.c
> > index 7a08bf9d..ac44ea8 100644
> > --- a/arch/arm/mach-zx/zx296702-pm-domain.c
> > +++ b/arch/arm/mach-zx/zx296702-pm-domain.c
> > @@ -169,10 +169,8 @@ static int zx296702_pd_probe(struct platform_device *pdev)
> > }
> >
> > pcubase = devm_ioremap_resource(&pdev->dev, res);
> > - if (IS_ERR(pcubase)) {
> > - dev_err(&pdev->dev, "ioremap fail.\n");
> > + if (IS_ERR(pcubase))
> > return -EIO;
Shouldn't the error return also get fixed?
> > - }
> >
> > for (i = 0; i < ARRAY_SIZE(zx296702_pm_domains); ++i)
> > pm_genpd_init(zx296702_pm_domains[i], NULL, false);
> > --
> > 1.9.1
> >
> >
> >
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-06-18 13:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 7:39 [PATCH] Arm: zx: remove redundant dev_err message Ding Xiang
2019-06-18 13:46 ` Shawn Guo
2019-06-18 13:52 ` Russell King - ARM Linux admin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190618135236.32qjlxfgt5rcety5@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=arnd@arndb.de \
--cc=dingxiang@cmss.chinamobile.com \
--cc=jun.nie@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).