From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85949C43613 for ; Thu, 20 Jun 2019 10:29:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 540D12082C for ; Thu, 20 Jun 2019 10:29:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JXjp+ggW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 540D12082C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PTm2tWWy+/Vg8rT+W23ov/uxFrcWo2B53UgfvWBQbws=; b=JXjp+ggWR+i/U8 Yc64YKkK9JGjP3YQGO8q18IqOIeo0U1FlDDhsKC08+DbtLcQvEA5+vgj99Yo5c7jk2KqBBfciw92e 4+iTdRbbaQv5p8/PzF/H4xKjJyFYu3kWg+xjPb8A/RJsieTdrJfEQzOA1ZjjHOwGnoGIZhmzEkgPY B9EddLSfT38NIcLB4w1gfMdI2p17EI/3az/kIaj/oqICRknATphXWvLvEgEHP3Jb6wnx+Cc0qYANn fAO3ZVS8m61rQug14qgJuvBN6jiJmabRlZ5k6cbeWtcXoxgmXiQ6bBavC+vMjdTso4QQ/4QO7pJ7s t8RDhjOtz5/9Sgm2SIFQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hduJf-0005hw-Mg; Thu, 20 Jun 2019 10:29:15 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hduJc-0005hd-Nh for linux-arm-kernel@lists.infradead.org; Thu, 20 Jun 2019 10:29:13 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0871D360; Thu, 20 Jun 2019 03:29:12 -0700 (PDT) Received: from localhost (unknown [10.37.6.20]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7D8913F718; Thu, 20 Jun 2019 03:29:11 -0700 (PDT) Date: Thu, 20 Jun 2019 11:29:09 +0100 From: Andrew Murray To: Suzuki K Poulose Subject: Re: [PATCH v1 4/5] coresight: etm4x: improve clarity of etm4_os_unlock comment Message-ID: <20190620102909.GC20984@e119886-lin.cambridge.arm.com> References: <20190618125433.9739-1-andrew.murray@arm.com> <20190618125433.9739-5-andrew.murray@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1+81 (426a6c1) (2018-08-26) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190620_032912_821597_1A07DB3F X-CRM114-Status: GOOD ( 15.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexander.shishkin@linux.intel.com, linux-arm-kernel@lists.infradead.org, mathieu.poirier@linaro.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 19, 2019 at 11:46:07AM +0100, Suzuki K Poulose wrote: > > > On 18/06/2019 13:54, Andrew Murray wrote: > > To improve clarity, let's update the comment for etm4_os_unlock > > to use the name of the register as per the ETM architecture > > specification. > > nit: It also "fixes" the comment. Writing any value doesn't unlock > the trace unit. It must be "0". > > > > > Signed-off-by: Andrew Murray > > --- > > drivers/hwtracing/coresight/coresight-etm4x.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/hwtracing/coresight/coresight-etm4x.c b/drivers/hwtracing/coresight/coresight-etm4x.c > > index 885c4f2c691c..bda90d4cd62b 100644 > > --- a/drivers/hwtracing/coresight/coresight-etm4x.c > > +++ b/drivers/hwtracing/coresight/coresight-etm4x.c > > @@ -47,7 +47,7 @@ static enum cpuhp_state hp_online; > > static void etm4_os_unlock(struct etmv4_drvdata *drvdata) > > { > > - /* Writing any value to ETMOSLAR unlocks the trace registers */ > > + /* Writing 0 to TRCOSLAR unlocks the trace registers */ > > writel_relaxed(0x0, drvdata->base + TRCOSLAR); > > drvdata->os_unlock = true; > > isb(); > > With the above : > > Reviewed-by: Suzuki K Poulose Thanks, I'll update the message. Andrew Murray _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel