linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/5] ARM: dts: mmp2: devicetree updates
@ 2019-06-20 15:07 Lubomir Rintel
  2019-06-20 15:07 ` [PATCH 1/5] ARM: dts: mmp2: trivial whitespace fix Lubomir Rintel
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Lubomir Rintel @ 2019-06-20 15:07 UTC (permalink / raw)
  To: Olof Johansson
  Cc: Mark Rutland, devicetree, Rob Herring, linux-kernel, linux-arm-kernel

Hi,

Here's a couple of updates for the MMP2 SoC devicetree files.
They're pretty much independent of each other, can be applied in any
order.

Lubo




_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/5] ARM: dts: mmp2: trivial whitespace fix
  2019-06-20 15:07 [PATCH 0/5] ARM: dts: mmp2: devicetree updates Lubomir Rintel
@ 2019-06-20 15:07 ` Lubomir Rintel
  2019-06-20 15:07 ` [PATCH 2/5] ARM: dts: mmp2: fix the SPI nodes Lubomir Rintel
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Lubomir Rintel @ 2019-06-20 15:07 UTC (permalink / raw)
  To: Olof Johansson
  Cc: Mark Rutland, devicetree, linux-kernel, Lubomir Rintel,
	Rob Herring, linux-arm-kernel

A missing space before a curly brace.

Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
---
 arch/arm/boot/dts/mmp2.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/mmp2.dtsi b/arch/arm/boot/dts/mmp2.dtsi
index b6f40743e07b..50b6c38b39cc 100644
--- a/arch/arm/boot/dts/mmp2.dtsi
+++ b/arch/arm/boot/dts/mmp2.dtsi
@@ -379,7 +379,7 @@
 			};
 		};
 
-		soc_clocks: clocks{
+		soc_clocks: clocks {
 			compatible = "marvell,mmp2-clock";
 			reg = <0xd4050000 0x1000>,
 			      <0xd4282800 0x400>,
-- 
2.21.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/5] ARM: dts: mmp2: fix the SPI nodes
  2019-06-20 15:07 [PATCH 0/5] ARM: dts: mmp2: devicetree updates Lubomir Rintel
  2019-06-20 15:07 ` [PATCH 1/5] ARM: dts: mmp2: trivial whitespace fix Lubomir Rintel
@ 2019-06-20 15:07 ` Lubomir Rintel
  2019-06-20 15:07 ` [PATCH 3/5] ARM: dts: mmp2: rename the USB PHY node Lubomir Rintel
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Lubomir Rintel @ 2019-06-20 15:07 UTC (permalink / raw)
  To: Olof Johansson
  Cc: Mark Rutland, devicetree, linux-kernel, Lubomir Rintel,
	Rob Herring, linux-arm-kernel

The SPI bus has a single address cell and not size cells.

Also, dtc thinks the SPI nodes are preferrably called "spi" and it is
right to think so.

Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
---
 arch/arm/boot/dts/mmp2.dtsi | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/mmp2.dtsi b/arch/arm/boot/dts/mmp2.dtsi
index 50b6c38b39cc..e64639ce57a9 100644
--- a/arch/arm/boot/dts/mmp2.dtsi
+++ b/arch/arm/boot/dts/mmp2.dtsi
@@ -346,35 +346,43 @@
 				status = "disabled";
 			};
 
-			ssp1: ssp@d4035000 {
+			ssp1: spi@d4035000 {
 				compatible = "marvell,mmp2-ssp";
 				reg = <0xd4035000 0x1000>;
 				clocks = <&soc_clocks MMP2_CLK_SSP0>;
 				interrupts = <0>;
+				#address-cells = <1>;
+				#size-cells = <0>;
 				status = "disabled";
 			};
 
-			ssp2: ssp@d4036000 {
+			ssp2: spi@d4036000 {
 				compatible = "marvell,mmp2-ssp";
 				reg = <0xd4036000 0x1000>;
 				clocks = <&soc_clocks MMP2_CLK_SSP1>;
 				interrupts = <1>;
+				#address-cells = <1>;
+				#size-cells = <0>;
 				status = "disabled";
 			};
 
-			ssp3: ssp@d4037000 {
+			ssp3: spi@d4037000 {
 				compatible = "marvell,mmp2-ssp";
 				reg = <0xd4037000 0x1000>;
 				clocks = <&soc_clocks MMP2_CLK_SSP2>;
 				interrupts = <20>;
+				#address-cells = <1>;
+				#size-cells = <0>;
 				status = "disabled";
 			};
 
-			ssp4: ssp@d4039000 {
+			ssp4: spi@d4039000 {
 				compatible = "marvell,mmp2-ssp";
 				reg = <0xd4039000 0x1000>;
 				clocks = <&soc_clocks MMP2_CLK_SSP3>;
 				interrupts = <21>;
+				#address-cells = <1>;
+				#size-cells = <0>;
 				status = "disabled";
 			};
 		};
-- 
2.21.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 3/5] ARM: dts: mmp2: rename the USB PHY node
  2019-06-20 15:07 [PATCH 0/5] ARM: dts: mmp2: devicetree updates Lubomir Rintel
  2019-06-20 15:07 ` [PATCH 1/5] ARM: dts: mmp2: trivial whitespace fix Lubomir Rintel
  2019-06-20 15:07 ` [PATCH 2/5] ARM: dts: mmp2: fix the SPI nodes Lubomir Rintel
@ 2019-06-20 15:07 ` Lubomir Rintel
  2019-06-20 15:07 ` [PATCH 4/5] ARM: dts: mmp2: add camera interfaces Lubomir Rintel
  2019-06-20 15:07 ` [PATCH 5/5] ARM: dts: mmp2: specify reg-shift for the UARTs Lubomir Rintel
  4 siblings, 0 replies; 6+ messages in thread
From: Lubomir Rintel @ 2019-06-20 15:07 UTC (permalink / raw)
  To: Olof Johansson
  Cc: Mark Rutland, devicetree, linux-kernel, Lubomir Rintel,
	Rob Herring, linux-arm-kernel

This device is not an OTG phy, it's a regular USB HS phy. Follow the
generic node name recommendation, and rename it to "usb-phy".

Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
---
 arch/arm/boot/dts/mmp2.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/mmp2.dtsi b/arch/arm/boot/dts/mmp2.dtsi
index e64639ce57a9..21432cb9143f 100644
--- a/arch/arm/boot/dts/mmp2.dtsi
+++ b/arch/arm/boot/dts/mmp2.dtsi
@@ -117,7 +117,7 @@
 				mrvl,intc-nr-irqs = <2>;
 			};
 
-			usb_otg_phy0: usb-otg-phy@d4207000 {
+			usb_phy0: usb-phy@d4207000 {
 				compatible = "marvell,mmp2-usb-phy";
 				reg = <0xd4207000 0x40>;
 				#phy-cells = <0>;
@@ -130,7 +130,7 @@
 				interrupts = <44>;
 				clocks = <&soc_clocks MMP2_CLK_USB>;
 				clock-names = "USBCLK";
-				phys = <&usb_otg_phy0>;
+				phys = <&usb_phy0>;
 				phy-names = "usb";
 				status = "disabled";
 			};
-- 
2.21.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 4/5] ARM: dts: mmp2: add camera interfaces
  2019-06-20 15:07 [PATCH 0/5] ARM: dts: mmp2: devicetree updates Lubomir Rintel
                   ` (2 preceding siblings ...)
  2019-06-20 15:07 ` [PATCH 3/5] ARM: dts: mmp2: rename the USB PHY node Lubomir Rintel
@ 2019-06-20 15:07 ` Lubomir Rintel
  2019-06-20 15:07 ` [PATCH 5/5] ARM: dts: mmp2: specify reg-shift for the UARTs Lubomir Rintel
  4 siblings, 0 replies; 6+ messages in thread
From: Lubomir Rintel @ 2019-06-20 15:07 UTC (permalink / raw)
  To: Olof Johansson
  Cc: Mark Rutland, devicetree, linux-kernel, Lubomir Rintel,
	Rob Herring, linux-arm-kernel

Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
---
 arch/arm/boot/dts/mmp2.dtsi | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/arch/arm/boot/dts/mmp2.dtsi b/arch/arm/boot/dts/mmp2.dtsi
index 21432cb9143f..68b547077323 100644
--- a/arch/arm/boot/dts/mmp2.dtsi
+++ b/arch/arm/boot/dts/mmp2.dtsi
@@ -170,6 +170,28 @@
 				interrupts = <54>;
 				status = "disabled";
 			};
+
+			camera0: camera@d420a000 {
+				compatible = "marvell,mmp2-ccic";
+				reg = <0xd420a000 0x800>;
+				interrupts = <42>;
+				clocks = <&soc_clocks MMP2_CLK_CCIC0>;
+				clock-names = "axi";
+				#clock-cells = <0>;
+				clock-output-names = "mclk";
+				status = "disabled";
+			};
+
+			camera1: camera@d420a800 {
+				compatible = "marvell,mmp2-ccic";
+				reg = <0xd420a800 0x800>;
+				interrupts = <30>;
+				clocks = <&soc_clocks MMP2_CLK_CCIC1>;
+				clock-names = "axi";
+				#clock-cells = <0>;
+				clock-output-names = "mclk";
+				status = "disabled";
+			};
 		};
 
 		apb@d4000000 {	/* APB */
-- 
2.21.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 5/5] ARM: dts: mmp2: specify reg-shift for the UARTs
  2019-06-20 15:07 [PATCH 0/5] ARM: dts: mmp2: devicetree updates Lubomir Rintel
                   ` (3 preceding siblings ...)
  2019-06-20 15:07 ` [PATCH 4/5] ARM: dts: mmp2: add camera interfaces Lubomir Rintel
@ 2019-06-20 15:07 ` Lubomir Rintel
  4 siblings, 0 replies; 6+ messages in thread
From: Lubomir Rintel @ 2019-06-20 15:07 UTC (permalink / raw)
  To: Olof Johansson
  Cc: Mark Rutland, devicetree, linux-kernel, Lubomir Rintel,
	Rob Herring, linux-arm-kernel

This makes the 8250_of driver happy. There are two more drivers in the
tree that bind to mrvl,mmp-uart compatibles: pxa and 8250_pxa and
neither of them requires the reg-shift property, assuming it's always 2.

Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>

---
 arch/arm/boot/dts/mmp2.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/mmp2.dtsi b/arch/arm/boot/dts/mmp2.dtsi
index 68b547077323..6a2f072c1d0a 100644
--- a/arch/arm/boot/dts/mmp2.dtsi
+++ b/arch/arm/boot/dts/mmp2.dtsi
@@ -214,6 +214,7 @@
 				interrupts = <27>;
 				clocks = <&soc_clocks MMP2_CLK_UART0>;
 				resets = <&soc_clocks MMP2_CLK_UART0>;
+				reg-shift = <2>;
 				status = "disabled";
 			};
 
@@ -223,6 +224,7 @@
 				interrupts = <28>;
 				clocks = <&soc_clocks MMP2_CLK_UART1>;
 				resets = <&soc_clocks MMP2_CLK_UART1>;
+				reg-shift = <2>;
 				status = "disabled";
 			};
 
@@ -232,6 +234,7 @@
 				interrupts = <24>;
 				clocks = <&soc_clocks MMP2_CLK_UART2>;
 				resets = <&soc_clocks MMP2_CLK_UART2>;
+				reg-shift = <2>;
 				status = "disabled";
 			};
 
@@ -241,6 +244,7 @@
 				interrupts = <46>;
 				clocks = <&soc_clocks MMP2_CLK_UART3>;
 				resets = <&soc_clocks MMP2_CLK_UART3>;
+				reg-shift = <2>;
 				status = "disabled";
 			};
 
-- 
2.21.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-06-20 15:09 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-20 15:07 [PATCH 0/5] ARM: dts: mmp2: devicetree updates Lubomir Rintel
2019-06-20 15:07 ` [PATCH 1/5] ARM: dts: mmp2: trivial whitespace fix Lubomir Rintel
2019-06-20 15:07 ` [PATCH 2/5] ARM: dts: mmp2: fix the SPI nodes Lubomir Rintel
2019-06-20 15:07 ` [PATCH 3/5] ARM: dts: mmp2: rename the USB PHY node Lubomir Rintel
2019-06-20 15:07 ` [PATCH 4/5] ARM: dts: mmp2: add camera interfaces Lubomir Rintel
2019-06-20 15:07 ` [PATCH 5/5] ARM: dts: mmp2: specify reg-shift for the UARTs Lubomir Rintel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).