From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65C9EC48BE1 for ; Thu, 20 Jun 2019 17:11:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3BA1A2085A for ; Thu, 20 Jun 2019 17:11:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="kXqf8ue3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3BA1A2085A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GGvIKE3tzfrAXCLTjJ48WPoFgXB6ICKclMhbCuX7RiM=; b=kXqf8ue3xp073h 4UMI1NBGSM1WloYd27z3HwGIXuSuYMUhD3exGBX9/PxTyrxe9GDkXms+PotSU13sVHDpDzS67ZZxS 8jQOtcMlDgRBiCSYFmyFeFhkuz4qCy2jfrpheBxlfFdQ6aWaOL1QPqorXCCvWS7/rmIGVWBvuQjfv l4fubsFaLvWITHbZNUn4MsE9Xbyi7N0LjRB/xJShvw6nfHXJWEvzkMfbOYozDqlgmSmLa9KJcSrrT dfVMi1tJWJkBuwaFPXY8zYWiieXC3bajmHrUkqGBaJxXtqJ4HufXtWb1aOn8iE/1BoJzNjKcw/5K/ H+p+TSJA42MPzfahKlAg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1he0ab-0003QJ-Hm; Thu, 20 Jun 2019 17:11:09 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1he0aZ-0003PK-0F for linux-arm-kernel@lists.infradead.org; Thu, 20 Jun 2019 17:11:08 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AEAEC2B; Thu, 20 Jun 2019 10:11:05 -0700 (PDT) Received: from e107155-lin (e107155-lin.cambridge.arm.com [10.1.196.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AB3393F246; Thu, 20 Jun 2019 10:11:04 -0700 (PDT) Date: Thu, 20 Jun 2019 18:11:02 +0100 From: Sudeep Holla To: Suzuki K Poulose Subject: Re: [PATCH v1 5/5] coresight: etm4x: save/restore state across CPU low power states Message-ID: <20190620171102.GF25273@e107155-lin> References: <15ef45d4-ee1a-3c45-878d-f08f0a84cfeb@arm.com> <20190619110749.GD1360@e107155-lin> <20190620114116.GE20984@e119886-lin.cambridge.arm.com> <20190620154154.GB25273@e107155-lin> <20190620163426.GC25273@e107155-lin> <20190620165427.GH20984@e119886-lin.cambridge.arm.com> <9adb65af-a898-462b-ecbc-af972d9331a6@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <9adb65af-a898-462b-ecbc-af972d9331a6@arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190620_101107_093162_632B2969 X-CRM114-Status: GOOD ( 13.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Al.Grant@arm.com, mathieu.poirier@linaro.org, alexander.shishkin@linux.intel.com, andrew.murray@arm.com, linux-arm-kernel@lists.infradead.org, mike.leach@linaro.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 20, 2019 at 06:00:48PM +0100, Suzuki K Poulose wrote: > > > On 20/06/2019 17:54, Andrew Murray wrote: > > On Thu, Jun 20, 2019 at 10:47:38AM -0600, Mathieu Poirier wrote: > > > On Thu, 20 Jun 2019 at 10:34, Sudeep Holla wrote: > > > > > > > > On Thu, Jun 20, 2019 at 10:14:04AM -0600, Mathieu Poirier wrote: > > > > > On Thu, 20 Jun 2019 at 09:41, Sudeep Holla wrote: > > ... > > > > Then all we have to do is make the ACPI/DT property that indicate the > > > method used to deal with tracer idling mandatory. That way people are > > > conscious of the choice they are making. To be backward compatible > > > with current systems we default to the TRCPDCR.PU method but print a > > > warning message, just like we do for obsolete DT bindings. > > > > I'll respin the series based on this approach. I'll also flip the > > 'disable_pm_save' module option to 'enable_pm_save' - thus allowing any > > one to use software save/restore if they wish. > > If you are going to add a firmware property, please get a consensus on the > name here, before respinning to avoid another churn :-). How about one of : > > "arm,coresight-etm-looses-state" > "arm,coresight-etm-needs-save-restore" > Just to be more clear, I am fine with just kernel command/module parameter approach and DT bindings may not be required. If at all it is decided to take DT approach, then you really don't need command/module parameter IMO. I will leave that to you and Mathieu, wanted to make sure I am not contributing to the confusion yet again. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel