From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Sekhar Nori <nsekhar@ti.com>, Kevin Hilman <khilman@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
David Lechner <david@lechnology.com>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v8 0/2] clocksource: davinci-timer: new driver
Date: Mon, 24 Jun 2019 11:50:54 +0200 [thread overview]
Message-ID: <20190624095056.21296-1-brgl@bgdev.pl> (raw)
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Now that we have an agreement on the driver and only minor issues are left
to fix, I'm dropping the RFC tag and continuing the numbering from before
RFCs.
This is the davinci clocksource driver but it with a sparse warning fixed
and with a small tweak to kzalloc() call.
RFC history:
v1 -> v2:
- changed the format of the copyright notice
- removed all mentiones of the periodic timer setting
- added caching of the TCR register value so that its updating doesn't
require a read
- split the timer configuration for clock events into the
set_state_oneshot() and set_state_shutdown() callbacks
v2 -> v3:
- tim34, if used, should run in periodic mode for clocksource, now fixed
- dropped all the configuration variables from struct davinci_clockevent
as clockevent always uses tim12
- dropped caching of the TCR register with the following reasoning: on
systems using tim34 for clocksource, the TCR register is only touched
by the clock driver and we know that we need to keep tim34 in periodic
mode; on da830 the RTOS running on the DSP may modify the TCR register
but we on the other hand never change its settings when only using tim12
- subsequently the whole routine for TCR updating was dropped
- dropped the shift variable from most places
- added separate routines for initializing clocksource for da830 and all
other systems
- sprinkled a bunch of comments all over the driver to explain things
that caused confusion before
Changes since last RFC:
- fixed the following sparse warning:
>> drivers/clocksource/timer-davinci.c:198:14: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected void [noderef] <asn:2> *base @@ got oderef] <asn:2> *base @@
>> drivers/clocksource/timer-davinci.c:198:14: sparse: expected void [noderef] <asn:2> *base
>> drivers/clocksource/timer-davinci.c:198:14: sparse: got struct resource *
- added the __GFP_NOFAIL flag to kzalloc() call so that we don't get warnings
about not freeing the memory later
Bartosz Golaszewski (2):
clocksource: davinci-timer: add support for clockevents
clocksource: timer-davinci: add support for clocksource
drivers/clocksource/Kconfig | 5 +
drivers/clocksource/Makefile | 1 +
drivers/clocksource/timer-davinci.c | 369 ++++++++++++++++++++++++++++
include/clocksource/timer-davinci.h | 44 ++++
4 files changed, 419 insertions(+)
create mode 100644 drivers/clocksource/timer-davinci.c
create mode 100644 include/clocksource/timer-davinci.h
--
2.21.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2019-06-24 9:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-24 9:50 Bartosz Golaszewski [this message]
2019-06-24 9:50 ` [PATCH v8 1/2] clocksource: davinci-timer: add support for clockevents Bartosz Golaszewski
2019-06-24 9:50 ` [PATCH v8 2/2] clocksource: timer-davinci: add support for clocksource Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190624095056.21296-1-brgl@bgdev.pl \
--to=brgl@bgdev.pl \
--cc=bgolaszewski@baylibre.com \
--cc=daniel.lezcano@linaro.org \
--cc=david@lechnology.com \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).