From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25E0FC48BE8 for ; Mon, 24 Jun 2019 12:32:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EF642213F2 for ; Mon, 24 Jun 2019 12:32:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hR+M0o7O"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="iLycqTq+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EF642213F2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/VQ3L7FshdhfOUXobD31YMa4z9Ud/Vy9RxWdVGf4IWU=; b=hR+M0o7OVhqVumQ9rnAOCu0vP KX0RQ0sPjB7dLjdn81xp/pf9E3mbz62AesnVVbS55K9qqKtjZBRiXMvRUEcrwQR9iiLSyhon1aVrU RHopOJGcAJqV5VQ1nqasouwhFDerd+BA8SysOAwFevgtOz35BLzrbBC6D59YG+Q+pt2xUbp0yBImv 2jDwUVr3216StnkCvtZc8VIOb/1fYYnBzD38Q8cVcQpiedMDx4+QCTCTbtqo6DgzFGpAh5sbCHwii RDum8s7PcLceM1QMesVniHJWumnx+br8RqbQzxM3B3AkSd/ebbCMSc4PbHFzC644clPWyH1l5Jc4g p6484CtkQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hfO8p-0005Nm-LH; Mon, 24 Jun 2019 12:32:11 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hfO8m-0005Mq-4o for linux-arm-kernel@lists.infradead.org; Mon, 24 Jun 2019 12:32:09 +0000 Received: from linux-8ccs (nat.nue.novell.com [195.135.221.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5F2E8205C9; Mon, 24 Jun 2019 12:32:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561379524; bh=a3K3DY7Vl1R9i4uY3YJgDprYWQNpO5K3lg8iFltccQg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iLycqTq+aNbxd3gjPjNE9eolP7uheTaiE+2YXket8RcX0W8qyre9yJudYBufPfpKm jUvfAJJrJXmZeGmgaflV39AQzCx0zIiY52gWJ3gnVpF8VcEWbtYqYnKXHsBz1END0/ P3jMzy4V3tkHZRmIVZqd5LCLKdT6/vx5oRoZkvgM= Date: Mon, 24 Jun 2019 14:32:00 +0200 From: Jessica Yu To: Matthias Schiffer Subject: Re: [PATCH modules v2 0/2] Fix handling of exit unwinding sections (on ARM) Message-ID: <20190624123200.GB22519@linux-8ccs> References: <20190607104912.6252-1-matthias.schiffer@ew.tq-group.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-OS: Linux linux-8ccs 5.1.0-rc1-lp150.12.28-default+ x86_64 User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190624_053208_210361_FCE0E03A X-CRM114-Status: GOOD ( 10.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-ia64@vger.kernel.org, Russell King , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org +++ Matthias Schiffer [21/06/19 14:35 +0200]: >On Fri, 2019-06-07 at 12:49 +0200, Matthias Schiffer wrote: >> For some time (050d18d1c651 "ARM: 8650/1: module: handle negative >> R_ARM_PREL31 addends correctly", v4.11+), building a kernel without >> CONFIG_MODULE_UNLOAD would lead to module loads failing on ARM >> systems with >> certain memory layouts, with messages like: >> >> imx_sdma: section 16 reloc 0 sym '': relocation 42 out of range >> (0x7f015260 -> 0xc0f5a5e8) >> >> (0x7f015260 is in the module load area, 0xc0f5a5e8 a regular vmalloc >> address; relocation 42 is R_ARM_PREL31) >> >> This is caused by relocatiosn in the .ARM.extab.exit.text and >> .ARM.exidx.exit.text sections referencing the .exit.text section. As >> the >> module loader will omit loading .exit.text without >> CONFIG_MODULE_UNLOAD, >> there will be relocations from loaded to unloaded sections; the >> resulting >> huge offsets trigger the sanity checks added in 050d18d1c651. >> >> IA64 might be affected by a similar issue - sections with names like >> .IA_64.unwind.exit.text and .IA_64.unwind_info.exit.text appear in >> the ld >> script - but I don't know much about that arch. >> >> Also, I'm not sure if this is stable-worthy - just enabling >> CONFIG_MODULE_UNLOAD should be a viable workaround on affected >> kernels. >> >> v2: Use __weak function as suggested by Jessica > >Hi Russell, > >this patch series is still waiting for your thoughts - in reponse to >v1, Jessica already offered to take it through her tree if you give >your Acked-by. > >Thanks, > >Matthias Hi Matthias, There doesn't seem to be any complaints and I think the patchset looks good, so I've taken it up the modules-next tree. Thanks! Jessica _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel