From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_ADSP_ALL, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E41BEC48BD5 for ; Tue, 25 Jun 2019 14:25:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B252A213F2 for ; Tue, 25 Jun 2019 14:25:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NjLM0C+m"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=amazon.com header.i=@amazon.com header.b="vWvL8mPE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B252A213F2 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=amazon.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RAOUBiqLdskNutg7FOK/DKlMubceY1P/cWmFOr/w5nM=; b=NjLM0C+mhIGWJ3 JbbmGnU9Z9M0GYs4+r27mkzhEF+MIJNSqg4bSBWsS3SxF1RUxjLgrY14baERnPyIzggOczmKDXn+F 4ij3mh4yVs7LjEG8VF+l7GJIlzIyczeVv9E3v3J9uAk8DyLfWa5GR3YKiGIXi7iM1a4/uamk0Nepr tFwbHUzKNkRFR9Ru/gKJRqM5qMNU8VMnCK054LsOQziMVX+lL+8WiVlT6og7yNP1n/W9VVl5zKWp/ RD0bjkiFd4besuOhpV0JQ/q6OaigV2Rbb/2k413EPdDgJjELdmrTmMYsdFTlvc8nfM4DqzM7nee0g PgD8gMqlOTPXVJzth7gA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hfmOP-0002QE-H8; Tue, 25 Jun 2019 14:25:53 +0000 Received: from smtp-fw-9102.amazon.com ([207.171.184.29]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hfmOM-0002Oi-Aj for linux-arm-kernel@lists.infradead.org; Tue, 25 Jun 2019 14:25:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1561472750; x=1593008750; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=rJ5/pLRo7ybKRgcaV0iXG1cimiHcyqQC8+ssvElQ0LQ=; b=vWvL8mPEwdrHJXED2f0vBfF9sidvTcsbBxSoe2cG57KO9EvGRsB8ygQy 6x6469gXqMvmAeicDRvBv+H6xJ7zj25bvcAfetPzlR0l9mPkSslVe7QsW 59NnKnsXwr+DvcIMki3SIdwaeXUqdVW8Qao9C3vmts2Z5NA6NMJ2diKLW o=; X-IronPort-AV: E=Sophos;i="5.62,416,1554768000"; d="scan'208";a="681980455" Received: from sea3-co-svc-lb6-vlan2.sea.amazon.com (HELO email-inbound-relay-1a-821c648d.us-east-1.amazon.com) ([10.47.22.34]) by smtp-border-fw-out-9102.sea19.amazon.com with ESMTP; 25 Jun 2019 14:25:33 +0000 Received: from EX13MTAUWC001.ant.amazon.com (iad55-ws-svc-p15-lb9-vlan3.iad.amazon.com [10.40.159.166]) by email-inbound-relay-1a-821c648d.us-east-1.amazon.com (Postfix) with ESMTPS id C0E55A036C; Tue, 25 Jun 2019 14:25:30 +0000 (UTC) Received: from EX13D02UWC002.ant.amazon.com (10.43.162.6) by EX13MTAUWC001.ant.amazon.com (10.43.162.135) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Tue, 25 Jun 2019 14:25:29 +0000 Received: from localhost (10.43.160.61) by EX13D02UWC002.ant.amazon.com (10.43.162.6) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Tue, 25 Jun 2019 14:25:28 +0000 Date: Tue, 25 Jun 2019 09:25:39 -0500 From: Patrick Williams To: Gregory CLEMENT Subject: Re: [PATCH 0/2] pinctl: armada-37xx: fix for pins 32+ Message-ID: <20190625142539.GA33175@8c859006a84e.ant.amazon.com> References: <20190618160105.26343-1-alpawi@amazon.com> <871rzhlr7w.fsf@FE-laptop> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <871rzhlr7w.fsf@FE-laptop> User-Agent: Mutt/1.12.1 (2019-06-15) X-Originating-IP: [10.43.160.61] X-ClientProxiedBy: EX13D02UWC003.ant.amazon.com (10.43.162.199) To EX13D02UWC002.ant.amazon.com (10.43.162.6) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190625_072550_456178_70B1680A X-CRM114-Status: GOOD ( 10.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Benjamin Herrenschmidt , Jason Cooper , Andrew Lunn , Linus Walleij , "linux-kernel@vger.kernel.org" , "open list:GPIO SUBSYSTEM" , Linux ARM , Sebastian Hesselbarth Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 25, 2019 at 03:38:59PM +0200, Gregory CLEMENT wrote: > First you can add my > Acked-by: Gregory CLEMENT Thanks for the review Gregory. > Then as the second patch is a fix, you should add the fix tag: "Fixes: > 5715092a458c ("pinctrl: armada-37xx: Add gpio support") " as well as the > 'CC: " tags. > > But your change in the first patch made this second patch more difficult > to backport. > ... > Maybe you could change the order of those 2 patches? Good points. Will do both. > Actually, when I wrote "_update_reg" I was thinking to the update of the > variable, whereas with a function named "_calculate_reg" I am expecting > having the result as a return of the function. Understand. I can see the ambiguity in both names. How about "_update_reg_offset"? > Thanks, > > Gregory > -- - Patrick _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel