From: Stephen Boyd <sboyd@kernel.org>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>,
Claudiu.Beznea@microchip.com
Cc: mturquette@baylibre.com, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, claudiu.beznea@gmail.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/7] clk: at91: sckc: improve error path
Date: Wed, 26 Jun 2019 11:53:59 -0700 [thread overview]
Message-ID: <20190626185359.D90C120B1F@mail.kernel.org> (raw)
In-Reply-To: <20190621093302.GJ23549@piout.net>
Quoting Alexandre Belloni (2019-06-21 02:33:02)
> On 20/06/2019 10:30:42+0000, Claudiu.Beznea@microchip.com wrote:
> > Hi,
> >
> > On 18.06.2019 12:55, Alexandre Belloni wrote:
> > > On 13/06/2019 15:37:06+0000, Claudiu.Beznea@microchip.com wrote:
> > >> From: Claudiu Beznea <claudiu.beznea@microchip.com>
> > >>
> > >> Hi,
> > >>
> > >> This series tries to improve error path for slow clock registrations
> > >> by adding functions to free resources and using them on failures.
> > >>
> > >
> > > Does the platform even boot when the slow clock is not available?
> > >
> > > The TCB clocksource would fail at:
> > >
> > > tc.slow_clk = of_clk_get_by_name(node->parent, "slow_clk");
> > > if (IS_ERR(tc.slow_clk))
> > > return PTR_ERR(tc.slow_clk);
> > >
> >
> > In case of using TC as clocksource, yes, the platform wouldn't boot if slow
> > clock is not available, because, anyway the TC needs it. PIT may work
> > without it (if slow clock is not used to drive the PIT).
> >
> > For sure there are other IPs (which may be or are driven by slow clock)
> > which may not work if slow clock is driven them.
> >
> > Anyway, please let me know if you feel this series has no meaning.
> >
>
> Well, I'm not sure it is worth it but at the same time, it is not adding
> many lines and you already developed it...
>
Is that a Reviewed-by or a Rejected-by tag?
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-26 18:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 15:37 [PATCH 0/7] clk: at91: sckc: improve error path Claudiu.Beznea
2019-06-13 15:37 ` [PATCH 1/7] clk: at91: sckc: add support to free slow oscillator Claudiu.Beznea
2019-06-13 15:37 ` [PATCH 2/7] clk: at91: sckc: add support to free slow rc oscillator Claudiu.Beznea
2019-06-13 15:37 ` [PATCH 3/7] clk: at91: sckc: add support to free slow clock osclillator Claudiu.Beznea
2019-06-13 15:37 ` [PATCH 4/7] clk: at91: sckc: improve error path for sam9x5 sck register Claudiu.Beznea
2019-06-13 15:37 ` [PATCH 5/7] clk: at91: sckc: remove unnecessary line Claudiu.Beznea
2019-06-13 15:37 ` [PATCH 6/7] clk: at91: sckc: improve error path for sama5d4 sck registration Claudiu.Beznea
2019-06-13 15:37 ` [PATCH 7/7] clk: at91: sckc: use dedicated functions to unregister clock Claudiu.Beznea
2019-06-18 9:55 ` [PATCH 0/7] clk: at91: sckc: improve error path Alexandre Belloni
2019-06-20 10:30 ` Claudiu.Beznea
2019-06-21 9:33 ` Alexandre Belloni
2019-06-26 18:53 ` Stephen Boyd [this message]
2019-06-26 19:00 ` Alexandre Belloni
2019-06-27 15:03 ` Stephen Boyd
2019-06-27 15:55 ` Claudiu.Beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190626185359.D90C120B1F@mail.kernel.org \
--to=sboyd@kernel.org \
--cc=Claudiu.Beznea@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).