From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CB6CC48BD6 for ; Wed, 26 Jun 2019 19:02:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E5498216C8 for ; Wed, 26 Jun 2019 19:02:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Z9WEDWkC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E5498216C8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QBGL6jq62dDv2gtppDjsxTkO91PGuwCh5jcWAZ34TjI=; b=Z9WEDWkCGHKrZU pxbZ0WdrryOmL87iyO3LkWRWeisQ/c3DAVZ9RcuY6ddFY6ndwGiuuPzyQ053bQSpOKiTvXMcrSYRT 2eCY9BswsYqckPzqeGxlDiS2Z3kUPlZ0nj5bWrXWNoxeT2b4XZHh17M33kJ2JmLhWZdfk9H1A5gX5 NtI7U+E7PUpKExKB1/M6UJLRAYmO9GcUPHXNVlpRJWXG0C5CTAA7+QuhzWJM+lB9Hl1O0GlWC5i0x EBK9B31mC+hcKGi3yYHTISm+p72lAqoXgY5+qBB4bZIA4wgpb11KFVY9d4e8h7rDPu/eNpTD2sOro dsny9da8GymKGVLi3b6w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hgDBJ-0007CB-E1; Wed, 26 Jun 2019 19:02:09 +0000 Received: from relay6-d.mail.gandi.net ([217.70.183.198]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hgDAR-0006aY-Ti for linux-arm-kernel@lists.infradead.org; Wed, 26 Jun 2019 19:01:18 +0000 X-Originating-IP: 90.65.161.137 Received: from localhost (lfbn-1-1545-137.w90-65.abo.wanadoo.fr [90.65.161.137]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 8E5E6C0006; Wed, 26 Jun 2019 19:00:53 +0000 (UTC) Date: Wed, 26 Jun 2019 21:00:53 +0200 From: Alexandre Belloni To: Stephen Boyd Subject: Re: [PATCH 0/7] clk: at91: sckc: improve error path Message-ID: <20190626190053.GA3692@piout.net> References: <1560440205-4604-1-git-send-email-claudiu.beznea@microchip.com> <20190618095521.GE23549@piout.net> <929ac20b-db1d-3f7a-b37c-0dfb253156d5@microchip.com> <20190621093302.GJ23549@piout.net> <20190626185359.D90C120B1F@mail.kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190626185359.D90C120B1F@mail.kernel.org> User-Agent: Mutt/1.12.0 (2019-05-25) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190626_120116_257050_12226DC6 X-CRM114-Status: GOOD ( 17.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mturquette@baylibre.com, linux-kernel@vger.kernel.org, Claudiu.Beznea@microchip.com, claudiu.beznea@gmail.com, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 26/06/2019 11:53:59-0700, Stephen Boyd wrote: > Quoting Alexandre Belloni (2019-06-21 02:33:02) > > On 20/06/2019 10:30:42+0000, Claudiu.Beznea@microchip.com wrote: > > > Hi, > > > > > > On 18.06.2019 12:55, Alexandre Belloni wrote: > > > > On 13/06/2019 15:37:06+0000, Claudiu.Beznea@microchip.com wrote: > > > >> From: Claudiu Beznea > > > >> > > > >> Hi, > > > >> > > > >> This series tries to improve error path for slow clock registrations > > > >> by adding functions to free resources and using them on failures. > > > >> > > > > > > > > Does the platform even boot when the slow clock is not available? > > > > > > > > The TCB clocksource would fail at: > > > > > > > > tc.slow_clk = of_clk_get_by_name(node->parent, "slow_clk"); > > > > if (IS_ERR(tc.slow_clk)) > > > > return PTR_ERR(tc.slow_clk); > > > > > > > > > > In case of using TC as clocksource, yes, the platform wouldn't boot if slow > > > clock is not available, because, anyway the TC needs it. PIT may work > > > without it (if slow clock is not used to drive the PIT). > > > > > > For sure there are other IPs (which may be or are driven by slow clock) > > > which may not work if slow clock is driven them. > > > > > > Anyway, please let me know if you feel this series has no meaning. > > > > > > > Well, I'm not sure it is worth it but at the same time, it is not adding > > many lines and you already developed it... > > > > Is that a Reviewed-by or a Rejected-by tag? > Reviewed-by: Alexandre Belloni -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel