From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C833C742D1 for ; Fri, 12 Jul 2019 16:21:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 21B3F2064B for ; Fri, 12 Jul 2019 16:21:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Xr+zTntN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 21B3F2064B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=++Ga4rHQYXkztjAzDigKKyAo0MLiCoF7bFR7KYFTDKY=; b=Xr+zTntNJUwjLQ D8UM6chqrQtkX/59LXzwQy7UdVl1ERkqxIqnUd2oVTKz0paapk6FjIU7c+XnwefErttVlVdh3o37z 9e8S0fLcczVkll5TsFDKsRQup4YbeNyCgnUORKo60pJwzHUsaIKDtCfGxbeY9B6m1zvLn3HeuyiRA soqVfa/guS48rzZyJ1BjS80pmFG/mILvZeV2c1ZuD8rvewLH090N6rekwvFAlSl5C05SVkTMfcmoB hg4EF2KRIwdCYQHRid54ZAICH1B1mczO5pYlhSzanosSUctGuaED5hADegcHWBndyhMXt+J6L8EIf fotxP2USyWHyS9xEUUlg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hlyIa-00085I-8a; Fri, 12 Jul 2019 16:21:28 +0000 Received: from asavdk4.altibox.net ([109.247.116.15]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hlyIW-00084K-Ch for linux-arm-kernel@lists.infradead.org; Fri, 12 Jul 2019 16:21:26 +0000 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id A5EC480335; Fri, 12 Jul 2019 18:21:18 +0200 (CEST) Date: Fri, 12 Jul 2019 18:21:17 +0200 From: Sam Ravnborg To: Nicolas.Ferre@microchip.com, Joshua Henderson Subject: Re: [PATCH] drm/atmel-hlcdc: set layer REP bit to enable replication logic Message-ID: <20190712162117.GB18990@ravnborg.org> References: <1562686509-8747-1-git-send-email-joshua.henderson@microchip.com> <13aa50e4-a726-3f82-b186-79b452199a02@microchip.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <13aa50e4-a726-3f82-b186-79b452199a02@microchip.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=VcLZwmh9 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=XYAwZIGsAAAA:8 a=VwQbUJbxAAAA:8 a=uoxZAW4_gHUsVfBorzEA:9 a=CjuIK1q_8ugA:10 a=E8ToXWR_bxluHZ7gmE-Z:22 a=AjGcO6oz07-iQ99wixmX:22 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190712_092124_609947_AB493FFD X-CRM114-Status: GOOD ( 18.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexandre.belloni@bootlin.com, bbrezillon@kernel.org, airlied@linux.ie, Joshua.Henderson@microchip.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Joshua. On Tue, Jul 09, 2019 at 04:24:49PM +0000, Nicolas.Ferre@microchip.com wrote: > On 09/07/2019 at 17:35, Joshua Henderson wrote: > > This bit enables replication logic to expand an RGB color less than 24 > > bits, to 24 bits, which is used internally for all formats. Otherwise, > > the least significant bits are always set to zero and the color may not > > be what is expected. > > > > Signed-off-by: Joshua Henderson > > Acked-by: Nicolas Ferre > > Here is patchwork entry: > https://patchwork.kernel.org/patch/11037167/ > > Thanks, best regards, > Nicolas > > > --- > > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c > > index eb7c4cf..6f6cf61 100644 > > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c > > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c > > @@ -389,7 +389,7 @@ atmel_hlcdc_plane_update_general_settings(struct atmel_hlcdc_plane *plane, > > atmel_hlcdc_layer_write_cfg(&plane->layer, ATMEL_HLCDC_LAYER_DMA_CFG, > > cfg); > > > > - cfg = ATMEL_HLCDC_LAYER_DMA; > > + cfg = ATMEL_HLCDC_LAYER_DMA | ATMEL_HLCDC_LAYER_REP; > > > > if (plane->base.type != DRM_PLANE_TYPE_PRIMARY) { > > cfg |= ATMEL_HLCDC_LAYER_OVR | ATMEL_HLCDC_LAYER_ITER2BL | Thanks - this gave me an opportunity to read a bit more in the datasheet of the controller. Applied to drm-misc-next with Ack from Nicolas. Sam _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel