From: Jonathan Cameron <jic23@kernel.org>
To: William Breathitt Gray <vilhelm.gray@gmail.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Benjamin Gaignard <benjamin.gaignard@st.com>,
linux-iio@vger.kernel.org,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Benjamin Gaignard <benjamin.gaignard@linaro.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Fabrice Gasnier <fabrice.gasnier@st.com>,
linux-stm32@st-md-mailman.stormreply.com,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Alexandre Torgue <alexandre.torgue@st.com>
Subject: Re: [PATCH] IIO: stm32: Remove quadrature related functions from trigger driver
Date: Sun, 14 Jul 2019 11:09:01 +0100 [thread overview]
Message-ID: <20190714110901.752643ae@archlinux> (raw)
In-Reply-To: <20190711121620.GA11661@icarus>
On Thu, 11 Jul 2019 21:16:20 +0900
William Breathitt Gray <vilhelm.gray@gmail.com> wrote:
> On Thu, Jul 11, 2019 at 02:12:27PM +0200, Benjamin Gaignard wrote:
> > Le jeu. 11 juil. 2019 à 13:51, William Breathitt Gray
> > <vilhelm.gray@gmail.com> a écrit :
> > >
> > > On Tue, May 07, 2019 at 11:12:24AM +0200, Benjamin Gaignard wrote:
> > > > Quadrature feature is now hosted on it own framework.
> > > > Remove quadrature related code from stm32-trigger driver to avoid
> > > > code duplication and simplify the ABI.
> > > >
> > > > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
> > >
> > > What is the status of this patch? Are there any objections currently for
> > > its inclusion?
> >
> > You were the only one asking for more details about it :-)
> > If you agree I think that Jonathan can merge it.
> >
> > Benjamin
> > >
> > > William Breathitt Gray
> > >
> > > _______________________________________________
> > > linux-arm-kernel mailing list
> > > linux-arm-kernel@lists.infradead.org
> > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
> Yes, Jonathan please merge this if you have no objections, I hadn't
> realized I was delaying it.
>
> Thank you,
>
> William Breathitt Gray
One last thing... This seems to be a userspace ABI change. What
are our potential issues with users of this ABI?
It's not that costly to keep the code, though dropping the docs or
putting a depreciated note in them is probably a good idea. Hence
I'm not totally convinced the risk of a regression is worth it.
If we think it's the sort of change no one will notice, then
fair enough we'll give it a go and cross our fingers.
Thanks,
Jonathan
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-07-14 10:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-07 9:12 [PATCH] IIO: stm32: Remove quadrature related functions from trigger driver Benjamin Gaignard
2019-05-07 10:18 ` William Breathitt Gray
2019-05-07 12:37 ` Benjamin Gaignard
2019-05-08 7:34 ` William Breathitt Gray
2019-05-09 7:40 ` Benjamin GAIGNARD
2019-07-11 11:50 ` William Breathitt Gray
2019-07-11 12:12 ` Benjamin Gaignard
2019-07-11 12:16 ` William Breathitt Gray
2019-07-14 10:09 ` Jonathan Cameron [this message]
2019-07-14 15:32 ` Benjamin GAIGNARD
2019-07-14 17:23 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190714110901.752643ae@archlinux \
--to=jic23@kernel.org \
--cc=alexandre.torgue@st.com \
--cc=benjamin.gaignard@linaro.org \
--cc=benjamin.gaignard@st.com \
--cc=fabrice.gasnier@st.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=pmeerw@pmeerw.net \
--cc=vilhelm.gray@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).