From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Mukesh Ojha <mojha@codeaurora.org>
Cc: s.hauer@pengutronix.de, linux-kernel@vger.kernel.org,
linux-imx@nxp.com, linux-input@vger.kernel.org,
shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/5] Input: sun4i-ts: Use devm_platform_ioremap_resource()
Date: Tue, 16 Jul 2019 09:34:25 +0200 [thread overview]
Message-ID: <20190716073425.GC1182@penguin> (raw)
In-Reply-To: <1554362243-2888-5-git-send-email-mojha@codeaurora.org>
On Thu, Apr 04, 2019 at 12:47:22PM +0530, Mukesh Ojha wrote:
> devm_platform_ioremap_resource() internally have platform_get_resource()
> and devm_ioremap_resource() in it. So instead of calling them separately
> use devm_platform_ioremap_resource() directly.
>
> Signed-off-by: Mukesh Ojha <mojha@codeaurora.org>
Applied, thank you.
> ---
> drivers/input/touchscreen/sun4i-ts.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/input/touchscreen/sun4i-ts.c b/drivers/input/touchscreen/sun4i-ts.c
> index d2e14d9..bbb0104 100644
> --- a/drivers/input/touchscreen/sun4i-ts.c
> +++ b/drivers/input/touchscreen/sun4i-ts.c
> @@ -309,8 +309,7 @@ static int sun4i_ts_probe(struct platform_device *pdev)
> input_set_drvdata(ts->input, ts);
> }
>
> - ts->base = devm_ioremap_resource(dev,
> - platform_get_resource(pdev, IORESOURCE_MEM, 0));
> + ts->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(ts->base))
> return PTR_ERR(ts->base);
>
> --
> Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center,
> Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
>
--
Dmitry
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-07-16 15:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-04 7:17 [PATCH 0/5] Input: Use devm_platform_ioremap_resource() Mukesh Ojha
2019-04-04 7:17 ` [PATCH 1/5] Input: fsl-imx25-tcq: " Mukesh Ojha
2019-07-16 7:30 ` Dmitry Torokhov
2019-04-04 7:17 ` [PATCH 2/5] Input: mxs-lradc-ts.c: " Mukesh Ojha
2019-07-16 7:32 ` Dmitry Torokhov
2019-04-04 7:17 ` [PATCH 3/5] Input: s3c2410_ts: " Mukesh Ojha
2019-07-16 7:39 ` Dmitry Torokhov
2019-04-04 7:17 ` [PATCH 4/5] Input: sun4i-ts: " Mukesh Ojha
2019-07-16 7:34 ` Dmitry Torokhov [this message]
2019-04-04 7:17 ` [PATCH 5/5] Input: ts4800-ts: " Mukesh Ojha
2019-07-16 7:34 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190716073425.GC1182@penguin \
--to=dmitry.torokhov@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mojha@codeaurora.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).