From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCEA1C7618F for ; Tue, 16 Jul 2019 14:47:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AE13E20880 for ; Tue, 16 Jul 2019 14:47:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LG4jwVWl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AE13E20880 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=flSy8uyB9C0akyfqNOCB4B9ULVFSU1txmgAEgHDC2Mk=; b=LG4jwVWl0HRCs2 Z7lN32VpXFx5mlvG57o3V5vgDA+kkEIdJ9moNGlN/nYQda4LFi2+wlel5AYrL98AGhtturmJfMIBJ yJSp3VassH65brcStP3YD3jRvJ9oEqybo4AqpRATP27RF4H1Tt1d2k5UhqEEd20NTOlCpCQTixsXD iZsMHKsAtbVOB4v9qrvzaUhHWYg1pbegoSxzvPhehxB+pqrm7MShnoviqcDjDDx+fMW2RCK7VOyGa XgVGfhzg24UDiXGpDPyszskxV9gS07oNtcxYY1bQ2gOrGT012v56UgptVbvXqGkjJv3hps9K2nOEH QAcs7IAX68DshGg61aNA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hnOkI-0007HN-2c; Tue, 16 Jul 2019 14:47:58 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hnOkA-0007Bu-E1 for linux-arm-kernel@lists.infradead.org; Tue, 16 Jul 2019 14:47:51 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 846E0344; Tue, 16 Jul 2019 07:47:49 -0700 (PDT) Received: from e107155-lin (e107155-lin.cambridge.arm.com [10.1.196.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B51AF3F59C; Tue, 16 Jul 2019 07:47:46 -0700 (PDT) Date: Tue, 16 Jul 2019 15:47:44 +0100 From: Sudeep Holla To: Ulf Hansson Subject: Re: [PATCH 18/18] arm64: dts: hikey: Convert to the hierarchical CPU topology layout Message-ID: <20190716144744.GB7250@e107155-lin> References: <20190513192300.653-1-ulf.hansson@linaro.org> <20190513192300.653-19-ulf.hansson@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190513192300.653-19-ulf.hansson@linaro.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190716_074750_556275_28390D8E X-CRM114-Status: GOOD ( 14.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Geert Uytterhoeven , Tony Lindgren , Viresh Kumar , Bjorn Andersson , Lina Iyer , Lorenzo Pieralisi , Kevin Hilman , Daniel Lezcano , Wei Xu , "Raju P . L . S . S . S . N" , Souvik Chakravarty , linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Stephen Boyd , "Rafael J . Wysocki" , linux-kernel@vger.kernel.org, Amit Kucheria , Sudeep Holla , Niklas Cassel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, May 13, 2019 at 09:23:00PM +0200, Ulf Hansson wrote: > To enable the OS to manage last-man standing activities for a CPU, while an > idle state for a group of CPUs is selected, let's convert the Hikey > platform into using the hierarchical CPU topology layout. > > Cc: Wei Xu > Signed-off-by: Ulf Hansson > --- > > Changes: > - None. > > --- > arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 87 ++++++++++++++++++++--- > 1 file changed, 76 insertions(+), 11 deletions(-) > > diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi > index 108e2a4227f6..36ff460f428f 100644 > --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi > +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi > cpus { [...] > @@ -70,9 +128,8 @@ > }; > > CLUSTER_SLEEP: cluster-sleep { > - compatible = "arm,idle-state"; > - local-timer-stop; > - arm,psci-suspend-param = <0x1010000>; > + compatible = "domain-idle-state"; > + arm,psci-suspend-param = <0x1000000>; > entry-latency-us = <1000>; > exit-latency-us = <700>; > min-residency-us = <2700>; Again this must be original format and as per PSCI spec, your patch changes this cluster sleep state into cluster retention state which I think is not what you intended. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel