From: Linus Walleij <linus.walleij@linaro.org>
To: Daniel Mack <daniel@zonque.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Robert Jarzmik <robert.jarzmik@free.fr>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: pxa3xx: Fix polarity on Raumfeld SPI CS
Date: Tue, 16 Jul 2019 23:35:20 +0200 [thread overview]
Message-ID: <20190716213520.31427-1-linus.walleij@linaro.org> (raw)
The SPI CS is active low and you probably will get a
warning in dmesg of the DT core enforcing it active low.
The reason it was set as GPIO_ACTIVE_HIGH in the old
board file was that the old spi-gpio driver would
invert the value and drive it low deliberately to
activate CS. The SPI and gpiolib core handling now
expects proper polarity to be used in the machine
descriptions.
Cc: Daniel Mack <daniel@zonque.org>
Cc: Robert Jarzmik <robert.jarzmik@free.fr>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
arch/arm/boot/dts/pxa300-raumfeld-common.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/pxa300-raumfeld-common.dtsi b/arch/arm/boot/dts/pxa300-raumfeld-common.dtsi
index 8ac24e3c8513..86568637e6d9 100644
--- a/arch/arm/boot/dts/pxa300-raumfeld-common.dtsi
+++ b/arch/arm/boot/dts/pxa300-raumfeld-common.dtsi
@@ -78,9 +78,9 @@
gpio-miso = <&gpio 98 GPIO_ACTIVE_HIGH>;
gpio-mosi = <&gpio 97 GPIO_ACTIVE_HIGH>;
cs-gpios = <
- &gpio 34 GPIO_ACTIVE_HIGH
- &gpio 125 GPIO_ACTIVE_HIGH
- &gpio 96 GPIO_ACTIVE_HIGH
+ &gpio 34 GPIO_ACTIVE_LOW
+ &gpio 125 GPIO_ACTIVE_LOW
+ &gpio 96 GPIO_ACTIVE_LOW
>;
num-chipselects = <3>;
--
2.21.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2019-07-16 21:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-16 21:35 Linus Walleij [this message]
2019-07-17 21:05 ` [PATCH] ARM: dts: pxa3xx: Fix polarity on Raumfeld SPI CS Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190716213520.31427-1-linus.walleij@linaro.org \
--to=linus.walleij@linaro.org \
--cc=daniel@zonque.org \
--cc=haojian.zhuang@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=robert.jarzmik@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).