* [PATCH] arm64: dts: imx8mq: fix SAI compatible
@ 2019-07-17 9:54 Lucas Stach
2019-07-23 7:33 ` Shawn Guo
2019-07-23 7:38 ` Shawn Guo
0 siblings, 2 replies; 4+ messages in thread
From: Lucas Stach @ 2019-07-17 9:54 UTC (permalink / raw)
To: Shawn Guo
Cc: devicetree, patchwork-lst, NXP Linux Team, kernel, Fabio Estevam,
linux-arm-kernel
The i.MX8M SAI block is not compatible with the i.MX6SX one, as the
register layout has changed due to two version registers being added
at the beginning of the address map. Remove the bogus compatible.
Fixes: 8c61538dc945 "arm64: dts: imx8mq: Add SAI2 node"
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
arch/arm64/boot/dts/freescale/imx8mq.dtsi | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
index 9326bd4150a3..0c533c66b340 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
@@ -718,8 +718,7 @@
sai2: sai@308b0000 {
#sound-dai-cells = <0>;
- compatible = "fsl,imx8mq-sai",
- "fsl,imx6sx-sai";
+ compatible = "fsl,imx8mq-sai";
reg = <0x308b0000 0x10000>;
interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clk IMX8MQ_CLK_SAI2_IPG>,
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: imx8mq: fix SAI compatible
2019-07-17 9:54 [PATCH] arm64: dts: imx8mq: fix SAI compatible Lucas Stach
@ 2019-07-23 7:33 ` Shawn Guo
2019-07-23 7:37 ` Daniel Baluta
2019-07-23 7:38 ` Shawn Guo
1 sibling, 1 reply; 4+ messages in thread
From: Shawn Guo @ 2019-07-23 7:33 UTC (permalink / raw)
To: Lucas Stach, Daniel Baluta
Cc: devicetree, patchwork-lst, NXP Linux Team, kernel, Fabio Estevam,
linux-arm-kernel
Add Daniel for comment.
On Wed, Jul 17, 2019 at 11:54:36AM +0200, Lucas Stach wrote:
> The i.MX8M SAI block is not compatible with the i.MX6SX one, as the
> register layout has changed due to two version registers being added
> at the beginning of the address map. Remove the bogus compatible.
>
> Fixes: 8c61538dc945 "arm64: dts: imx8mq: Add SAI2 node"
The format should be the following. I can fix it when applying though.
Fixes: 8c61538dc945 ("arm64: dts: imx8mq: Add SAI2 node")
Shawn
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> arch/arm64/boot/dts/freescale/imx8mq.dtsi | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index 9326bd4150a3..0c533c66b340 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -718,8 +718,7 @@
>
> sai2: sai@308b0000 {
> #sound-dai-cells = <0>;
> - compatible = "fsl,imx8mq-sai",
> - "fsl,imx6sx-sai";
> + compatible = "fsl,imx8mq-sai";
> reg = <0x308b0000 0x10000>;
> interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&clk IMX8MQ_CLK_SAI2_IPG>,
> --
> 2.20.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: imx8mq: fix SAI compatible
2019-07-23 7:33 ` Shawn Guo
@ 2019-07-23 7:37 ` Daniel Baluta
0 siblings, 0 replies; 4+ messages in thread
From: Daniel Baluta @ 2019-07-23 7:37 UTC (permalink / raw)
To: l.stach, shawnguo
Cc: devicetree, patchwork-lst, dl-linux-imx, kernel, festevam,
linux-arm-kernel
On Tue, 2019-07-23 at 15:33 +0800, Shawn Guo wrote:
> Add Daniel for comment.
>
> On Wed, Jul 17, 2019 at 11:54:36AM +0200, Lucas Stach wrote:
> > The i.MX8M SAI block is not compatible with the i.MX6SX one, as the
> > register layout has changed due to two version registers being
> > added
> > at the beginning of the address map. Remove the bogus compatible.
> >
> > Fixes: 8c61538dc945 "arm64: dts: imx8mq: Add SAI2 node"
>
> The format should be the following. I can fix it when applying
> though.
>
> Fixes: 8c61538dc945 ("arm64: dts: imx8mq: Add SAI2 node")
>
> Shawn
>
> > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: imx8mq: fix SAI compatible
2019-07-17 9:54 [PATCH] arm64: dts: imx8mq: fix SAI compatible Lucas Stach
2019-07-23 7:33 ` Shawn Guo
@ 2019-07-23 7:38 ` Shawn Guo
1 sibling, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2019-07-23 7:38 UTC (permalink / raw)
To: Lucas Stach
Cc: devicetree, patchwork-lst, NXP Linux Team, kernel, Fabio Estevam,
linux-arm-kernel
On Wed, Jul 17, 2019 at 11:54:36AM +0200, Lucas Stach wrote:
> The i.MX8M SAI block is not compatible with the i.MX6SX one, as the
> register layout has changed due to two version registers being added
> at the beginning of the address map. Remove the bogus compatible.
>
> Fixes: 8c61538dc945 "arm64: dts: imx8mq: Add SAI2 node"
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Applied, thanks.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-07-23 7:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-17 9:54 [PATCH] arm64: dts: imx8mq: fix SAI compatible Lucas Stach
2019-07-23 7:33 ` Shawn Guo
2019-07-23 7:37 ` Daniel Baluta
2019-07-23 7:38 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).