From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A833BC76186 for ; Wed, 17 Jul 2019 11:34:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7FB4720880 for ; Wed, 17 Jul 2019 11:34:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZAdAX+Tr"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="TBhilfsI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7FB4720880 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LcwrgkSBs2gF8W2Ps9Q7554YZQBKdsnu5/sefqHszQY=; b=ZAdAX+TrWkBLux B1feJZp4rk9LUEjYewcNngCrbctuA1pxBDEmAFYyaBj6Nw9S0HtJqTp33cXJNiR8ymiGwdLxTkD9O Nw48Epcdwa2ojSZ11vj77VbHrNZvUxbnCnOd2vBbcstn4VlkwWn0jEImnaAL5NqXOO9pVpDbOzac4 lLwvWiLcEJNV9GyNdog1jEEt1uQFuIpz0+F4gUyCRVNEBp1f+5OJZLQJILemamWxkI3Kk8sPfViW/ EKGlrpLJTl2FpYXluI7KxIlmDDs40nYPMhgJFWl3GdvIxbBqAjRTVaBC7ph4ruErbUP6nS4DL0vRu uzO+0IDvyux8EpfQUFzw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hniCx-0005Up-LI; Wed, 17 Jul 2019 11:34:51 +0000 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hniCu-0005UQ-Pi for linux-arm-kernel@lists.infradead.org; Wed, 17 Jul 2019 11:34:50 +0000 Received: by mail-pf1-x444.google.com with SMTP id m30so10709544pff.8 for ; Wed, 17 Jul 2019 04:34:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=VybKZeImIHubjnzPcwmeEfKFWD3hjXqElXoGcQgTBRI=; b=TBhilfsIShkSkmHuH/dxs5quoh8qNFlj4QmIqbxpyxGt4tPdN8/xUhio1X8RwM1lia lTTnourds/EI2gViDp4pfWkrjYrEua8TjmGtHCY79Ok22GOSkNHPm3f+/ca6d20vjD6R 1+RMv3RWlzbo4B8bQbPiQ2gzJZ6JJeLDW0p45pxJ8fA/utvijCBAFyZ8A1dl3aQdY6H3 DqG4pS0UZKGkXRpc8GWafpWiWAC5AddhJYglgP3uB7tnZv1GeeI6xTPrXrUFxmAuT1fd VSUbDNzQmUkgJrcbfEbBXJOX4RRigq5PeOMh+crmrkKEqquW5angConYhFfL7h7x09jo ghqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=VybKZeImIHubjnzPcwmeEfKFWD3hjXqElXoGcQgTBRI=; b=RM57PN3cWIQi1MD/xOgDrWrvEKhGFbIGv+lG+glIFyJfMCFzb5Ja/P++ieduLREpxp RI4Sm332PvgkqjTv3Govd99MqF5GzoUrCFMnThEBYimKSQcxTP/5hKt203yQjR7Ib48o t9XVbGZonyNaiho1VC6ktYUVBFxK9UIrMnEW+LDlwgkpyHwIEYF7UqEfPjYZ1YmxRJjw FcGFF5Q55Z3hpJ85rwekZO9tsOx1L1QCHOIbh37P2BJCUQkA0eya68U5rV4iExUHLn4W mWFCQMuJ3QsOfwDTOJzHnILZwjnihw8I70SQtnU5pUN+65XP6nruJOFsj2v1ePkWZjGo K27Q== X-Gm-Message-State: APjAAAXJOX1qM+oVBVP+HvUKK7SyXe72ZDD7WYUqWYqoBtNNRC0OPWaQ NvvF5edrpitk2+JNoieRVFYh X-Google-Smtp-Source: APXvYqwxlePPEEzjsJS2WkwqzXSHpwPjgQ4XIECgBuBrQ+spR4gE0yCXsA3+h9l97eY60D4vFG+rfw== X-Received: by 2002:a63:7d05:: with SMTP id y5mr40965860pgc.425.1563363287636; Wed, 17 Jul 2019 04:34:47 -0700 (PDT) Received: from Mani-XPS-13-9360 ([2405:204:7301:59e6:f493:40df:9c8a:5041]) by smtp.gmail.com with ESMTPSA id j13sm22395804pfh.13.2019.07.17.04.34.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 17 Jul 2019 04:34:46 -0700 (PDT) Date: Wed, 17 Jul 2019 17:04:35 +0530 From: Manivannan Sadhasivam To: Aisheng Dong Subject: Re: [PATCH 3/3] arm64: dts: freescale: Add support for i.MX8QXP AI_ML board Message-ID: <20190717113435.GA32330@Mani-XPS-13-9360> References: <20190717061039.9271-1-manivannan.sadhasivam@linaro.org> <20190717061039.9271-4-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190717_043448_853878_972B9329 X-CRM114-Status: GOOD ( 23.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , Kinjan Patel , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "linux-kernel@vger.kernel.org" , Darshak Patel , "robh+dt@kernel.org" , dl-linux-imx , "kernel@pengutronix.de" , "festevam@gmail.com" , "linux-arm-kernel@lists.infradead.org" , Prajose John Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Dong, On Wed, Jul 17, 2019 at 10:40:10AM +0000, Aisheng Dong wrote: > > From: Manivannan Sadhasivam > > Sent: Wednesday, July 17, 2019 2:11 PM > > > > Add support for i.MX8QXP AI_ML board from Einfochips. This board is one of > > the Consumer Edition boards of the 96Boards family based on i.MX8QXP SoC > > from NXP/Freescale. > > > > The initial support includes following peripherals which are tested and known > > to be working: > > > > 1. Debug serial via UART2 > > 2. uSD > > 3. WiFi > > 4. Ethernet > > > > Signed-off-by: Manivannan Sadhasivam > > The patch looks good to me. Only a few nitpicks below. > Otherwise, > Reviewed-by: Dong Aisheng > > Regards > Dong Aisheng > Thanks for the review! > > --- > > arch/arm64/boot/dts/freescale/Makefile | 1 + > > .../boot/dts/freescale/imx8qxp-ai_ml.dts | 249 ++++++++++++++++++ > > 2 files changed, 250 insertions(+) > > create mode 100644 arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dts > > > > diff --git a/arch/arm64/boot/dts/freescale/Makefile > > b/arch/arm64/boot/dts/freescale/Makefile > > index 0bd122f60549..bd8460549d1a 100644 > > --- a/arch/arm64/boot/dts/freescale/Makefile > > +++ b/arch/arm64/boot/dts/freescale/Makefile > > @@ -24,4 +24,5 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mq-evk.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mq-zii-ultra-rmb3.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mq-zii-ultra-zest.dtb > > +dtb-$(CONFIG_ARCH_MXC) += imx8qxp-ai_ml.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8qxp-mek.dtb diff --git > > a/arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dts > > b/arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dts > > new file mode 100644 > > index 000000000000..dcd36e57d916 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dts > > @@ -0,0 +1,249 @@ > > +// SPDX-License-Identifier: GPL-2.0+ > > +/* > > + * Copyright 2018 Einfochips > > + * Copyright 2019 Linaro Ltd. > > + */ > > + > > +/dts-v1/; > > + > > +#include "imx8qxp.dtsi" > > + > > +/ { > > + model = "Einfochips i.MX8QXP AI_ML"; > > + compatible = "einfochips,imx8qxp-ai_ml", "fsl,imx8qxp"; > > + > > + aliases { > > + serial1 = &adma_lpuart1; > > + serial2 = &adma_lpuart2; > > + serial3 = &adma_lpuart3; > > + }; > > + > > + chosen { > > + stdout-path = &adma_lpuart2; > > + }; > > + > > + memory@80000000 { > > + device_type = "memory"; > > + reg = <0x00000000 0x80000000 0 0x80000000>; > > + }; > > + > > + leds { > > + compatible = "gpio-leds"; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_leds>; > > + > > + user_led1 { > > + label = "green:user1"; > > + gpios = <&lsio_gpio4 16 GPIO_ACTIVE_HIGH>; > > + linux,default-trigger = "heartbeat"; > > + }; > > + > > + user_led2 { > > + label = "green:user2"; > > + gpios = <&lsio_gpio0 6 GPIO_ACTIVE_HIGH>; > > + linux,default-trigger = "none"; > > + }; > > + > > + user_led3 { > > + label = "green:user3"; > > + gpios = <&lsio_gpio0 7 GPIO_ACTIVE_HIGH>; > > + linux,default-trigger = "mmc1"; > > + default-state = "off"; > > + }; > > + > > + user_led4 { > > + label = "green:user4"; > > + gpios = <&lsio_gpio4 21 GPIO_ACTIVE_HIGH>; > > + panic-indicator; > > + linux,default-trigger = "none"; > > + }; > > + > > + wlan_active_led { > > + label = "yellow:wlan"; > > + gpios = <&lsio_gpio4 17 GPIO_ACTIVE_HIGH>; > > + linux,default-trigger = "phy0tx"; > > + default-state = "off"; > > + }; > > + > > + bt_active_led { > > + label = "blue:bt"; > > + gpios = <&lsio_gpio4 18 GPIO_ACTIVE_HIGH>; > > + linux,default-trigger = "hci0-power"; > > + default-state = "off"; > > + }; > > + }; > > + > > + sdio_pwrseq: sdio-pwrseq { > > + compatible = "mmc-pwrseq-simple"; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_wifi_reg_on>; > > + reset-gpios = <&lsio_gpio3 24 GPIO_ACTIVE_LOW>; > > + }; > > +}; > > + > > +/* BT */ > > +&adma_lpuart0 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_lpuart0>; > > + uart-has-rtscts; > > + status = "okay"; > > +}; > > + > > +/* LS-I2C0 */ > > Typo? > Ah, yes. It should be LS-UART0, will fix it. > > +&adma_lpuart1 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_lpuart1>; > > + status = "okay"; > > +}; > > + > > +/* Debug */ > > +&adma_lpuart2 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_lpuart2>; > > + status = "okay"; > > +}; > > + > > +/* PCI-E */ > > A bit confusing for the comments... > Hmm. How about, "PCI-E UART"? > > +&adma_lpuart3 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_lpuart3>; > > + status = "okay"; > > +}; > > + > > +&fec1 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_fec1>; > > + phy-mode = "rgmii-id"; > > + phy-handle = <ðphy0>; > > + fsl,magic-packet; > > + status = "okay"; > > + > > + mdio { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + ethphy0: ethernet-phy@0 { > > + compatible = "ethernet-phy-ieee802.3-c22"; > > + reg = <0>; > > + }; > > + }; > > +}; > > + > > +/* WiFi */ > > +&usdhc1 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_usdhc1>; > > + bus-width = <4>; > > + no-sd; > > + non-removable; > > + mmc-pwrseq = <&sdio_pwrseq>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > Nitpick: we usually put this two properties at the first place. > Okay. Thanks, Mani > > + status = "okay"; > > + > > + brcmf: wifi@1 { > > + reg = <1>; > > + compatible = "brcm,bcm4329-fmac"; > > + }; > > +}; > > + > > +/* SD */ > > +&usdhc2 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_usdhc2>; > > + bus-width = <4>; > > + cd-gpios = <&lsio_gpio4 22 GPIO_ACTIVE_LOW>; > > + status = "okay"; > > +}; > > + > > +&iomuxc { > > + pinctrl_fec1: fec1grp { > > + fsl,pins = < > > + IMX8QXP_ENET0_MDC_CONN_ENET0_MDC > > 0x06000020 > > + IMX8QXP_ENET0_MDIO_CONN_ENET0_MDIO > > 0x06000020 > > + IMX8QXP_ENET0_RGMII_TX_CTL_CONN_ENET0_RGMII_TX_CTL > > 0x06000020 > > + IMX8QXP_ENET0_RGMII_TXC_CONN_ENET0_RGMII_TXC > > 0x06000020 > > + IMX8QXP_ENET0_RGMII_TXD0_CONN_ENET0_RGMII_TXD0 > > 0x06000020 > > + IMX8QXP_ENET0_RGMII_TXD1_CONN_ENET0_RGMII_TXD1 > > 0x06000020 > > + IMX8QXP_ENET0_RGMII_TXD2_CONN_ENET0_RGMII_TXD2 > > 0x06000020 > > + IMX8QXP_ENET0_RGMII_TXD3_CONN_ENET0_RGMII_TXD3 > > 0x06000020 > > + IMX8QXP_ENET0_RGMII_RXC_CONN_ENET0_RGMII_RXC > > 0x06000020 > > + IMX8QXP_ENET0_RGMII_RX_CTL_CONN_ENET0_RGMII_RX_CTL > > 0x06000020 > > + IMX8QXP_ENET0_RGMII_RXD0_CONN_ENET0_RGMII_RXD0 > > 0x06000020 > > + IMX8QXP_ENET0_RGMII_RXD1_CONN_ENET0_RGMII_RXD1 > > 0x06000020 > > + IMX8QXP_ENET0_RGMII_RXD2_CONN_ENET0_RGMII_RXD2 > > 0x06000020 > > + IMX8QXP_ENET0_RGMII_RXD3_CONN_ENET0_RGMII_RXD3 > > 0x06000020 > > + >; > > + }; > > + > > + pinctrl_leds: ledsgrp{ > > + fsl,pins = < > > + IMX8QXP_ESAI0_TX2_RX3_LSIO_GPIO0_IO06 > > 0x00000021 > > + IMX8QXP_ESAI0_TX3_RX2_LSIO_GPIO0_IO07 > > 0x00000021 > > + IMX8QXP_EMMC0_DATA7_LSIO_GPIO4_IO16 > > 0x00000021 > > + IMX8QXP_USDHC1_WP_LSIO_GPIO4_IO21 > > 0x00000021 > > + IMX8QXP_EMMC0_STROBE_LSIO_GPIO4_IO17 > > 0x00000021 > > + IMX8QXP_EMMC0_RESET_B_LSIO_GPIO4_IO18 > > 0x00000021 > > + >; > > + }; > > + > > + pinctrl_lpuart0: lpuart0grp { > > + fsl,pins = < > > + IMX8QXP_UART0_RX_ADMA_UART0_RX > > 0X06000020 > > + IMX8QXP_UART0_TX_ADMA_UART0_TX > > 0X06000020 > > + IMX8QXP_FLEXCAN0_TX_ADMA_UART0_CTS_B > > 0x06000020 > > + IMX8QXP_FLEXCAN0_RX_ADMA_UART0_RTS_B > > 0x06000020 > > + >; > > + }; > > + > > + pinctrl_lpuart1: lpuart1grp { > > + fsl,pins = < > > + IMX8QXP_UART1_RX_ADMA_UART1_RX > > 0X06000020 > > + IMX8QXP_UART1_TX_ADMA_UART1_TX > > 0X06000020 > > + >; > > + }; > > + > > + pinctrl_lpuart2: lpuart2grp { > > + fsl,pins = < > > + IMX8QXP_UART2_RX_ADMA_UART2_RX > > 0X06000020 > > + IMX8QXP_UART2_TX_ADMA_UART2_TX > > 0X06000020 > > + >; > > + }; > > + > > + pinctrl_lpuart3: lpuart3grp { > > + fsl,pins = < > > + IMX8QXP_FLEXCAN2_RX_ADMA_UART3_RX > > 0X06000020 > > + IMX8QXP_FLEXCAN2_TX_ADMA_UART3_TX > > 0X06000020 > > + >; > > + }; > > + > > + pinctrl_usdhc1: usdhc1grp { > > + fsl,pins = < > > + IMX8QXP_EMMC0_CLK_CONN_EMMC0_CLK > > 0x06000041 > > + IMX8QXP_EMMC0_CMD_CONN_EMMC0_CMD > > 0x00000021 > > + IMX8QXP_EMMC0_DATA0_CONN_EMMC0_DATA0 > > 0x00000021 > > + IMX8QXP_EMMC0_DATA1_CONN_EMMC0_DATA1 > > 0x00000021 > > + IMX8QXP_EMMC0_DATA2_CONN_EMMC0_DATA2 > > 0x00000021 > > + IMX8QXP_EMMC0_DATA3_CONN_EMMC0_DATA3 > > 0x00000021 > > + >; > > + }; > > + > > + pinctrl_usdhc2: usdhc2grp { > > + fsl,pins = < > > + IMX8QXP_USDHC1_CLK_CONN_USDHC1_CLK > > 0x06000041 > > + IMX8QXP_USDHC1_CMD_CONN_USDHC1_CMD > > 0x00000021 > > + IMX8QXP_USDHC1_DATA0_CONN_USDHC1_DATA0 > > 0x00000021 > > + IMX8QXP_USDHC1_DATA1_CONN_USDHC1_DATA1 > > 0x00000021 > > + IMX8QXP_USDHC1_DATA2_CONN_USDHC1_DATA2 > > 0x00000021 > > + IMX8QXP_USDHC1_DATA3_CONN_USDHC1_DATA3 > > 0x00000021 > > + IMX8QXP_USDHC1_VSELECT_CONN_USDHC1_VSELECT > > 0x00000021 > > + IMX8QXP_USDHC1_CD_B_LSIO_GPIO4_IO22 > > 0x00000021 > > + >; > > + }; > > + > > + pinctrl_wifi_reg_on: wifiregongrp { > > + fsl,pins = < > > + IMX8QXP_QSPI0B_SS1_B_LSIO_GPIO3_IO24 > > 0x00000021 > > + >; > > + }; > > +}; > > -- > > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel