From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3855CC7618F for ; Thu, 18 Jul 2019 17:40:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 109F821019 for ; Thu, 18 Jul 2019 17:40:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ccP4gVN4"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=poorly.run header.i=@poorly.run header.b="biDTjzEv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 109F821019 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=poorly.run Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vH6+sTJm1cqV9J1bX1txCatsshaViDNDxg5Pq5ejF+0=; b=ccP4gVN44WMwYy 565Het7mCUzo5JxV3aQJQ3qnJd88Z88Dpgnn6kn4wUARlxgMaK3c28dOer/sPevjqZOUR5dA66rWM I2O67M5VYr1Txp+l7XC0wGw/iRqI3g7Fk9l4m4hHzht8aaUXNEt3uoSm1JRwcmZ6bgx9xWLnOKWTO lPohknEkIumca/11Crd6T3GoQLCh/pzfympvX8Z54zbwUO3E6HIIOCcagofP+OlaW20X087klQ6ut z8QC+cax/9o1ku5G4aYb6SBGhLVHZeJQCJr3ZrvUxi7Icbh3p0otX4b/hlVdHNfo3N37i4mEvwPEY zB3oSJKBJ3/GUpNkHOIA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hoAOR-0002BJ-G8; Thu, 18 Jul 2019 17:40:35 +0000 Received: from mail-yb1-xb41.google.com ([2607:f8b0:4864:20::b41]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hoAON-00029l-37 for linux-arm-kernel@lists.infradead.org; Thu, 18 Jul 2019 17:40:32 +0000 Received: by mail-yb1-xb41.google.com with SMTP id d9so5139105ybf.3 for ; Thu, 18 Jul 2019 10:40:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=poorly.run; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=l+1FrNNu6RWkcTjjfIpN7v4qd/Q00mT7mAH2ay5t5YU=; b=biDTjzEvV5Wul7i/WyioSr3VmyuNnxd9hl/aYBxur1J6Nlh9JqlFb0SX0jszQpCzin DtF2vZkl1jAodp5GPZ848x9Bg3S7l99tSQNiR3UV5iI3T2AM6Ul0Yyjaj+HPsNHPbmEM hREO5I59HNuv1/JufTZlHI6uBu2224l76gZmOrBIYJ7P/j/8KEC7avxJPToSiwztK6iZ uFxLAt9tqS2/OoBrpFWslIOMZuqddBHI08EbjSsRKFuxkNbxSBSHHlQP7VKmVxJawD3G ORstO1Z9eGe8pSFWVeYtmngaruHc+XHO7DkCHJ8Egb5EFBlOdPb1P0Ffx818IOJV/gS3 UiCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=l+1FrNNu6RWkcTjjfIpN7v4qd/Q00mT7mAH2ay5t5YU=; b=Tm3sNFBaSvTgki1pMznvRVStaeOgE+INisxap79NqNmU1naJkRomkZtewvbQ/5UrqX wC3KM/dYlZBb4qc1mSEte8mWgoMox9XJPDqJdc6S8SOoWp+YVJQf3AO4tAPZmop2O8VY YzePi49QaI63JVRS7856/mtvSsoCOXHX+RqGaJtg57PFCf9GLGfyB3x2Vz0AqmzLiJGf hTzyzHwuizbRMM3Vj47ndxXQIWI+zi0FboYqnXfsoAgMBFOI2DhUxCLyzS8GGgoLae2v 1T5qw6k8TZ5GhzkR3OFVfGyg8Fv0COynkG1QUg3dwOsw9O6O67I7AycIIV9XCPT+IpRG UE4A== X-Gm-Message-State: APjAAAWJ4+f/79AFKVysgbYSMZkTl30Kvqzjoe+VwxMySsTn0bzLNW0l duwPjtBPrer4BU1nAsC0d/ajig== X-Google-Smtp-Source: APXvYqxJ1zzhHTOV/V5q7YuSBr7QrcgmxKPpucgiwKedIA1Pi+QKm5M5Imn/NYHMNbUAMKQOdVF3Ww== X-Received: by 2002:a25:6346:: with SMTP id x67mr27596848ybb.346.1563471629832; Thu, 18 Jul 2019 10:40:29 -0700 (PDT) Received: from localhost ([2620:0:1013:11:89c6:2139:5435:371d]) by smtp.gmail.com with ESMTPSA id 131sm6583625ywq.21.2019.07.18.10.40.28 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 18 Jul 2019 10:40:29 -0700 (PDT) Date: Thu, 18 Jul 2019 13:40:28 -0400 From: Sean Paul To: Sam Ravnborg Subject: Re: [PATCH v1 02/11] drm: drop uapi dependency from drm_print.h Message-ID: <20190718174028.GE31819@art_vandelay> References: <20190718161507.2047-1-sam@ravnborg.org> <20190718161507.2047-3-sam@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190718161507.2047-3-sam@ravnborg.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190718_104031_133760_A0EC4455 X-CRM114-Status: GOOD ( 16.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Daniel Vetter , Liviu Dudau , dri-devel@lists.freedesktop.org, Chris Wilson , Eric Anholt , Rob Herring , Stefan Agner , Maxime Ripard , CK Hu , Thierry Reding , Daniel Vetter , Chunming Zhou , Jani Nikula , Intel Graphics Development , Maarten Lankhorst , linux-mediatek@lists.infradead.org, Lionel Landwerlin , Matthias Brugger , Sean Paul , linux-arm-kernel@lists.infradead.org, Boris Brezillon , Thomas Zimmermann , Rob Clark , Noralf =?iso-8859-1?Q?Tr=F8nnes?= , Philipp Zabel , Sean Paul , Christian =?iso-8859-1?Q?K=F6nig?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 18, 2019 at 06:14:58PM +0200, Sam Ravnborg wrote: > drm_print.h used DRM_NAME - thus adding a dependency from > include/drm/drm_print.h => uapi/drm/drm.h > > Hardcode the name "drm" to break this dependency. > The idea is that there shall be a minimal dependency > between include/drm/* and uapi/* You might also want to clean up the other uses of DRM_NAME in armada and i915 while you're at it. The easiest way to satisfy Chris' usecase and remove the dependency would be to add #define DRM_PRINT_NAME "drm" in drm_print.h and use that. Sean > > Signed-off-by: Sam Ravnborg > Suggested-by: Daniel Vetter > Reviewed-by: Daniel Vetter > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Sean Paul > Cc: David Airlie > Cc: Rob Clark > Cc: Sean Paul > Cc: Chris Wilson > Cc: Daniel Vetter > --- > include/drm/drm_print.h | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h > index a5d6f2f3e430..760d1bd0eaf1 100644 > --- a/include/drm/drm_print.h > +++ b/include/drm/drm_print.h > @@ -32,8 +32,6 @@ > #include > #include > > -#include > - > /** > * DOC: print > * > @@ -287,7 +285,7 @@ void drm_err(const char *format, ...); > /* Macros to make printk easier */ > > #define _DRM_PRINTK(once, level, fmt, ...) \ > - printk##once(KERN_##level "[" DRM_NAME "] " fmt, ##__VA_ARGS__) > + printk##once(KERN_##level "[drm] " fmt, ##__VA_ARGS__) > > #define DRM_INFO(fmt, ...) \ > _DRM_PRINTK(, INFO, fmt, ##__VA_ARGS__) > -- > 2.20.1 > -- Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel