From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 726BCC76195 for ; Fri, 19 Jul 2019 08:04:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4B7262184E for ; Fri, 19 Jul 2019 08:04:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Dk7ogObY"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="m8MOrcHm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B7262184E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cxXPRGP34SHM5LepNYIUMdfPZZABifXf1kd0eHVBIpc=; b=Dk7ogObY0xts1m 6FLVNvuvguE4DkBbec02I8gG7U+ouPihCQ0qB2/vfO/qm6yFLC4YdSxk+30FXujuqBzytJ5OuUE1s YIgRWpfju5ceFjR8p8+99ANHFmwlFY8uOFYMndmRGEscOMj73PWKUB5mrjVWnUfb34a519sVpvsUc xKBXmLEaWrEac77cNIZdPvNj+H0/edkxid1l6xPrTWrHYOpcfFwxFa9SrAxxW/cgDxnyliGh7MXEO of0ZDCK5YZxxWmgz48u7YUIMkE10MNzOR9Xj3WG7rrhtgmLguZqtZMe5nA0+xRXX2o1sgAW9qkEEA UI6r758u7sPBypKJJ2SQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hoNsl-00012I-JO; Fri, 19 Jul 2019 08:04:47 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hoNsi-00011f-55 for linux-arm-kernel@lists.infradead.org; Fri, 19 Jul 2019 08:04:45 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 92CAD20665; Fri, 19 Jul 2019 08:04:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563523483; bh=R9hD24Tj+KSZAJ28RSPSUwPQVIMBYE4b6HdUPoO5ENo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=m8MOrcHmD7GUTE+3OqkFDbOKMNS9fnRrLxrB7nLIQkjljVojmxNAdqsPbJ5fOThya mPOeyalN6YXDdpXe7XSJL5yRtQx9zsxHlRo+8r62FsFHDCIkp4aqDtw/7yKEWCTs6c YBeOG8iYEDoFccPxedp3h0UP/Fk3hxTZWN2j6Yu8= Date: Fri, 19 Jul 2019 09:04:36 +0100 From: Will Deacon To: Vincenzo Frascino Subject: Re: [PATCH] arm64: vdso: Cleanup Makefiles. Message-ID: <20190719080435.f3nlecyu3ysnsnpv@willie-the-truck> References: <20190712153746.5dwwptgrle3z25m7@willie-the-truck> <20190718114121.33024-1-vincenzo.frascino@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190718114121.33024-1-vincenzo.frascino@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190719_010444_210836_B0036E44 X-CRM114-Status: GOOD ( 11.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, naohiro.aota@wdc.com, sthotton@marvell.com, luto@kernel.org, arnd@arndb.de, huw@codeweavers.com, catalin.marinas@arm.com, daniel.lezcano@linaro.org, will.deacon@arm.com, linux-kernel@vger.kernel.org, linux@armlinux.org.uk, yamada.masahiro@socionext.com, andre.przywara@arm.com, john.stultz@linaro.org, 0x7f454c46@gmail.com, linux@rasmusvillemoes.dk, tglx@linutronix.de, salyzyn@android.com, pcc@google.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 18, 2019 at 12:41:21PM +0100, Vincenzo Frascino wrote: > diff --git a/arch/arm64/kernel/vdso32/Makefile b/arch/arm64/kernel/vdso32/Makefile > index 21009ed5a755..6c4e496309c4 100644 > --- a/arch/arm64/kernel/vdso32/Makefile > +++ b/arch/arm64/kernel/vdso32/Makefile > @@ -155,17 +155,17 @@ $(asm-obj-vdso): %.o: %.S FORCE > $(call if_changed_dep,vdsoas) > > # Actual build commands > -quiet_cmd_vdsold_and_vdso_check = LD $@ > +quiet_cmd_vdsold_and_vdso_check = VDSOLIB $@ > cmd_vdsold_and_vdso_check = $(cmd_vdsold); $(cmd_vdso_check) > > -quiet_cmd_vdsold = VDSOL $@ > +quiet_cmd_vdsold = VDSOLD $@ I think we should be more consistent about whether or not we prefix things with VDSO, so either go with "VDSOLD, VDSOCC and VDSOAS" or stick to "LD, CC and AS" rather than mixing between them. I think my suggestion would be something along the lines of CC, LD, AS for the native vdso and CC32, LD32, AS32 for the compat vdso. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel