linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: "Koenig, Christian" <Christian.Koenig@amd.com>
Cc: "David Airlie" <airlied@linux.ie>,
	"Daniel Vetter" <daniel.vetter@ffwll.ch>,
	"Liviu Dudau" <Liviu.Dudau@arm.com>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"Chris Wilson" <chris@chris-wilson.co.uk>,
	"Eric Anholt" <eric@anholt.net>,
	"Zhou, David(ChunMing)" <David1.Zhou@amd.com>,
	"Stefan Agner" <stefan@agner.ch>,
	"Maxime Ripard" <maxime.ripard@bootlin.com>,
	"CK Hu" <ck.hu@mediatek.com>,
	"Thierry Reding" <treding@nvidia.com>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Rob Herring" <robh@kernel.org>,
	"Jani Nikula" <jani.nikula@intel.com>,
	"Intel Graphics Development" <intel-gfx@lists.freedesktop.org>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
	"Lionel Landwerlin" <lionel.g.landwerlin@intel.com>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"Sean Paul" <sean@poorly.run>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"Boris Brezillon" <bbrezillon@kernel.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"Rob Clark" <robdclark@gmail.com>,
	"Noralf Trønnes" <noralf@tronnes.org>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	"Sean Paul" <seanpaul@chromium.org>
Subject: Re: [PATCH v1 11/11] drm: drop uapi dependency from drm_file.h
Date: Fri, 19 Jul 2019 13:08:00 +0200	[thread overview]
Message-ID: <20190719110800.GA3247@ravnborg.org> (raw)
In-Reply-To: <57ad927c-4b7f-d6e2-edda-720386190054@amd.com>

Hi Christian.

Thanks for your comments and very valid question.

On Fri, Jul 19, 2019 at 06:56:47AM +0000, Koenig, Christian wrote:
> Am 18.07.19 um 18:15 schrieb Sam Ravnborg:
> > drm_file used drm_magic_t from uapi/drm/drm.h.
> > This is a simple unsigned int.
> > Just opencode it as such to break the dependency from this header file
> > to uapi.
> 
> Mhm, why do you want to remove UAPI dependency here in the first place?

The idea is to make include/drm/* independent of uapi/drm/* so the
header files are less tangled up thus easier to read and comprehend.

.c files that requires uapi can then include the uapi headers.

For now my focus was solely on uapi/drm/drm.h - so I dunno if this
is an achievable goal for include/drm/*.

For uapi/drm/* headers things are more clear. They shall be
independent of include/drm/* as they are exported.

> I mean the type can't change because it is UAPI, but it is rather bad 
> for a documentation point of view.

For a widely used type I would agree.
For struct auth, that is ony used in drm_auth.c then the documentation
impact is minor. But your point is indeed valid.
(struct auth has one field of type magic_t).

I will await further feedback before we decide to apply this patch or
not.
The patches that pushes include of drm/drm.h to the respective .c
files are legit as we drop the dependency on an indirectly included
header file. I will process these patches.

	Sam

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-07-19 11:08 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-18 16:14 [PATCH v1 0/11] drm: header maintenance Sam Ravnborg
2019-07-18 16:14 ` [PATCH v1 01/11] drm/panel: make drm_panel.h self-contained Sam Ravnborg
2019-07-18 17:36   ` Sean Paul
2019-07-18 16:14 ` [PATCH v1 02/11] drm: drop uapi dependency from drm_print.h Sam Ravnborg
2019-07-18 16:46   ` Chris Wilson
2019-07-19  6:54     ` Koenig, Christian
2019-07-29 12:45       ` Jani Nikula
2019-07-29 14:35         ` Sam Ravnborg
2019-07-29 15:28           ` Koenig, Christian
2019-07-29 17:50             ` Sam Ravnborg
2019-08-02 13:48               ` [Intel-gfx] " Jani Nikula
2019-08-02 15:28                 ` Sam Ravnborg
2019-07-18 17:40   ` Sean Paul
2019-07-18 16:14 ` [PATCH v1 03/11] drm: drop uapi dependency from drm_vblank.h Sam Ravnborg
2019-07-18 17:41   ` Sean Paul
2019-07-18 16:15 ` [PATCH v1 04/11] drm/ati_pcigart: drop dependency on drm_os_linux.h Sam Ravnborg
2019-07-18 17:49   ` Sean Paul
2019-07-18 18:11     ` Sam Ravnborg
2019-07-18 18:30       ` Sean Paul
2019-07-18 16:15 ` [PATCH v1 05/11] drm/vblank: drop use of DRM_WAIT_ON() Sam Ravnborg
2019-07-18 17:50   ` Sean Paul
2019-07-18 16:15 ` [PATCH v1 06/11] drm: direct include of drm.h in drm_gem.c Sam Ravnborg
2019-07-18 17:51   ` Sean Paul
2019-07-18 16:15 ` [PATCH v1 07/11] drm: direct include of drm.h in drm_gem_shmem_helper.c Sam Ravnborg
2019-07-18 17:51   ` Sean Paul
2019-07-18 16:15 ` [PATCH v1 08/11] drm: direct include of drm.h in drm_prime.c Sam Ravnborg
2019-07-18 17:51   ` Sean Paul
2019-07-18 16:15 ` [PATCH v1 09/11] drm: direct include of drm.h in drm_syncobj.c Sam Ravnborg
2019-07-18 17:51   ` Sean Paul
2019-07-18 16:15 ` [PATCH v1 10/11] drm/mediatek: direct include of drm.h in mtk_drm_gem.c Sam Ravnborg
2019-07-18 17:52   ` Sean Paul
2019-07-19  1:30   ` CK Hu
2019-07-19  1:34     ` CK Hu
2019-07-18 16:15 ` [PATCH v1 11/11] drm: drop uapi dependency from drm_file.h Sam Ravnborg
2019-07-18 18:40   ` Sean Paul
2019-07-19  6:56   ` Koenig, Christian
2019-07-19 11:08     ` Sam Ravnborg [this message]
2019-07-19 21:26 ` [PATCH v1 0/11] drm: header maintenance Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190719110800.GA3247@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=Christian.Koenig@amd.com \
    --cc=David1.Zhou@amd.com \
    --cc=Liviu.Dudau@arm.com \
    --cc=airlied@linux.ie \
    --cc=bbrezillon@kernel.org \
    --cc=chris@chris-wilson.co.uk \
    --cc=ck.hu@mediatek.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=eric@anholt.net \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=lionel.g.landwerlin@intel.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=matthias.bgg@gmail.com \
    --cc=maxime.ripard@bootlin.com \
    --cc=noralf@tronnes.org \
    --cc=p.zabel@pengutronix.de \
    --cc=robdclark@gmail.com \
    --cc=robh@kernel.org \
    --cc=sean@poorly.run \
    --cc=seanpaul@chromium.org \
    --cc=stefan@agner.ch \
    --cc=treding@nvidia.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).