From: Will Deacon <will@kernel.org>
To: James Morse <james.morse@arm.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: entry: SP Alignment Fault doesn't write to FAR_EL1
Date: Mon, 22 Jul 2019 11:34:09 +0100 [thread overview]
Message-ID: <20190722103408.6ayjqvbmbymr44nl@willie-the-truck> (raw)
In-Reply-To: <20190717165602.114502-1-james.morse@arm.com>
Hi James,
On Wed, Jul 17, 2019 at 05:56:02PM +0100, James Morse wrote:
> Comparing the arm-arm's pseudocode for AArch64.PCAlignmentFault() with
> AArch64.SPAlignmentFault() shows that SP faults don't copy the faulty-SP
> to FAR_EL1, but this is where we read from, and the address we provide
> to user-space with the BUS_ADRALN signal.
>
> This value will be UNKNOWN due to the previous ERET to user-space.
> If the last value is preserved, on systems with KASLR or KPTI this will
> be the user-space link-register left in FAR_EL1 by tramp_exit().
>
> Fix this to retrieve the original sp_el0 value, and pass this to
> do_sp_pc_fault().
>
> Fixes: 60ffc30d5652 ("arm64: Exception handling")
> Signed-off-by: James Morse <james.morse@arm.com>
> ---
> arch/arm64/kernel/entry.S | 25 ++++++++++++++++++++-----
> 1 file changed, 20 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm64/kernel/entry.S b/arch/arm64/kernel/entry.S
> index 165da78815c5..023e533c537e 100644
> --- a/arch/arm64/kernel/entry.S
> +++ b/arch/arm64/kernel/entry.S
> @@ -743,9 +743,9 @@ el0_sync:
> ccmp x24, #ESR_ELx_EC_WFx, #4, ne
> b.eq el0_sys
> cmp x24, #ESR_ELx_EC_SP_ALIGN // stack alignment exception
> - b.eq el0_sp_pc
> + b.eq el0_sp
> cmp x24, #ESR_ELx_EC_PC_ALIGN // pc alignment exception
> - b.eq el0_sp_pc
> + b.eq el0_pc
> cmp x24, #ESR_ELx_EC_UNKNOWN // unknown exception in EL0
> b.eq el0_undef
> cmp x24, #ESR_ELx_EC_BREAKPT_LOW // debug exception in EL0
> @@ -769,7 +769,7 @@ el0_sync_compat:
> cmp x24, #ESR_ELx_EC_FP_EXC32 // FP/ASIMD exception
> b.eq el0_fpsimd_exc
> cmp x24, #ESR_ELx_EC_PC_ALIGN // pc alignment exception
> - b.eq el0_sp_pc
> + b.eq el0_pc
> cmp x24, #ESR_ELx_EC_UNKNOWN // unknown exception in EL0
> b.eq el0_undef
> cmp x24, #ESR_ELx_EC_CP15_32 // CP15 MRC/MCR trap
> @@ -869,9 +869,24 @@ el0_fpsimd_exc:
> mov x1, sp
> bl do_fpsimd_exc
> b ret_to_user
> -el0_sp_pc:
> +el0_sp:
> /*
> - * Stack or PC alignment exception handling
> + * Stack alignment exception handling
> + */
> + gic_prio_kentry_setup tmp=x0
> + enable_da_f
> +#ifdef CONFIG_TRACE_IRQFLAGS
> + bl trace_hardirqs_off
> +#endif
> + ct_user_exit
> + ldr x0, [sp, #S_SP]
> + mov x1, x25
> + mov x2, sp
> + bl do_sp_pc_abort
> + b ret_to_user
> +el0_pc:
> + /*
> + * PC alignment exception handling
Given that this really isn't a fast path, I think it's preferable to avoid
duplicating the entry code and instead just have something like:
@@ -858,11 +858,15 @@ el0_fpsimd_exc:
mov x1, sp
bl do_fpsimd_exc
b ret_to_user
+el0_sp:
+ ldr x26, [sp, #S_SP]
+ b el0_sp_pc
+el0_pc:
+ mrs x26, far_el1
el0_sp_pc:
/*
* Stack or PC alignment exception handling
*/
- mrs x26, far_el1
gic_prio_kentry_setup tmp=x0
enable_da_f
#ifdef CONFIG_TRACE_IRQFLAGS
I also think we should do the same thing for the EL1 case, even though
the address is currently ignored by the C handler.
What do you reckon?
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-07-22 10:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-17 16:56 [PATCH] arm64: entry: SP Alignment Fault doesn't write to FAR_EL1 James Morse
2019-07-22 10:34 ` Will Deacon [this message]
2019-07-22 14:27 ` James Morse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190722103408.6ayjqvbmbymr44nl@willie-the-truck \
--to=will@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).