From: Rob Herring <robh@kernel.org>
To: Manish Narani <manish.narani@xilinx.com>
Cc: mark.rutland@arm.com, ulf.hansson@linaro.org, kernel@esmil.dk,
viresh.kumar@linaro.org, linux-kernel@vger.kernel.org,
tony.xie@rock-chips.com, philipp.tomsich@theobroma-systems.com,
heiko@sntech.de, michal.simek@xilinx.com,
linux-rockchip@lists.infradead.org, jolly.shah@xilinx.com,
devicetree@vger.kernel.org, scott.branden@broadcom.com,
nava.manne@xilinx.com, ayaka@soulik.info, mdf@kernel.org,
linux-arm-kernel@lists.infradead.org, rajan.vaja@xilinx.com,
linux-mmc@vger.kernel.org, adrian.hunter@intel.com,
olof@lixom.net, christoph.muellner@theobroma-systems.com
Subject: Re: [PATCH v2 01/11] dt-bindings: mmc: arasan: Update documentation for SD Card Clock
Date: Mon, 22 Jul 2019 15:54:04 -0600 [thread overview]
Message-ID: <20190722215404.GA28292@bogus> (raw)
In-Reply-To: <1561958991-21935-2-git-send-email-manish.narani@xilinx.com>
On Mon, Jul 01, 2019 at 10:59:41AM +0530, Manish Narani wrote:
> The clock handling is to be updated in the Arasan SDHCI. As the
> 'devm_clk_register' is deprecated in the clock framework, this needs to
> specify one more clock named 'clk_sdcard' to get the clock in the driver
> via 'devm_clk_get()'. This clock represents the clock from controller to
> the card.
Please explain why in terms of the binding, not some driver calls.
> Signed-off-by: Manish Narani <manish.narani@xilinx.com>
> ---
> Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 15 ++++++++++-----
> 1 file changed, 10 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> index 1edbb04..15c6397 100644
> --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> @@ -23,6 +23,10 @@ Required Properties:
> - reg: From mmc bindings: Register location and length.
> - clocks: From clock bindings: Handles to clock inputs.
> - clock-names: From clock bindings: Tuple including "clk_xin" and "clk_ahb"
> + Apart from these two there is one more optional clock which
> + is "clk_sdcard". This clock represents output clock from
> + controller and card. This must be specified when #clock-cells
> + is specified.
> - interrupts: Interrupt specifier
>
> Required Properties for "arasan,sdhci-5.1":
> @@ -36,9 +40,10 @@ Optional Properties:
> - clock-output-names: If specified, this will be the name of the card clock
> which will be exposed by this device. Required if #clock-cells is
> specified.
> - - #clock-cells: If specified this should be the value <0>. With this property
> - in place we will export a clock representing the Card Clock. This clock
> - is expected to be consumed by our PHY. You must also specify
> + - #clock-cells: If specified this should be the value <0>. With this
> + property in place we will export one clock representing the Card
> + Clock. This clock is expected to be consumed by our PHY. You must also
> + specify
specify what?
The 3rd clock input I assume? This statement means any existing users
with 2 clock inputs and #clock-cells are in error now. Is that correct?
> - xlnx,fails-without-test-cd: when present, the controller doesn't work when
> the CD line is not connected properly, and the line is not connected
> properly. Test mode can be used to force the controller to function.
> @@ -70,8 +75,8 @@ Example:
> compatible = "rockchip,rk3399-sdhci-5.1", "arasan,sdhci-5.1";
> reg = <0x0 0xfe330000 0x0 0x10000>;
> interrupts = <GIC_SPI 11 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&cru SCLK_EMMC>, <&cru ACLK_EMMC>;
> - clock-names = "clk_xin", "clk_ahb";
> + clocks = <&cru SCLK_EMMC>, <&cru ACLK_EMMC>, <&sdhci 0>;
> + clock-names = "clk_xin", "clk_ahb", "clk_sdcard";
> arasan,soc-ctl-syscon = <&grf>;
> assigned-clocks = <&cru SCLK_EMMC>;
> assigned-clock-rates = <200000000>;
> --
> 2.1.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-07-22 21:54 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-01 5:29 [PATCH v2 00/11] Arasan SDHCI enhancements and ZynqMP Tap Delays Handling Manish Narani
2019-07-01 5:29 ` [PATCH v2 01/11] dt-bindings: mmc: arasan: Update documentation for SD Card Clock Manish Narani
2019-07-22 21:54 ` Rob Herring [this message]
2019-07-23 8:23 ` Manish Narani
2019-07-25 13:00 ` Ulf Hansson
2019-08-19 9:21 ` Manish Narani
2019-08-22 13:38 ` Ulf Hansson
2019-08-22 18:23 ` Heiko Stuebner
2019-08-23 10:01 ` Manish Narani
2019-07-01 5:29 ` [PATCH v2 02/11] arm64: dts: rockchip: Add optional clock property indicating sdcard clock Manish Narani
2019-07-01 5:29 ` [PATCH v2 03/11] mmc: sdhci-of-arasan: Replace deprecated clk API calls Manish Narani
2019-07-01 5:29 ` [PATCH v2 04/11] mmc: sdhci-of-arasan: Separate out clk related data to another structure Manish Narani
2019-07-01 5:29 ` [PATCH v2 05/11] dt-bindings: mmc: arasan: Update Documentation for the input clock Manish Narani
2019-07-22 21:56 ` Rob Herring
2019-07-01 5:29 ` [PATCH v2 06/11] mmc: sdhci-of-arasan: Add sampling clock for a phy to use Manish Narani
2019-07-01 5:29 ` [PATCH v2 07/11] dt-bindings: mmc: arasan: Add optional properties for Arasan SDHCI Manish Narani
2019-07-22 22:01 ` Rob Herring
2019-07-01 5:29 ` [PATCH v2 08/11] mmc: sdhci-of-arasan: Add support to set clock phase delays for SD Manish Narani
2019-07-01 5:29 ` [PATCH v2 09/11] firmware: xilinx: Add SDIO Tap Delay APIs Manish Narani
2019-07-01 18:06 ` Jolly Shah
2019-07-02 5:03 ` Manish Narani
2019-07-01 5:29 ` [PATCH v2 10/11] dt-bindings: mmc: arasan: Document 'xlnx, zynqmp-8.9a' controller Manish Narani
2019-07-22 22:06 ` [PATCH v2 10/11] dt-bindings: mmc: arasan: Document 'xlnx,zynqmp-8.9a' controller Rob Herring
2019-07-01 5:29 ` [PATCH v2 11/11] mmc: sdhci-of-arasan: Add support for ZynqMP Platform Tap Delays Setup Manish Narani
2019-07-10 11:33 ` [PATCH v2 00/11] Arasan SDHCI enhancements and ZynqMP Tap Delays Handling Adrian Hunter
2019-07-15 7:15 ` Manish Narani
2019-07-22 4:56 ` Manish Narani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190722215404.GA28292@bogus \
--to=robh@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ayaka@soulik.info \
--cc=christoph.muellner@theobroma-systems.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jolly.shah@xilinx.com \
--cc=kernel@esmil.dk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=manish.narani@xilinx.com \
--cc=mark.rutland@arm.com \
--cc=mdf@kernel.org \
--cc=michal.simek@xilinx.com \
--cc=nava.manne@xilinx.com \
--cc=olof@lixom.net \
--cc=philipp.tomsich@theobroma-systems.com \
--cc=rajan.vaja@xilinx.com \
--cc=scott.branden@broadcom.com \
--cc=tony.xie@rock-chips.com \
--cc=ulf.hansson@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).