From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93C70C7618B for ; Tue, 23 Jul 2019 09:06:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 677D6227B6 for ; Tue, 23 Jul 2019 09:06:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UY7JbkZT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 677D6227B6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0rhkljL/WwlM7Epp1zBnIZj++MM03YgjUmtOBhLjK60=; b=UY7JbkZTzkOxoC A1BhtG4rwn/5GDKUKWmWD+NlxdFCxTAtA3RbLG1EKOD54eAVqrZAWq8HWYVTFPlHpZHWyXVCEFQPN Jwt6jfIuBead//XPbDOq4VI1TNmZzmRz9KYBVZ1c3iMphum1DdcnEiRdOaIBqpeYblszL48abi6Ug a2UdXYsgwm9SX/AdmTFUQwVxskm/Bj6z0L1mIojCQDC/966PH/UO+2PC1HdCCFRasdqioW411QgB1 uxUpRW6H78Mh/aymVAj0TAeddveIDxHtiyzjts2g0JSioeOIJPMESv9Q3t3KLfVD10HZynz+pKkmq 9FTqgGX1+9UaczR/gZIQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hpqkg-0001vx-IL; Tue, 23 Jul 2019 09:06:30 +0000 Received: from asavdk4.altibox.net ([109.247.116.15]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hpqjz-0001Xy-Ow; Tue, 23 Jul 2019 09:05:52 +0000 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 6855580489; Tue, 23 Jul 2019 11:05:34 +0200 (CEST) Date: Tue, 23 Jul 2019 11:05:32 +0200 From: Sam Ravnborg To: Andrzej Pietrasiewicz Subject: Re: [PATCH v4 14/23] drm/tilcdc: Provide ddc symlink in connector sysfs directory Message-ID: <20190723090532.GA787@ravnborg.org> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=VcLZwmh9 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=QX4gbG5DAAAA:8 a=A4d5gvsdyd3DzmHwh6gA:9 a=CjuIK1q_8ugA:10 a=AbAUZ8qAyYyZVLSsDulk:22 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190723_020548_417653_53FC4987 X-CRM114-Status: GOOD ( 16.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , Maxime Ripard , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Matthias Brugger , Thierry Reding , Laurent Pinchart , Shawn Guo , kernel@collabora.com, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, Sean Paul , Krzysztof Kozlowski , Jonathan Hunter , David Airlie , Chen-Yu Tsai , Kukjin Kim , NXP Linux Team , Dave Airlie , Thomas Zimmermann , Jonas Karlman , linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, Jyri Sarha , Alexios Zavras , Mamta Shukla , linux-mediatek@lists.infradead.org, Rodrigo Vivi , linux-tegra@vger.kernel.org, Thomas Gleixner , Vincent Abriou , linux-arm-kernel@lists.infradead.org, Jernej Skrabec , amd-gfx@lists.freedesktop.org, Tomi Valkeinen , Greg Kroah-Hartman , Seung-Woo Kim , Douglas Anderson , Todor Tomov , Kyungmin Park , Huang Rui , Pengutronix Kernel Team , Alex Deucher , freedreno@lists.freedesktop.org, Christian =?iso-8859-1?Q?K=F6nig?= , Gerd Hoffmann Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andrzej On Thu, Jul 11, 2019 at 01:26:41PM +0200, Andrzej Pietrasiewicz wrote: > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz > --- > drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c > index 62d014c20988..c373edb95666 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c > +++ b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c > @@ -219,6 +219,7 @@ static struct drm_connector *tfp410_connector_create(struct drm_device *dev, > tfp410_connector->mod = mod; > > connector = &tfp410_connector->base; > + connector->ddc = mod->i2c; > > drm_connector_init(dev, connector, &tfp410_connector_funcs, > DRM_MODE_CONNECTOR_DVID); When reading this code, it looks strange that we set connector->ddc *before* the call to init the connector. One could risk that drm_connector_init() used memset(..) to clear all fields or so, and it would break this order. As it is today the code works as I read it. Sam _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel