From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E38A8C7618B for ; Tue, 23 Jul 2019 08:48:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A7C80223A1 for ; Tue, 23 Jul 2019 08:48:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mPX20xam" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A7C80223A1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xjVv9zGabVCqu3SeRA3uDxL4kPQsh4YDyNsGh49WR00=; b=mPX20xamjqdJnS h3XoGa1t/pu2Ki3RrPNRNMeAcs4G44JuF4AM8NFVV6JmDFbwgDWPdmLDcXVGPk3NOp3ORkqE1zoyv 6myWAvCYfYxhPlFW/7sjdG1VcK/barFRL+3XCCpkc6ZIAyLhgKL7YarFYd3IQRHJCguytSrGiwKz4 z0PSQoqt5Qt4ZFbJUf0DqXNdCB+zuk0kP2Oznv9CWP+PrQfpLWwOWdsnbmpcesKHX6yDNLErMBpMi NqrJASDZKPjipMzedim20k9BmQB8UIo7sabAZ/hbUmnQQrPDZAjlMyMiD4c9G/8GavzadeWVavTDG wprhgloCv1xveEXBnyTA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hpqTe-0002Kp-53; Tue, 23 Jul 2019 08:48:54 +0000 Received: from relay9-d.mail.gandi.net ([217.70.183.199]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hpqTa-0002KB-Ae for linux-arm-kernel@lists.infradead.org; Tue, 23 Jul 2019 08:48:51 +0000 X-Originating-IP: 86.250.200.211 Received: from bootlin.com (lfbn-1-17395-211.w86-250.abo.wanadoo.fr [86.250.200.211]) (Authenticated sender: maxime.chevallier@bootlin.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id E827EFF809; Tue, 23 Jul 2019 08:48:37 +0000 (UTC) Date: Tue, 23 Jul 2019 10:48:49 +0200 From: Maxime Chevallier To: Miquel Raynal Subject: Re: [PATCH v2 03/19] phy: mvebu-cp110-comphy: Add SMC call support Message-ID: <20190723104849.7158f634@bootlin.com> In-Reply-To: <20190627095104.22529-4-miquel.raynal@bootlin.com> References: <20190627095104.22529-1-miquel.raynal@bootlin.com> <20190627095104.22529-4-miquel.raynal@bootlin.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190723_014850_526757_B55B8713 X-CRM114-Status: UNSURE ( 9.97 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Jason Cooper , devicetree@vger.kernel.org, Antoine Tenart , Grzegorz Jaszczyk , Gregory Clement , Russell King , Kishon Vijay Abraham I , Nadav Haklai , Rob Herring , Thomas Petazzoni , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Miquel, Thanks for this, I gave it a quick test and it looks good. On Thu, 27 Jun 2019 11:50:48 +0200 Miquel Raynal wrote: >From: Grzegorz Jaszczyk > >Keep the exact same list of supported configurations but first try to >use the firmware's implementation. If it fails, try the legacy method: >Linux implementation. > >Signed-off-by: Grzegorz Jaszczyk >[miquel.raynal@bootlin.com: adapt the content to the mainline driver] >Signed-off-by: Miquel Raynal [...] >+ dev_warn(priv->dev, >+ "Firmware could not configure PHY %d with mode %d (ret: %d), trying legacy method\n", >+ ret, lane->id, lane->mode); Small nit, you've got your parameters in the wrong order in that dev_warn. Besides that, Tested-by: Maxime Chevallier _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel