From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 946E6C7618B for ; Tue, 23 Jul 2019 15:19:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6D21220665 for ; Tue, 23 Jul 2019 15:19:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Zx9/BJOD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6D21220665 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bq3jtbym7fpLszHrLhenLnRUNXV7xx3olIxNcGpGmcc=; b=Zx9/BJODBC5YXC MD+3rmRPSYaNdjjuOKokV/fjX4LBn2nY0zH7iOYFBc+Q0MJ00twAZS5GG/TPgs0vTwr6ajx68CWJt iai9n57D9604LxLUV8JGo+0kEPT6l/wHVYhsOELDUhubLtuXOdUYws5CSlJ9VhSn/RxeR49tPUI7Z 7Qn0T45mSDFiGX8ifJejTG1saymWOjxo99j5UwQYYl/eYPvFoJytc/Efw1OW1QVJnovEtV6o5KCQz N+L4xBT0Wv4XVIwajVWAMzjsXmFgz6KldNJnaLqw594YCKaN9ZSlwMnnLw2NqgbDNEOwU7QU6n1jQ bcswFbi/GnaovpBvr81A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hpwa2-000425-3G; Tue, 23 Jul 2019 15:19:54 +0000 Received: from asavdk3.altibox.net ([109.247.116.14]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hpwZy-00041L-GU; Tue, 23 Jul 2019 15:19:52 +0000 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 54655200D5; Tue, 23 Jul 2019 17:19:41 +0200 (CEST) Date: Tue, 23 Jul 2019 17:19:39 +0200 From: Sam Ravnborg To: Andrzej Pietrasiewicz Subject: Re: [PATCH v4 14/23] drm/tilcdc: Provide ddc symlink in connector sysfs directory Message-ID: <20190723151939.GA13718@ravnborg.org> References: <20190723090532.GA787@ravnborg.org> <3ad60be5-49cf-4017-4b74-53a2d6272deb@collabora.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3ad60be5-49cf-4017-4b74-53a2d6272deb@collabora.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=dqr19Wo4 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=8nJEP1OIZ-IA:10 a=QX4gbG5DAAAA:8 a=6mu-9OIm9KcVJ4iDVDwA:9 a=wPNLvfGTeEIA:10 a=AbAUZ8qAyYyZVLSsDulk:22 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190723_081950_894590_03A25196 X-CRM114-Status: GOOD ( 17.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , Maxime Ripard , dri-devel@lists.freedesktop.org, Douglas Anderson , linux-tegra@vger.kernel.org, Thierry Reding , Laurent Pinchart , kernel@collabora.com, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, Vincent Abriou , Krzysztof Kozlowski , Jonathan Hunter , David Airlie , Chen-Yu Tsai , Kukjin Kim , NXP Linux Team , Dave Airlie , freedreno@lists.freedesktop.org, Pengutronix Kernel Team , Jonas Karlman , linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, Jyri Sarha , Alexios Zavras , Mamta Shukla , linux-mediatek@lists.infradead.org, Rodrigo Vivi , Matthias Brugger , Thomas Gleixner , Sean Paul , linux-arm-kernel@lists.infradead.org, Jernej Skrabec , amd-gfx@lists.freedesktop.org, Tomi Valkeinen , Greg Kroah-Hartman , Seung-Woo Kim , linux-kernel@vger.kernel.org, Todor Tomov , Kyungmin Park , Huang Rui , Thomas Zimmermann , Alex Deucher , Shawn Guo , Christian =?iso-8859-1?Q?K=F6nig?= , Gerd Hoffmann Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andrej. On Tue, Jul 23, 2019 at 02:44:50PM +0200, Andrzej Pietrasiewicz wrote: > Hi Sam, > = > W dniu 23.07.2019 o=A011:05, Sam Ravnborg pisze: > > Hi Andrzej > > = > > On Thu, Jul 11, 2019 at 01:26:41PM +0200, Andrzej Pietrasiewicz wrote: > > > Use the ddc pointer provided by the generic connector. > > > = > > > Signed-off-by: Andrzej Pietrasiewicz > > > --- > > > drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 1 + > > > 1 file changed, 1 insertion(+) > > > = > > > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c b/drivers/gpu/drm= /tilcdc/tilcdc_tfp410.c > > > index 62d014c20988..c373edb95666 100644 > > > --- a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c > > > +++ b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c > > > @@ -219,6 +219,7 @@ static struct drm_connector *tfp410_connector_cre= ate(struct drm_device *dev, > > > tfp410_connector->mod =3D mod; > > > connector =3D &tfp410_connector->base; > > > + connector->ddc =3D mod->i2c; > > > drm_connector_init(dev, connector, &tfp410_connector_funcs, > > > DRM_MODE_CONNECTOR_DVID); > > = > > When reading this code, it looks strange that we set connector->ddc > > *before* the call to init the connector. > > One could risk that drm_connector_init() used memset(..) to clear all > > fields or so, and it would break this order. > = > I verified the code of drm_connector_init() and cannot find any memset() > invocations there. What is your actual concern? My concern is that drm_connector_init() maybe sometime in the future will init all fileds in drm_connector, so we loose any assingments done to drm_connector from *before* we called the init function. Moving the assignment to after drm_connector_init() would not let us depend on the actual implmentation of drm_connector_init(). Sam _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel