From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A92FC76186 for ; Tue, 23 Jul 2019 22:25:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E0C072184B for ; Tue, 23 Jul 2019 22:25:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VDFQLuTC"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="jf5frP/e" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E0C072184B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3BxnWTgx38pRNi2BY8LLAXatFBo/QEZVpnDegWHKsdU=; b=VDFQLuTC0+l8PN RGfBh1T/0RYND0B0h/I16BLHSAYbIs17xDmuRkBmeshkvrWwWhYUyQkG78BaqZf9iNADstgHee1rk /BL3TyAMBY0S5npd9RmAWkk3vzABcwHoVpHH8y/i3N+vvjS6IV1BEQ2ggozYdIS6fFHz+C7bvzxyi knqpkkLWx5JGA/r/2pN557cvkm7L5w4nHAfy2gOO6ejykF8G73we3MqVAjFBHDgvrIIZlYyevUS0n Zv/+AcslEBJ5sBjPyLll569+L3F7wN4iGy2tCRsZNe9Ss40bapY8OlideYnTgCOEvvpS+SYMXQb1F tU9JWikEZ1pVKii/yEqg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hq3Do-00045r-52; Tue, 23 Jul 2019 22:25:24 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hq3DR-0002Zj-K8 for linux-arm-kernel@lists.infradead.org; Tue, 23 Jul 2019 22:25:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=JBjWPZFWOr2ZDHDrYZ3UsWyBFtkPoXj28/OnBpUt3GQ=; b=jf5frP/e/9v9AkZbCfEO1L6WHG stJcK+9H+bc3VfDJ5aFprTTmZFD7CoLUusKuhuF6EPbqfVtpw152T6zfk5purm9QXR0LU46OaYxzu VLIWYChioB4lOP9a2ZTjH6ma77mxIHPt7PK5Wx0eAX/A4Mt4/urbLGxvC+8oqHXfEgQY=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hq3DK-0003xn-Oo; Wed, 24 Jul 2019 00:24:54 +0200 Date: Wed, 24 Jul 2019 00:24:54 +0200 From: Andrew Lunn To: Claudiu Manoil Subject: Re: [PATCH net-next 1/3] enetc: Add mdio bus driver for the PCIe MDIO endpoint Message-ID: <20190723222454.GE13517@lunn.ch> References: <1563894955-545-1-git-send-email-claudiu.manoil@nxp.com> <1563894955-545-2-git-send-email-claudiu.manoil@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1563894955-545-2-git-send-email-claudiu.manoil@nxp.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190723_152502_242481_6024D2BC X-CRM114-Status: UNSURE ( 6.61 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, netdev@vger.kernel.org, alexandru.marginean@nxp.com, linux-kernel@vger.kernel.org, Li Yang , Rob Herring , "David S . Miller" , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org > + bus = mdiobus_alloc_size(sizeof(u32 *)); > + if (!bus) > + return -ENOMEM; > + > + bus->priv = pci_iomap_range(pdev, 0, ENETC_MDIO_REG_OFFSET, 0); This got me confused for a while. You allocate space for a u32 pointer. bus->priv will point to this space. However, you are not using this space, you {ab}use the pointer to directly hold the return from pci_iomap_range(). This works, but sparse is probably unhappy, and you are wasting the space the u32 pointer takes. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel