From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D661C76186 for ; Wed, 24 Jul 2019 17:16:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1B68321911 for ; Wed, 24 Jul 2019 17:16:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="I40fqBS5"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sirena.org.uk header.i=@sirena.org.uk header.b="cHWXouJR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1B68321911 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ULA3k0JJkrjRLzILI3RfxsQJ/+FxOCWPA7ge3MsZI1k=; b=I40fqBS5O52NVNybscN1WaQA3 jN1MzeJ+NBKsliESQyjXAqnTmHCbuoR8LvAkbNROCs8xoZsAV+aJam2ZDHZsRuLWlcacRCavOSvda JDWdWheP/gs0eWoRvlyXUZIq3bKryHqM3Y3jsUJH5wfYjMMAjZJhiP109u0Tcou0KvZslcwli16y4 +Z6jpgOevlZNWcgVouP/D7eVLIsAYQ+PJSLFSJ5NZ/LC0wOVFbJbwpTJpHsUDPbfbIEmaqSX3tNKM fRmHmbwW5Tg626ch5lbqsFz29MNqwzB2wgRPQYQVSP6RoRPl4AqInCmgX2WJK7HC/qydGCK5mJLhQ pvAeHjaEQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hqKs3-0000r8-Ai; Wed, 24 Jul 2019 17:16:07 +0000 Received: from heliosphere.sirena.org.uk ([2a01:7e01::f03c:91ff:fed4:a3b6]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hqKrd-0008V0-MB; Wed, 24 Jul 2019 17:15:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=TzXHUjTTbk+BjMuhY4cV38Izc9snjobAy92tPxSUUT0=; b=cHWXouJRm4GoOyPvpPbZGdTjl 9R0ZT7lK8MTVtd4e2G5wSsu1nUoRhhjZRvV6pOQE6QqVps9lQ7TsntaRLhEZ2SJjRFZ6FoKjTtBm2 21H3l1izCI0TL5r9H5Y3Xv7TsAPPV0E5KFRPrs8CviXbJynzMLyFXHKIwgpU4dcUTVnlE=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=ypsilon.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1hqKrT-0008GF-Lc; Wed, 24 Jul 2019 17:15:31 +0000 Received: by ypsilon.sirena.org.uk (Postfix, from userid 1000) id D58182742B5D; Wed, 24 Jul 2019 18:15:30 +0100 (BST) Date: Wed, 24 Jul 2019 18:15:30 +0100 From: Mark Brown To: Stefan Wahren Subject: Re: [PATCH RFC 15/18] spi: bcm2835: enable shared interrupt support Message-ID: <20190724171530.GF4524@sirena.org.uk> References: <1563398164-2679-1-git-send-email-wahrenst@gmx.net> <1563398164-2679-2-git-send-email-wahrenst@gmx.net> <20190718124205.GC5761@sirena.org.uk> <28dd33bc-c1b5-b976-ad19-ebf681df8647@gmx.net> MIME-Version: 1.0 In-Reply-To: <28dd33bc-c1b5-b976-ad19-ebf681df8647@gmx.net> X-Cookie: Matrimony is the root of all evil. User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190724_101541_812002_0F925AB7 X-CRM114-Status: GOOD ( 19.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Ulf Hansson , Florian Fainelli , Scott Branden , Stephen Boyd , Ray Jui , Linus Walleij , Adrian Hunter , Eric Anholt , Rob Herring , bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, Martin Sperl , Michael Turquette , Nicolas Saenz Julienne , linux-rpi-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============8472746012970147352==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============8472746012970147352== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="E7i4zwmWs5DOuDSH" Content-Disposition: inline --E7i4zwmWs5DOuDSH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jul 18, 2019 at 08:21:36PM +0200, Stefan Wahren wrote: > Am 18.07.19 um 20:05 schrieb Florian Fainelli: > > On 7/18/19 10:53 AM, Stefan Wahren wrote: > > Martin's patch is more efficient in terms of amount of register > > accesses, but I am bit worried (based on the register description) that > > the INTR bit is only asserted with the read FIFO crossing a certain > > condition and that a TX only transfer may not be captured by that condition. It looks like the driver sets the bit for TX only transfers so that's probably fine but I might be missing something. > > Maybe we can just check spi_controller::idling to determine if that > > specific instance generated an interrupt? > sorry, i'm not that SPI expert. I suggest to drop this non-essential > patch from the series and discuss this separate. I'm not opposed to the patch, I'm just concerned based on the combination of the description and the code that it might not be doing what's expected. If it's mostly just an optimization that provides a fast path in the case the interrupt is shared rather than a correctness thing then it's fine. A comment in the commit message or the code about this being an optimization would be a good idea though. --E7i4zwmWs5DOuDSH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl04kjIACgkQJNaLcl1U h9CHrwf/aVBtjOP8dRmPIFKgHsLZHydbWQgT3E0vAiM4S6BVugGONHaaZldQL4qO 1zR5xD3RdbwHznYgLp9KJ3T3aTjaSHJDyAjwf4oyiLPLroMqWX0cyRYikCJWCMZ/ 1eI6QKpRKgcRm0G2N8jOXoqN1GcRTzLIEeQLy2sNbvB1uZAudGYmaO9Nf9TPruR4 D9hBNK9uN4Sg3HrBt0QO/J9UbuW3f8qRdMuCX4GujmYlzwzlaT5mjnMDI/ASKQ+r +lg9OO/jEpj1RFPEA1SB2O7ZWRJfVGEJXDA2t+xG7RUtTlVF3s4hEvi/UJfy0nyJ BJdDPDJpcIqFFPUUK0tuqOWBK53y7w== =WhZc -----END PGP SIGNATURE----- --E7i4zwmWs5DOuDSH-- --===============8472746012970147352== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============8472746012970147352==--