From: Sam Ravnborg <sam@ravnborg.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Pawel Moll <pawel.moll@arm.com>,
Maxime Ripard <maxime.ripard@bootlin.com>,
Liviu Dudau <Liviu.Dudau@arm.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
dri-devel@lists.freedesktop.org, Sean Paul <sean@poorly.run>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] drm/pl111: Drop special pads config check
Date: Wed, 24 Jul 2019 20:54:17 +0200 [thread overview]
Message-ID: <20190724185417.GC22640@ravnborg.org> (raw)
In-Reply-To: <20190724134959.2365-2-linus.walleij@linaro.org>
On Wed, Jul 24, 2019 at 03:49:59PM +0200, Linus Walleij wrote:
> This drops the check of the surplus "pads" configuration
> from the device tree that is completely unused in the DRM
> driver.
>
> This was only used to work around limitations in the earlier
> fbdev driver.
>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Pawel Moll <pawel.moll@arm.com>
> Cc: Liviu Dudau <Liviu.Dudau@arm.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Always good to delete code.
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> ---
> drivers/gpu/drm/pl111/pl111_display.c | 16 ----------------
> 1 file changed, 16 deletions(-)
>
> diff --git a/drivers/gpu/drm/pl111/pl111_display.c b/drivers/gpu/drm/pl111/pl111_display.c
> index e42fb6353623..8595a676b084 100644
> --- a/drivers/gpu/drm/pl111/pl111_display.c
> +++ b/drivers/gpu/drm/pl111/pl111_display.c
> @@ -572,24 +572,8 @@ int pl111_display_init(struct drm_device *drm)
> {
> struct pl111_drm_dev_private *priv = drm->dev_private;
> struct device *dev = drm->dev;
> - struct device_node *endpoint;
> - u32 tft_r0b0g0[3];
> int ret;
>
> - endpoint = of_graph_get_next_endpoint(dev->of_node, NULL);
> - if (!endpoint)
> - return -ENODEV;
> -
> - if (of_property_read_u32_array(endpoint,
> - "arm,pl11x,tft-r0g0b0-pads",
> - tft_r0b0g0,
> - ARRAY_SIZE(tft_r0b0g0)) != 0) {
> - dev_err(dev, "arm,pl11x,tft-r0g0b0-pads should be 3 ints\n");
> - of_node_put(endpoint);
> - return -ENOENT;
> - }
> - of_node_put(endpoint);
> -
> ret = pl111_init_clock_divider(drm);
> if (ret)
> return ret;
> --
> 2.21.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-07-24 18:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 13:49 [PATCH 1/2] drm/pl111: Deprecate the pads from the DT binding Linus Walleij
2019-07-24 13:49 ` [PATCH 2/2] drm/pl111: Drop special pads config check Linus Walleij
2019-07-24 18:54 ` Sam Ravnborg [this message]
2019-07-24 18:49 ` [PATCH 1/2] drm/pl111: Deprecate the pads from the DT binding Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190724185417.GC22640@ravnborg.org \
--to=sam@ravnborg.org \
--cc=Liviu.Dudau@arm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=maxime.ripard@bootlin.com \
--cc=pawel.moll@arm.com \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).