From: David Miller <davem@davemloft.net>
To: navid.emamdoost@gmail.com
Cc: joabreu@synopsys.com, alexandre.torgue@st.com,
secalert@redhat.com, netdev@vger.kernel.org, kjlu@umn.edu,
linux-kernel@vger.kernel.org, emamd001@umn.edu,
mcoquelin.stm32@gmail.com, smccaman@umn.edu,
peppe.cavallaro@st.com, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] stmmac_dt_phy: null check the allocation
Date: Thu, 25 Jul 2019 11:52:56 -0700 (PDT) [thread overview]
Message-ID: <20190725.115256.1232519801887604352.davem@davemloft.net> (raw)
In-Reply-To: <20190723222809.9752-1-navid.emamdoost@gmail.com>
From: Navid Emamdoost <navid.emamdoost@gmail.com>
Date: Tue, 23 Jul 2019 17:28:09 -0500
> @@ -342,10 +342,13 @@ static int stmmac_dt_phy(struct plat_stmmacenet_data *plat,
> mdio = true;
> }
>
> - if (mdio)
> + if (mdio) {
> plat->mdio_bus_data =
> devm_kzalloc(dev, sizeof(struct stmmac_mdio_bus_data),
> GFP_KERNEL);
> + if (!plat->mdio_bus_data)
> + return -ENOMEM;
This leaks a reference to plat->mdio_node() which is acquired in the
for_each_child_of_node() loop right before the context here.
This is what I really fear about these automated patches, it is quite
often the case that acquired resources are subtly acquired in nearby
code and not released by the proposed "fix".
Therefore, either we end up with a regression, or as is the case here
a reviewer invests more time into double checking your patch than you
put into writing the patch in the first place.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-07-25 18:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 22:28 [PATCH] stmmac_dt_phy: null check the allocation Navid Emamdoost
2019-07-25 18:52 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190725.115256.1232519801887604352.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexandre.torgue@st.com \
--cc=emamd001@umn.edu \
--cc=joabreu@synopsys.com \
--cc=kjlu@umn.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=navid.emamdoost@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=secalert@redhat.com \
--cc=smccaman@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).