From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60FC4C76190 for ; Thu, 25 Jul 2019 21:11:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 39A6022BF5 for ; Thu, 25 Jul 2019 21:11:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dExErjoe"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="wT8fbumh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 39A6022BF5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:From:To:Subject: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8lviZ+wpsa5F6CFp30pbqCGwNSQYMV3p7xZzoEwjzvQ=; b=dExErjoeWYlBTW TEYR/KTJvIjJatVqRl3mXw9tvL3luhZ7vkJ1IT29rifa0Wudz84N75BB1jft+99Z8cprQeeHx6S+n bD6O0VmzGy4Nwf/LoirwnE6PXO2+U19dQxKpgFHJByJHyUeoLpcmjrFg2RJxnqyf+f2Cxt1vNdyLQ w6fBB+opgyKI+LZogU6C3SbCKPAoBJUUbg4iI9uF/ueHAqg0yOwzNpM3DmoqdNlRB/dXzh6VfIyZG 9AzUTPjNBoMcK9nsr9WYITRTUPDFtWZ9eJXF4LffSQRGV8gP17Mtq1UxfX2Je8hpR81p9eMrVhfG/ LFVTLBp/9w4yuSzpt3IQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hql12-0004l7-Of; Thu, 25 Jul 2019 21:11:08 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hql0z-0004kO-Fo; Thu, 25 Jul 2019 21:11:07 +0000 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0FD50218EA; Thu, 25 Jul 2019 21:11:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564089065; bh=CYo3ibcqoLW7F/S9064H4yTGj2/Ywl1wI1KXI8cO9jQ=; h=In-Reply-To:References:Subject:To:Cc:From:Date:From; b=wT8fbumh0wwybnsdU10c8jzKx0Z9uNF4KXmcnkTksF7ry3psFzsnrn+nlVPw9DyRT FPIfNzGFt8T1QQyEt8oAynRh4g7wAGeQWv77AVRPtyKlvq3tFI2409ySyy2PCD2tJ3 r2D/no8G4Os9dQqO3qiC9TZVQaWd5F7TZWsGujo0= MIME-Version: 1.0 In-Reply-To: <20190725082002.17400-2-yong.liang@mediatek.com> References: <20190725082002.17400-1-yong.liang@mediatek.com> <20190725082002.17400-2-yong.liang@mediatek.com> Subject: Re: [PATCH v4,2/2] clk: reset: Modify reset-controller driver To: Yong Liang , chunhui.dai@mediatek.com, drinkcat@chromium.org, eddie.huang@mediatek.com, erin.lo@mediatek.com, jamesjj.liao@mediatek.com, jasu@njomotys.info, mark.rutland@arm.com, matthias.bgg@gmail.com, mturquette@baylibre.com, owen.chen@mediatek.com, robh+dt@kernel.org, weiyi.lu@mediatek.com From: Stephen Boyd User-Agent: alot/0.8.1 Date: Thu, 25 Jul 2019 14:11:04 -0700 Message-Id: <20190725211105.0FD50218EA@mail.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190725_141105_568320_9BF56C91 X-CRM114-Status: GOOD ( 17.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "yong.liang" , linux-mediatek@lists.infradead.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Yong Liang (2019-07-25 01:20:02) > From: "yong.liang" > > Set reset signal by a register and clear reset signal by > another register for 8183. > > Signed-off-by: yong.liang > --- > > Base on https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git branch clk-next and https://patchwork.kernel.org/patch/10856987/ Use --base= in git format-patch instead. > diff --git a/drivers/clk/mediatek/clk-mt8183.c b/drivers/clk/mediatek/clk-mt8183.c > index 9d8651033ae9..f695eb7eb5a1 100644 > --- a/drivers/clk/mediatek/clk-mt8183.c > +++ b/drivers/clk/mediatek/clk-mt8183.c > @@ -1204,13 +1204,24 @@ static int clk_mt8183_infra_probe(struct platform_device *pdev) > { > struct clk_onecell_data *clk_data; > struct device_node *node = pdev->dev.of_node; > + int r; > > clk_data = mtk_alloc_clk_data(CLK_INFRA_NR_CLK); > > mtk_clk_register_gates(node, infra_clks, ARRAY_SIZE(infra_clks), > clk_data); > > - return of_clk_add_provider(node, of_clk_src_onecell_get, clk_data); > + r = of_clk_add_provider(node, of_clk_src_onecell_get, clk_data); > + if (r) { > + dev_err(&pdev->dev, > + "%s(): could not register clock provider: %d\n" > + ,__func__, r); > + return r; > + } > + > + mtk_register_reset_controller_set_clr(node, 4, 0x120); What is this line doing? Maybe add a comment so we understand what 0x120 is. > + > + return r; > } > > static int clk_mt8183_mcu_probe(struct platform_device *pdev) > diff --git a/drivers/clk/mediatek/reset.c b/drivers/clk/mediatek/reset.c > index d3551d5efef2..fccc8fcb6a20 100644 > --- a/drivers/clk/mediatek/reset.c > +++ b/drivers/clk/mediatek/reset.c > @@ -95,3 +131,18 @@ void mtk_register_reset_controller(struct device_node *np, > return; > } > } > + > +void mtk_register_reset_controller(struct device_node *np, > + unsigned int num_regs, int regofs) > +{ > + mtk_register_reset_controller_common(np, num_regs, regofs, > + &mtk_reset_ops); > +} > + > +void mtk_register_reset_controller_set_clr(struct device_node *np, > + unsigned int num_regs, int regofs) > +{ > + mtk_register_reset_controller_common(np, num_regs, regofs, > + &mtk_reset_ops_set_clr); > +} > + If this is an extra newline at the end of the file, please remove it. > diff --git a/include/dt-bindings/reset-controller/mt8183-resets.h b/include/dt-bindings/reset-controller/mt8183-resets.h > new file mode 100644 > index 000000000000..81136c932f75 > --- /dev/null > +++ b/include/dt-bindings/reset-controller/mt8183-resets.h > @@ -0,0 +1,88 @@ > +/* > + * Copyright (c) 2017 MediaTek Inc. > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. > + * See http://www.gnu.org/licenses/gpl-2.0.html for more details. Please use SPDX tags instead of this boilerplate. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel