From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BB1DC7618B for ; Mon, 29 Jul 2019 06:43:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E30EB206BA for ; Mon, 29 Jul 2019 06:43:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ni6gsRN9"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="bXmWlhMv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E30EB206BA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HHcjyqhn1d74VlQD5iyoSTuhBAW4MtXf5oCQAQBiX0M=; b=ni6gsRN9PNPJRr qkMo0Vw/JmpDoo+tVkjdwPAi3jDFu/U7nze8NLKqFLAO9xdCtqjwdGTyEKlqMvpE7vEEW87pW2lKG tLDMWhGr6lYah4Z/kpdxeoYEijBEuDkYdvcy+9ac396UP425osIAA7KIBFImLtdqJQu119r7A9sPS S1SmfngeTyjp9KD6hxv5ALgj+fWtOuI2wIPNfFRiMFzm9TO2DgaKJkHH2theO8GioLv8KgZA0TXiB dVEGUJUDmEKUapRar2LbEnBRiNCigqkUXdEfBnrZo/vqEg040ep+esuTFvT41oZMzU4efQGdWtjCn A6f8LNdRHNtVb4RMYwbw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hrzNd-0006gy-Ht; Mon, 29 Jul 2019 06:43:34 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hrzNS-0006fE-3R for linux-arm-kernel@lists.infradead.org; Mon, 29 Jul 2019 06:43:23 +0000 Received: from localhost (unknown [122.178.221.187]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 07343206BA; Mon, 29 Jul 2019 06:43:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564382601; bh=QmVZiVCVVdyuIOIXyrtNlQQDQrcJfU7dMvyEUty+IPs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bXmWlhMvHD6xcN7+Lm31x5rEuncHMBalyOq4wY58j5IQwnZlqAxmMNk07LDjFW0rW 9PtitSv8mvAKbxYNAy+sRyyKM9BBl69xaBafwpwMD/GMF22lL2DJnwJh0KFCPVZFEW GL9ohHYcA81k0qzR9AA+p4+J8pfKH/mziknK4m2k= Date: Mon, 29 Jul 2019 12:12:09 +0530 From: Vinod Koul To: Peter Ujfalusi Subject: Re: [PATCH v5 0/3] dmaengine: ti: edma: Polled completion support Message-ID: <20190729064209.GF12733@vkoul-mobl.Dlink> References: <20190716082655.1620-1-peter.ujfalusi@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190716082655.1620-1-peter.ujfalusi@ti.com> User-Agent: Mutt/1.11.3 (2019-02-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190728_234322_311715_DAE8ACD5 X-CRM114-Status: GOOD ( 17.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dmaengine@vger.kernel.org, dan.j.williams@intel.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 16-07-19, 11:26, Peter Ujfalusi wrote: > Hi, > > Changes since v4: > - Split the DMA_COMPLETE and !txstate check as Vinod suggested > > Change since v3: > - fix DMA pointer tracking for memcpy > - completion polling is only done when it is asked by not providing > DMA_PREP_INTERRUPT for memcpy > > Changes since v2: > - Fix typo in the comment for patch 0 > > Changes since v1: > - Cleanup patch for the array register handling > - typo fixed in patch2 commit message > > The code around the array register access was pretty confusing for the first > look, so clean them up first then use the cleaner way in the polled handling. > > When a DMA client driver does not set the DMA_PREP_INTERRUPT because it > does not want to use interrupts for DMA completion or because it can not > rely on DMA interrupts due to executing the memcpy when interrupts are > disabled it will poll the status of the transfer. > > Since we can not tell from any EDMA register that the transfer is > completed, we can only know that the paRAM set has been sent to TPTC for > processing we need to check the residue of the transfer, if it is 0 then > the transfer is completed. > > The polled completion can bve tested by applying: > https://patchwork.kernel.org/patch/10966499/ > > Enabling the memcpy for EDMA and run the dmatest with polled = 1. > > Or, enable the EDMA memcpy support and boot up any dra7 family device with > display enabled. The workaround for DMM errata i878 uses polled DMA memcpy. Applied, thanks. Fixed typo in 2nd patch while at it -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel