From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19B27C433FF for ; Mon, 29 Jul 2019 07:34:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E14FE216C8 for ; Mon, 29 Jul 2019 07:34:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="F8LpE9wf"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="gDCAi84q" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E14FE216C8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dcnrYWb6tp1Nk8z9X2gErXiQOCkAzw6AoFIDELCbNKQ=; b=F8LpE9wfqZooO7 RXw7T6G/KZRnOHm7DDPZbjHhrKc+X+DVLjU6+ksuVX2r9s70QjW3Vlew3O6Ufd1/2vd7EKKagZ5FF u6tQIIgL6BIxtC6y44kE2hExlVB/iot2+gS6dSF/xzv+to+fIKfeM/RozOdau8O0OMmE0udxQsN86 GAeQjtqOOO2nN2YKuZp94aIR4yjXJ8hWgkwCGHB+hlQneAPMDNDkBKNJcOBFe8IGo8+TW/qi6sbip kqdgzDZ+1TG8w4Q3n0nqylknBCUXLwZ+RYI+RRz1wMlYXyaGhW23/a9nOwVeT8iGl9D0MvUFQAR82 yZiKcSlicwwJBPZkjkfw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hs0B1-00043M-TI; Mon, 29 Jul 2019 07:34:35 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hs0Ay-00042m-Ji for linux-arm-kernel@lists.infradead.org; Mon, 29 Jul 2019 07:34:33 +0000 Received: from localhost (unknown [122.178.221.187]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 11F62216C8; Mon, 29 Jul 2019 07:34:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564385671; bh=t9LsxbTH4MpBJFWH0d4fER/3hJuiJvavkL6v8Hy/LVs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gDCAi84qIn4/Ux74deqn5LHJcGwjCrnLKaVJpn7EYNWaU92guoMzx37Vcdua72l7v 9KHbGzFgTN5M7Yj41gOsKfTma6DngePMAHQAliKx4QBoRnelDRdfvV/B5jPyEUjFLy KNTqe09gJWMBo/SIcTdKS3+dLAx55mY37Jj/IEkg= Date: Mon, 29 Jul 2019 13:03:19 +0530 From: Vinod Koul To: Peter Ujfalusi Subject: Re: [PATCH v5 0/3] dmaengine: ti: edma: Polled completion support Message-ID: <20190729073319.GK12733@vkoul-mobl.Dlink> References: <20190716082655.1620-1-peter.ujfalusi@ti.com> <20190729064209.GF12733@vkoul-mobl.Dlink> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.3 (2019-02-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190729_003432_667916_B62676E4 X-CRM114-Status: GOOD ( 16.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dmaengine@vger.kernel.org, dan.j.williams@intel.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 29-07-19, 10:24, Peter Ujfalusi wrote: > Vinod, > > On 29/07/2019 9.42, Vinod Koul wrote: > > On 16-07-19, 11:26, Peter Ujfalusi wrote: > >> Hi, > >> > >> Changes since v4: > >> - Split the DMA_COMPLETE and !txstate check as Vinod suggested > >> > >> Change since v3: > >> - fix DMA pointer tracking for memcpy > >> - completion polling is only done when it is asked by not providing > >> DMA_PREP_INTERRUPT for memcpy > >> > >> Changes since v2: > >> - Fix typo in the comment for patch 0 > >> > >> Changes since v1: > >> - Cleanup patch for the array register handling > >> - typo fixed in patch2 commit message > >> > >> The code around the array register access was pretty confusing for the first > >> look, so clean them up first then use the cleaner way in the polled handling. > >> > >> When a DMA client driver does not set the DMA_PREP_INTERRUPT because it > >> does not want to use interrupts for DMA completion or because it can not > >> rely on DMA interrupts due to executing the memcpy when interrupts are > >> disabled it will poll the status of the transfer. > >> > >> Since we can not tell from any EDMA register that the transfer is > >> completed, we can only know that the paRAM set has been sent to TPTC for > >> processing we need to check the residue of the transfer, if it is 0 then > >> the transfer is completed. > >> > >> The polled completion can bve tested by applying: > >> https://patchwork.kernel.org/patch/10966499/ > > Should I resend this patch so the polled mode can be tested in upstream? Yes sure -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel