From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Chunfeng Yun <chunfeng.yun@mediatek.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linus Walleij <linus.walleij@linaro.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Biju Das <biju.das@bp.renesas.com>,
Badhri Jagan Sridharan <badhri@google.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org,
Min Guo <min.guo@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
linux-arm-kernel@lists.infradead.org, Li Jun <jun.li@nxp.com>
Subject: Re: [PATCH v8 08/11] usb: roles: get usb-role-switch from parent
Date: Mon, 29 Jul 2019 17:25:00 +0300 [thread overview]
Message-ID: <20190729142500.GE28600@kuha.fi.intel.com> (raw)
In-Reply-To: <1563958245-6321-9-git-send-email-chunfeng.yun@mediatek.com>
On Wed, Jul 24, 2019 at 04:50:42PM +0800, Chunfeng Yun wrote:
> when the USB host controller is the parent of the connector,
> usually type-B, sometimes don't need the graph, so we should
> check whether it's parent registers usb-role-switch or not
> firstly, and get it if exists.
>
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
I don't think I actually wrote the patch. I may have proposed the code
for you, but I never prepared a patch out out that. Please drop the
above Signed-off-by line if that is the case. I case I really did
write the patch, then you are missing the "From: Heikki..." first
line, but I really don't remember preparing the patch.
If the idea came from me, you can use for example the suggested-by
tag: "Suggested-by: Heikki Krogerus <heikki.krogerus...".
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
> v8: no changes
> v7:
> add signed-off-by Chunfeng
>
> v6:
> new patch
> ---
> drivers/usb/roles/class.c | 25 +++++++++++++++++++++----
> 1 file changed, 21 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/roles/class.c b/drivers/usb/roles/class.c
> index 5b637aaf311f..87439a84c983 100644
> --- a/drivers/usb/roles/class.c
> +++ b/drivers/usb/roles/class.c
> @@ -114,6 +114,19 @@ static void *usb_role_switch_match(struct device_connection *con, int ep,
> return dev ? to_role_switch(dev) : ERR_PTR(-EPROBE_DEFER);
> }
>
> +static struct usb_role_switch *
> +usb_role_switch_is_parent(struct fwnode_handle *fwnode)
> +{
> + struct fwnode_handle *parent = fwnode_get_parent(fwnode);
> + struct device *dev;
> +
> + if (!parent || !fwnode_property_present(parent, "usb-role-switch"))
> + return NULL;
> +
> + dev = class_find_device(role_class, NULL, parent, switch_fwnode_match);
> + return dev ? to_role_switch(dev) : ERR_PTR(-EPROBE_DEFER);
> +}
> +
> /**
> * usb_role_switch_get - Find USB role switch linked with the caller
> * @dev: The caller device
> @@ -125,8 +138,10 @@ struct usb_role_switch *usb_role_switch_get(struct device *dev)
> {
> struct usb_role_switch *sw;
>
> - sw = device_connection_find_match(dev, "usb-role-switch", NULL,
> - usb_role_switch_match);
> + sw = usb_role_switch_is_parent(dev_fwnode(dev));
> + if (!sw)
> + sw = device_connection_find_match(dev, "usb-role-switch", NULL,
> + usb_role_switch_match);
>
> if (!IS_ERR_OR_NULL(sw))
> WARN_ON(!try_module_get(sw->dev.parent->driver->owner));
> @@ -146,8 +161,10 @@ struct usb_role_switch *fwnode_usb_role_switch_get(struct fwnode_handle *fwnode)
> {
> struct usb_role_switch *sw;
>
> - sw = fwnode_connection_find_match(fwnode, "usb-role-switch", NULL,
> - usb_role_switch_match);
> + sw = usb_role_switch_is_parent(fwnode);
> + if (!sw)
> + sw = fwnode_connection_find_match(fwnode, "usb-role-switch",
> + NULL, usb_role_switch_match);
> if (!IS_ERR_OR_NULL(sw))
> WARN_ON(!try_module_get(sw->dev.parent->driver->owner));
>
> --
> 2.21.0
thanks,
--
heikki
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-07-29 14:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 8:50 [PATCH v8 00/11] add USB GPIO based connection detection driver Chunfeng Yun
2019-07-24 8:50 ` [PATCH v8 01/11] dt-binding: usb: add usb-role-switch property Chunfeng Yun
2019-07-24 8:50 ` [PATCH v8 02/11] dt-bindings: connector: add optional properties for Type-B Chunfeng Yun
2019-08-05 10:09 ` Linus Walleij
2019-07-24 8:50 ` [PATCH v8 03/11] dt-bindings: usb: add binding for USB GPIO based connection detection driver Chunfeng Yun
2019-08-05 10:08 ` Linus Walleij
2019-07-24 8:50 ` [PATCH v8 04/11] dt-bindings: usb: mtu3: add properties about USB Role Switch Chunfeng Yun
2019-07-24 8:50 ` [PATCH v8 05/11] usb: roles: Introduce stubs for the exiting functions in role.h Chunfeng Yun
2019-07-24 8:50 ` [PATCH v8 06/11] device connection: Add fwnode_connection_find_match() Chunfeng Yun
2019-07-24 8:50 ` [PATCH v8 07/11] usb: roles: Add fwnode_usb_role_switch_get() function Chunfeng Yun
2019-07-24 8:50 ` [PATCH v8 08/11] usb: roles: get usb-role-switch from parent Chunfeng Yun
2019-07-29 14:25 ` Heikki Krogerus [this message]
2019-07-31 6:29 ` Chunfeng Yun
2019-07-24 8:50 ` [PATCH v8 09/11] usb: common: create Kconfig file Chunfeng Yun
2019-07-24 8:50 ` [PATCH v8 10/11] usb: common: add USB GPIO based connection detection driver Chunfeng Yun
2019-08-05 10:10 ` Linus Walleij
2019-07-24 8:50 ` [PATCH v8 11/11] usb: mtu3: register a USB Role Switch for dual role mode Chunfeng Yun
2019-08-05 10:06 ` [PATCH v8 00/11] add USB GPIO based connection detection driver Linus Walleij
2019-08-06 7:48 ` Chunfeng Yun
2019-08-06 13:26 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190729142500.GE28600@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=Adam.Thomson.Opensource@diasemi.com \
--cc=andy.shevchenko@gmail.com \
--cc=badhri@google.com \
--cc=biju.das@bp.renesas.com \
--cc=chunfeng.yun@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=jun.li@nxp.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=min.guo@mediatek.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).