From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4345C7618B for ; Mon, 29 Jul 2019 17:24:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 78D9C2070B for ; Mon, 29 Jul 2019 17:24:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="A8Fr/IkO"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="UgMSXtEd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 78D9C2070B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=H+FZZe8bKP0LWECj8KqtnqkO0BliSQP+y7NnyMLmOMk=; b=A8Fr/IkOEReXaZ 4pbCzl3ONfeV0ibQuXcQUUfh3bioxmBQ9sOpKxr2ymgxM3fJe6BQQrJiyEZf8r358d67ouv+DVGbJ vwe2H51RVewlbGQyKTYgveiEuh9OPcG6MSwP+zCF+rjSpmvFUZzuZbLZt1JGVAlVLZNxtsGfTuPiT eK4f22Pp4T4vctY4RyF0Su4tC3qwZdfRaOQ+V4LV08GSQdX/tamalqMjd950LKTG2SO9nvov9p+4S +EknPyNQi0JPZ80LD0LLxqU7Hqkpxffh2j987b6tlPCkyqrAmR8SMg4x6tsT8WNMPy/SbpqycKPsa nsyqPqoOcoSzB2h8pqmQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hs9Nm-0007g0-1V; Mon, 29 Jul 2019 17:24:22 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hs9Nj-0007fg-O5 for linux-arm-kernel@lists.infradead.org; Mon, 29 Jul 2019 17:24:20 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D9012206DD; Mon, 29 Jul 2019 17:24:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564421059; bh=ejbyHcqYBb2roKhKeGT35luwC+25Ji49Pree87xpLKE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UgMSXtEdfOi+JaV95hk+t+/Trj+nl7L6OGc7IzvIq2AdbEI0fvNxuiGg9gkgpfvmu 9JCAlenqDfkqSt7QP0bGX0TNWsSe+TOp0L8Vlcg3T7Ngm6aYqdD04yG5vkNpGx96RI Pj6PyB3hqNTU3sl2ww6bvQEa+jA6J5hOYnMpuSWA= Date: Mon, 29 Jul 2019 18:24:15 +0100 From: Will Deacon To: Kees Cook Subject: Re: [PATCH v5] arm64: kernel: implement fast refcount checking Message-ID: <20190729172414.odpcqugvtcwjnbe5@willie-the-truck> References: <20190619105431.2630-1-ard.biesheuvel@linaro.org> <20190703134028.6aru52r2zd2jnpm4@willie-the-truck> <20190710122117.kk5xgei56r7vfmmj@willie-the-truck> <201907220942.69F916657@keescook> <20190722171141.3cgmw5ej7p2caddn@willie-the-truck> <201907221024.3BC2ABB13A@keescook> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <201907221024.3BC2ABB13A@keescook> User-Agent: NeoMutt/20170113 (1.7.2) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190729_102419_803072_D51F2D06 X-CRM114-Status: GOOD ( 12.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ard Biesheuvel , Catalin Marinas , Jan Glauber , Will Deacon , Jayachandran Chandrasekharan Nair , Hanjun Guo , Linus Torvalds , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 22, 2019 at 10:27:07AM -0700, Kees Cook wrote: > On Mon, Jul 22, 2019 at 06:11:42PM +0100, Will Deacon wrote: > > On Mon, Jul 22, 2019 at 09:43:54AM -0700, Kees Cook wrote: > > > (Also, what happened to the *_checked() variations?) > > > > The new implementation is intended to replace the *_checked() variants, > > and the discrepancy in naming doesn't make any sense to me once everything > > is inline in the header file. Am I missing something? > > I haven't looked at the resulting builds, but the reason for the > _checked() macro stuff was to provide a way for callers to opt into a > checked refcount_t regardless of the state of REFCOUNT_FULL (especially > for architectures without special refcount handling). If that is > retained, then all is well. It just looked odd to me in the patch. Hmm, so that has a grand total of zero users in mainline afaict. Do you expect that to change? Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel