From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13148C32751 for ; Wed, 31 Jul 2019 16:06:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DBE74208E3 for ; Wed, 31 Jul 2019 16:06:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="l93HZ4hG"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="nXhNdnpz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DBE74208E3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wNFngOtQ547y+5KbRIAB0p7j7XxRYJTDuMBbLzpRUNw=; b=l93HZ4hG9W+3re JBiP2iGvPAF52yYjhRWGZR9TpLHp63EO3ApVHjovGpS1WlXP/b1CnPjU92TWkJr5rfHz3F6aBSwea vnCv4Ar+K9KsVtacwog443vwWAA+L/Px/W/GNR8BxLSSQaBPq1Jq0NVBZGrhaYzMqHuwpNGyGIYus afJoPPFDtaP1+SUXwwjRHD43Vi0gEHpflTruTcCQ8pPVEwFw38x+olR51GUOIVL5K/4SsrrDknG7R HolcbXPM/D8G6N0tZtpsAN0twAI3wCaxxJflAVaPFX1P2z95/6WM/s8d+DjLZtY34YqFic06t9tqI swTfZwm7+znjbA6lBc/Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hsr7E-0004al-GH; Wed, 31 Jul 2019 16:06:12 +0000 Received: from mail-pg1-x544.google.com ([2607:f8b0:4864:20::544]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hsr7B-0004aK-V6 for linux-arm-kernel@lists.infradead.org; Wed, 31 Jul 2019 16:06:11 +0000 Received: by mail-pg1-x544.google.com with SMTP id n190so815436pgn.0 for ; Wed, 31 Jul 2019 09:06:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=dw5dQKwX8ASG6Ts6LgBuSFToiWxM+evOZX45eitYT60=; b=nXhNdnpzQ5klubCtfPKL3rrjBDdkcECAJhbzNalPGdQFtuHxtHL5KFS8kYJxX01zI+ 3GqX/EXvBnWwabWBFeHJWv8ENvMiwnd744dcdIMl23dIdrN9eqdKH3FEaOzYWG/FLHW+ snA2P3tt9xmBEcE0wzL9JO6YiPQXK/ecFHfTM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=dw5dQKwX8ASG6Ts6LgBuSFToiWxM+evOZX45eitYT60=; b=UZuDUJM3R1wkG8E3751vsGpYOdQcLd9wU/jMu7zKBztEj+ts1kBsdqwwlch9HBmlnB p6sLVd7Wsroz2ZIFajhpRfeOaT/O6sd4HbG3TgqooeYiKlgtMfVaji7Vqchfb8ywaC+D DIFmM4cBpJbzPw+ZlZlr3PWhqmV+Jw+7WRIGSBClPv1KvqZgzswuAE4IRMl+8KPDGCvl kSzzlic0F1+kv64ylIrtljpMeqHLHoq6+qsHmFb4bOnSYotMNDua+b3ZMUIWZXpJb0QV t5SmKLKTCITi8yPWKk+xGKgZACVwBCFyMNWjt2+Q1RnCHZYleGCOglueEjB1uSop064I ekqw== X-Gm-Message-State: APjAAAXorOnqYrUIS455yh6KX8/Rxd7zZVjaCQYVgKBfPSQdYlKFMm2v SHuBmqBGpZfLkvYogzY/nX44HA== X-Google-Smtp-Source: APXvYqyp+rY/4Em+/ZUkiOjo98nR6upEwWWg4wXYmcr0OQ9k/QFwbGOVWkGPKkn54UdzEr838uzIjQ== X-Received: by 2002:a63:ff03:: with SMTP id k3mr19399349pgi.40.1564589168950; Wed, 31 Jul 2019 09:06:08 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id j15sm98920836pfn.150.2019.07.31.09.06.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 31 Jul 2019 09:06:08 -0700 (PDT) Date: Wed, 31 Jul 2019 09:06:07 -0700 From: Kees Cook To: "Gustavo A. R. Silva" , Ulf Hansson , Nicolas Ferre , Alexandre Belloni , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Stephen Rothwell Subject: Re: [PATCH] mmc: atmel-mci: Mark expected switch fall-throughs Message-ID: <201907310905.B90C6E25@keescook> References: <20190729000123.GA23902@embeddedor> <20190731113216.ztxckd54a74g2lw5@M43218.corp.atmel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190731113216.ztxckd54a74g2lw5@M43218.corp.atmel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190731_090610_022026_08B2B979 X-CRM114-Status: GOOD ( 11.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 31, 2019 at 01:32:16PM +0200, Ludovic Desroches wrote: > > drivers/mmc/host/atmel-mci.c:2426:40: warning: this statement may fall through [-Wimplicit-fallthrough=] > > host->caps.need_notbusy_for_read_ops = 1; > > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~ > > drivers/mmc/host/atmel-mci.c:2427:2: note: here > > case 0x100: > > ^~~~ > > > > Reported-by: Stephen Rothwell > > Signed-off-by: Gustavo A. R. Silva > > I don't know if there is a policy in the kernel about the expression to > use. As this one does the job Yup, documented here: https://www.kernel.org/doc/html/latest/process/deprecated.html#implicit-switch-case-fall-through > Acked-by: Ludovic Desroches Thanks! -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel